| Message ID | 20210427224201.32285-1-tsbogend@alpha.franken.de |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-binding: interrupt-controller: Add missing interrupts property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote: > Interrupts property is required, so add it. > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > --- > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@1c20400: 'oneOf' conditional failed, one must be fixed: 'interrupts' is a required property 'interrupts-extended' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml See https://patchwork.ozlabs.org/patch/1470883 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote: > On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote: > > Interrupts property is required, so add it. > > > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > --- > > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@1c20400: 'oneOf' conditional failed, one must be fixed: > 'interrupts' is a required property > 'interrupts-extended' is a required property > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml now I'm confused... is this a problem of your test ? make dt_binding_check was ok with that change... Thomas.
On Wed, Apr 28, 2021 at 5:42 PM Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote: > > On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote: > > On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote: > > > Interrupts property is required, so add it. > > > > > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > > --- > > > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@1c20400: 'oneOf' conditional failed, one must be fixed: > > 'interrupts' is a required property > > 'interrupts-extended' is a required property > > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml > > now I'm confused... is this a problem of your test ? make dt_binding_check > was ok with that change... You and me both. I'll look into it when I apply. Rob
On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote: > Interrupts property is required, so add it. > > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > --- > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Applied, thanks! All fine in my build, so not sure what happened to the bot...
diff --git a/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml b/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml index df5d8d1ead70..160ff4b07cac 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/idt,32434-pic.yaml @@ -22,6 +22,9 @@ properties: reg: maxItems: 1 + interrupts: + maxItems: 1 + interrupt-controller: true required: @@ -29,6 +32,7 @@ required: - compatible - reg - interrupt-controller + - interrupts additionalProperties: false
Interrupts property is required, so add it. Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> --- .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++ 1 file changed, 4 insertions(+)