| Message ID | 20210319180632.585-2-martinax.krasteva@linux.intel.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Keem Bay Camera Subsystem | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 19 Mar 2021 18:06:23 +0000, Martina Krasteva wrote: > From: Martina Krasteva <martinax.krasteva@intel.com> > > - Add dt-bindings documentation for Intel Keem Bay Camera driver. > - Add MAINTAINERS entry for Intel Keem Bay Camera binding > documentation. > > Co-developed-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > Signed-off-by: Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com> > Signed-off-by: Martina Krasteva <martinax.krasteva@intel.com> > Acked-by: Paul J. Murphy <paul.j.murphy@intel.com> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > --- > .../bindings/media/intel,keembay-camera.yaml | 98 ++++++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 106 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/intel,keembay-camera.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports:properties:required: ['reg', 'endpoint'] is not of type 'object', 'boolean' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports:required:2: 'port@[0-5]' does not match '^([a-zA-Z#][a-zA-Z0-9,+\\-._@]{0,63}|\\$nodename)$' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports: Additional properties are not allowed ('#size-cells', '#address-cells' were unexpected) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports: '#address-cells' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports: '#size-cells' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports:properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'required' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports: '#address-cells' is not one of ['type', 'description', 'dependencies', 'properties', 'patternProperties', 'additionalProperties', 'unevaluatedProperties', 'deprecated', 'required', 'allOf', 'anyOf', 'oneOf', '$ref'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: properties:ports: '#size-cells' is not one of ['type', 'description', 'dependencies', 'properties', 'patternProperties', 'additionalProperties', 'unevaluatedProperties', 'deprecated', 'required', 'allOf', 'anyOf', 'oneOf', '$ref'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml: ignoring, error in schema: properties: ports: properties: required warning: no schema found in file: ./Documentation/devicetree/bindings/media/intel,keembay-camera.yaml See https://patchwork.ozlabs.org/patch/1455960 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml b/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml new file mode 100644 index 000000000000..78242b05228d --- /dev/null +++ b/Documentation/devicetree/bindings/media/intel,keembay-camera.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2021 Intel Corporation +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/intel,keembay-camera.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Intel Keem Bay camera subsystem + +maintainers: + - Paul J. Murphy <paul.j.murphy@intel.com> + - Daniele Alessandrelli <daniele.alessandrelli@intel.com> + +properties: + compatible: + const: intel,keembay-camera + memory-region: + $ref: /schemas/types.yaml#/definitions/phandle + + ports: + type: object + $ref: /schemas/graph.yaml#/properties/ports + + "#address-cells": + const: 1 + "#size-cells": + const: 0 + + properties: + port@[0-5]: + type: object + additionalProperties: false + $ref: /schemas/graph.yaml#/properties/port + description: + The port number matches the D-PHY number (D-PHY#0 - D-PHY#5). + + properties: + endpoint: + type: object + + properties: + data-lanes: + $ref: video-interfaces.yaml#/properties/data-lanes + description: + Six two-lane d-phys (D-PHY#0 - D-PHY#5) are available, which + can be used by six RX controllers (RX-CTRL#0 - RX-CTRL#5). + RX-CTRL#0, RX-CTRL#2, RX-CTRL#4 can be connected to two + D-PHY's and will be able to work with 3 and 4 lanes. In this + case the RX-CTRLs mapped to those D-PHYs cannot be used. + + Clock and data lanes are defined as follows + D-PHY#0 - clock - 0, data - 1, 2 + D-PHY#1 - clock - 3, data - 4, 5 + D-PHY#2 - clock - 6, data - 7, 8 + D-PHY#3 - clock - 9, data - 10, 11 + D-PHY#4 - clock - 12, data - 13, 14 + D-PHY#5 - clock - 15, data - 16, 17 + + required: + - data-lanes + + required: + - reg + - endpoint + + required: + - "#address-cells" + - "#size-cells" + - port@[0-5] + +required: + - compatible + - ports + + +additionalProperties: false + +examples: + - | + keembay_camera { + compatible = "intel,keembay-camera"; + memory-region = <&mem>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@4 { + reg = <4>; + + cam: endpoint { + remote-endpoint = <&imx334>; + data-lanes = <13 14 16 17>; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 08f9c2b7f3b3..c3f583ef8e46 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1965,6 +1965,14 @@ M: Lennert Buytenhek <kernel@wantstofly.org> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained +ARM/INTEL KEEM BAY CAMERA SUBSYSTEM +M: Paul J. Murphy <paul.j.murphy@intel.com> +M: Daniele Alessandrelli <daniele.alessandrelli@intel.com> +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/intel,keembay-camera.yaml + ARM/IP FABRICS DOUBLE ESPRESSO MACHINE SUPPORT M: Lennert Buytenhek <kernel@wantstofly.org> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)