| Message ID | 20210202175439.3904060-2-robh@kernel.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] dt-bindings: usb: generic-ehci: Add missing compatible strings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Tue, Feb 02, 2021 at 11:54:39AM -0600, Rob Herring wrote: > The generic OHCI binding needs to document all the specific compatible > strings so we can track undocumented compatible strings. Add all the > compatible strings from in tree users. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/usb/generic-ohci.yaml | 34 +++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) Both look fine to me, do you want me to take this through my trees or will you take them? If you want to, fine with me: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> If not, just let me know and I will pick them up. thanks, greg k-h
On Wed, Feb 03, 2021 at 10:07:47AM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 11:54:39AM -0600, Rob Herring wrote: > > The generic OHCI binding needs to document all the specific compatible > > strings so we can track undocumented compatible strings. Add all the > > compatible strings from in tree users. > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: linux-usb@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/usb/generic-ohci.yaml | 34 +++++++++++++++++-- > > 1 file changed, 32 insertions(+), 2 deletions(-) > > Both look fine to me, do you want me to take this through my trees or > will you take them? You'd better take them. I don't think they conflict with any of the other USB binding changes, but there have been a few this cycle IIRC. Rob
On Wed, Feb 03, 2021 at 03:08:34PM -0600, Rob Herring wrote: > On Wed, Feb 03, 2021 at 10:07:47AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Feb 02, 2021 at 11:54:39AM -0600, Rob Herring wrote: > > > The generic OHCI binding needs to document all the specific compatible > > > strings so we can track undocumented compatible strings. Add all the > > > compatible strings from in tree users. > > > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Cc: linux-usb@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > .../devicetree/bindings/usb/generic-ohci.yaml | 34 +++++++++++++++++-- > > > 1 file changed, 32 insertions(+), 2 deletions(-) > > > > Both look fine to me, do you want me to take this through my trees or > > will you take them? > > You'd better take them. I don't think they conflict with any of the > other USB binding changes, but there have been a few this cycle IIRC. Ok, now queued up, thanks! greg k-h
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml index 2178bcc401bc..53df281f618c 100644 --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml @@ -14,8 +14,38 @@ maintainers: properties: compatible: - contains: - const: generic-ohci + oneOf: + - items: + - enum: + - allwinner,sun4i-a10-ohci + - allwinner,sun50i-a64-ohci + - allwinner,sun50i-h6-ohci + - allwinner,sun5i-a13-ohci + - allwinner,sun6i-a31-ohci + - allwinner,sun7i-a20-ohci + - allwinner,sun8i-a23-ohci + - allwinner,sun8i-h3-ohci + - allwinner,sun8i-r40-ohci + - allwinner,sun9i-a80-ohci + - brcm,bcm3384-ohci + - brcm,bcm63268-ohci + - brcm,bcm6328-ohci + - brcm,bcm6358-ohci + - brcm,bcm6362-ohci + - brcm,bcm6368-ohci + - brcm,bcm7125-ohci + - brcm,bcm7346-ohci + - brcm,bcm7358-ohci + - brcm,bcm7360-ohci + - brcm,bcm7362-ohci + - brcm,bcm7420-ohci + - brcm,bcm7425-ohci + - brcm,bcm7435-ohci + - ibm,476gtr-ohci + - ingenic,jz4740-ohci + - snps,hsdk-v1.0-ohci + - const: generic-ohci + - const: generic-ohci reg: maxItems: 1
The generic OHCI binding needs to document all the specific compatible strings so we can track undocumented compatible strings. Add all the compatible strings from in tree users. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/usb/generic-ohci.yaml | 34 +++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-)