| Message ID | 20210114113538.1233933-1-maxime@cerno.tech |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [01/19] dt-bindings: sunxi: Fix the pinecube compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/dtbs-check | success | |
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 9 lines checked |
| robh/dt-meta-schema | success |
Dne četrtek, 14. januar 2021 ob 12:35:20 CET je Maxime Ripard napisal(a): > Commit 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property > to other S3 boards") changed the pinecube compatible to make it similar > to the other S3 boards we have, but failed to update the bindings > documentation. > > Fixes: 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property to other S3 boards") > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:26 CET je Maxime Ripard napisal(a): > The pwm-backlight binding requires a power supply. Make sure we provide > one. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:25 CET je Maxime Ripard napisal(a): > According to the LED bindings, the LED node names are supposed to be led > plus an optional suffix. Let's fix our users to use that new scheme. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:27 CET je Maxime Ripard napisal(a): > The CPU thermal zone is called on most of the older DTSI cpu_thermal. > However, the underscore is an invalid character for a node name and the > thermal zone binding explicitly requires that zones are called > *-thermal. Let's fix it. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:28 CET je Maxime Ripard napisal(a): > The thermal zone binding requires a trips node with a list of trip > points, however some thermal zones (usually the GPU ones) in our DTSI > don't provide it. > > Remove them until we have something to fill there. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:29 CET je Maxime Ripard napisal(a): > The mma8452 binding doesn't expect an io-channel-cells property, let's > remove it. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:30 CET je Maxime Ripard napisal(a): > Even though it translates to the same thing down to the binary level, we > should have an array of 2 number cells to describe each voltage state, > which in turns create a validation warning. > > Let's fix this. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:31 CET je Maxime Ripard napisal(a): > While the USB PHY Device Tree mandates that the name of the ID detect pin > should be usb0_id_det-gpios, a significant number of device tree use > usb0_id_det-gpio instead. > > This was functional because the GPIO framework falls back to the gpio > suffix that is legacy, but we should fix this. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:32 CET je Maxime Ripard napisal(a): > Our CSI endpoint trigger some DTC warnings due to the fact that we're > having a single endpoint that doesn't need any reg property, and since > we don't have a reg property, we don't need the address-cells and > size-cells properties anymore. > > Fix those > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:33 CET je Maxime Ripard napisal(a): > The empty CSI port triggers a dt-validate warning. Let's align with the > other DTSI and remove it entirely, expecting the DTS to fill it. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:34 CET je Maxime Ripard napisal(a): > The SinA33 panel is missing its power-supply property, even though the > binding mandates it. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:35 CET je Maxime Ripard napisal(a): > DTC and the dt-validate tools report warnings for opp with the format > opp@$frequency: dtc for a missing reg property, and dt-validate since > the binding requires child nodes to have the format opp-$frequency. > > Change this to the latter format. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:36 CET je Maxime Ripard napisal(a): > The stk3311 binding don't expect a vdd or leda power supplies. Remove > them. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:37 CET je Maxime Ripard napisal(a): > The commit 7fa40ca7ef61 ("arm64: allwinner: dts: a64: add DT for Early > Adopter's PineTab") introduced an ili9881-based panel device node but > didn't conform to the binding. Fix this. > > Fixes: 7fa40ca7ef61 ("arm64: allwinner: dts: a64: add DT for Early Adopter's PineTab") > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
Dne četrtek, 14. januar 2021 ob 12:35:38 CET je Maxime Ripard napisal(a): > The commit 53441b8ef7de ("arm64: dts: allwinner: h6: PineH64 model B: > Add bluetooth") introduced the Bluetooth chip for the PineH64 model B, > but the GPIOs property didn't conform to the binding of the bluetooth > chip. Let's fix this. > > Fixes: 53441b8ef7de ("arm64: dts: allwinner: h6: PineH64 model B: Add bluetooth") > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Sorry for that. Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej
On Thu, Jan 14, 2021 at 7:35 PM Maxime Ripard <maxime@cerno.tech> wrote: > > Commit 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property > to other S3 boards") changed the pinecube compatible to make it similar > to the other S3 boards we have, but failed to update the bindings > documentation. > > Fixes: 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property to other S3 boards") > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Chen-Yu Tsai <wens@csie.org> for the whole series.
On Fri, Jan 15, 2021 at 10:41:04AM +0800, Chen-Yu Tsai wrote: > On Thu, Jan 14, 2021 at 7:35 PM Maxime Ripard <maxime@cerno.tech> wrote: > > > > Commit 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property > > to other S3 boards") changed the pinecube compatible to make it similar > > to the other S3 boards we have, but failed to update the bindings > > documentation. > > > > Fixes: 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property to other S3 boards") > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > for the whole series. Applied all the patches but the 4 and 5 that had comments Thanks! Maxime
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index 7ea4d9645e93..08607c7ec1bf 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -657,7 +657,8 @@ properties: - description: Pine64 PineCube items: - const: pine64,pinecube - - const: allwinner,sun8i-s3 + - const: sochip,s3 + - const: allwinner,sun8i-v3 - description: Pine64 PineH64 model A items:
Commit 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property to other S3 boards") changed the pinecube compatible to make it similar to the other S3 boards we have, but failed to update the bindings documentation. Fixes: 6ab48105aae7 ("ARM: dts: s3: pinecube: align compatible property to other S3 boards") Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- Documentation/devicetree/bindings/arm/sunxi.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)