diff mbox series

[v1,1/2] dt-bindings: arm: fsl: add Protonic MVT board

Message ID 20201130131406.10925-1-o.rempel@pengutronix.de
State Superseded, archived
Headers show
Series [v1,1/2] dt-bindings: arm: fsl: add Protonic MVT board | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Oleksij Rempel Nov. 30, 2020, 1:14 p.m. UTC
Add Protonic MVT imx6dl based board

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam Nov. 30, 2020, 1:22 p.m. UTC | #1
Hi Oleksij,

On Mon, Nov 30, 2020 at 10:14 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> +&ecspi1 {
> +       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;

Shouldn't this be GPIO_ACTIVE_LOW instead?
Oleksij Rempel Dec. 1, 2020, 7:10 a.m. UTC | #2
On Mon, Nov 30, 2020 at 10:22:38AM -0300, Fabio Estevam wrote:
> Hi Oleksij,
> 
> On Mon, Nov 30, 2020 at 10:14 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> 
> > +&ecspi1 {
> > +       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> 
> Shouldn't this be GPIO_ACTIVE_LOW instead?

ACK, it was fixed up by this code:
https://elixir.bootlin.com/linux/v5.10-rc6/source/drivers/gpio/gpiolib-of.c#L210

So, it was still working.

Thank you! I'll fix it.

Regards,
Oleksij
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index cd0b8a3d143f..01a10a9c4b13 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -371,6 +371,7 @@  properties:
               - ply,plybas                # Plymovent BAS board
               - ply,plym2m                # Plymovent M2M board
               - poslab,imx6dl-savageboard # Poslab SavageBoard Dual
+              - prt,prtmvt                # Protonic MVT board
               - prt,prtrvt                # Protonic RVT board
               - prt,prtvt7                # Protonic VT7 board
               - rex,imx6dl-rex-basic      # Rex Basic i.MX6 Dual Lite Board