| Message ID | 20201113134417.471445-3-maxime.chevallier@bootlin.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | media: i2c: Introduce driver for the TW9900 decoder | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 13 Nov 2020 14:44:16 +0100, Maxime Chevallier wrote: > The Techwell TW9900 is a video decoder supporting multiple input > standards, such as PAL, NTSC and SECAM, and outputs a BT.656 video > signal. > > It's designed to be low-power, posesses some features such as a > programmable comb-filter, and automatic input standard detection. > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > v1->v2: Fix the example not compiling > > .../devicetree/bindings/media/i2c/tw9900.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/tw9900.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/tw9900.example.dt.yaml: tw9900@44: 'reset-gpio' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/tw9900.yaml See https://patchwork.ozlabs.org/patch/1399805 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/media/i2c/tw9900.yaml b/Documentation/devicetree/bindings/media/i2c/tw9900.yaml new file mode 100644 index 000000000000..fa7e237ca7a6 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/tw9900.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/tw9900.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Techwell TW9900 NTSC/PAL/SECAM video decoder + +maintainers: + - Maxime Chevallier <maxime.chevallier@bootlin.com> + +description: + The tw9900 is a multi-standard video decoder, supporting NTSC, PAL and SECAM + standards with auto-detection features. + +properties: + compatible: + items: + - enum: + - techwell,tw9900 + + reg: + maxItems: 1 + + vdd-supply: + description: VDD power supply + + port: + type: object + description: + A node containing a single endpoint as doucmented in + Documentation/devicetree/bindings/media/video-interfaces.txt + +additionalProperties: false + +required: + - compatible + - reg + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + tw9900: tw9900@44 { + compatible = "techwell,tw9900"; + reg = <0x44>; + + vdd-supply = <&tw9900_supply>; + reset-gpio = <&gpio2 5 GPIO_ACTIVE_LOW>; + + port { + tw9900_out: endpoint { + remote-endpoint = <&vip_in>; + }; + }; + }; + };
The Techwell TW9900 is a video decoder supporting multiple input standards, such as PAL, NTSC and SECAM, and outputs a BT.656 video signal. It's designed to be low-power, posesses some features such as a programmable comb-filter, and automatic input standard detection. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- v1->v2: Fix the example not compiling .../devicetree/bindings/media/i2c/tw9900.yaml | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/tw9900.yaml