| Message ID | 20201014101402.18271-12-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > expects the DWC USB3 DT node to have the compatible string with the > "synopsys" vendor prefix. Let's add the corresponding compatible string to > the controller DT schema, but mark it as deprecated seeing the Synopsys, > Inc. is presented with just "snps" vendor prefix. Instead of adding deprecated schema just correct the DTSes to use snps. The "synopsys" is not even in vendor prefixes. Best regards, Krzysztof
On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > > expects the DWC USB3 DT node to have the compatible string with the > > "synopsys" vendor prefix. Let's add the corresponding compatible string to > > the controller DT schema, but mark it as deprecated seeing the Synopsys, > > Inc. is presented with just "snps" vendor prefix. > > Instead of adding deprecated schema just correct the DTSes to use snps. > The "synopsys" is not even in vendor prefixes. Yeah, it's not, but the driver and some dts'es use it this way. I am not sure that the solution suggested by you is much better than mine. So let's hear the Rob'es opinion out in this matter. @Rob, what do you think? -Sergey > > Best regards, > Krzysztof
On Thu, Oct 15, 2020 at 12:35:54AM +0300, Serge Semin wrote: > On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > > > expects the DWC USB3 DT node to have the compatible string with the > > > "synopsys" vendor prefix. Let's add the corresponding compatible string to > > > the controller DT schema, but mark it as deprecated seeing the Synopsys, > > > Inc. is presented with just "snps" vendor prefix. > > > > > Instead of adding deprecated schema just correct the DTSes to use snps. > > The "synopsys" is not even in vendor prefixes. > > Yeah, it's not, but the driver and some dts'es use it this way. I am not sure > that the solution suggested by you is much better than mine. So let's hear the > Rob'es opinion out in this matter. @Rob, what do you think? I think we should fix the dts files given there's only 5. Rob
On Fri, Oct 16, 2020 at 01:53:40PM -0500, Rob Herring wrote: > On Thu, Oct 15, 2020 at 12:35:54AM +0300, Serge Semin wrote: > > On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > > > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > > > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > > > > expects the DWC USB3 DT node to have the compatible string with the > > > > "synopsys" vendor prefix. Let's add the corresponding compatible string to > > > > the controller DT schema, but mark it as deprecated seeing the Synopsys, > > > > Inc. is presented with just "snps" vendor prefix. > > > > > > > > Instead of adding deprecated schema just correct the DTSes to use snps. > > > The "synopsys" is not even in vendor prefixes. > > > > Yeah, it's not, but the driver and some dts'es use it this way. I am not sure > > that the solution suggested by you is much better than mine. So let's hear the > > Rob'es opinion out in this matter. @Rob, what do you think? > > I think we should fix the dts files given there's only 5. Ok. I'll do that. -Sergey > > Rob
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index 12102a84faf6..2f746ac64e71 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -20,7 +20,10 @@ allOf: properties: compatible: contains: - const: snps,dwc3 + oneOf: + - const: snps,dwc3 + - const: synopsys,dwc3 + deprecated: true interrupts: description: |
The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc expects the DWC USB3 DT node to have the compatible string with the "synopsys" vendor prefix. Let's add the corresponding compatible string to the controller DT schema, but mark it as deprecated seeing the Synopsys, Inc. is presented with just "snps" vendor prefix. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Changelog v2: - Drop quotes from around the compat string constant. --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)