| Message ID | 20200825120059.12436-3-rogerq@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | usb: cdns,usb3: Convert DT binding to YALM | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On 20-08-25 15:00:58, Roger Quadros wrote: > Controller version 0x0002450D has USB2 PHY RX sensitivity issues > that needs to be worked around by enabling phyrst-a-enable bit > in PHYRST_CFG register. > > There is no way to distinguish between the controller version > before the device controller is started so we need to add this > DT property. Maybe you should say "There is no way to know controller version at host mode, but this workaround needs for both host and device mode, so we have to add this DT property", the same for the comments of your driver code patch. Peter > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > index 7bc0263accee..e670adc955e1 100644 > --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > @@ -58,6 +58,10 @@ properties: > buffers expressed in KB > $ref: /schemas/types.yaml#/definitions/uint32 > > + cdns,phyrst-a-enable: > + description: Enable resetting of PHY if Rx fail is detected > + type: boolean > + > required: > - compatible > - reg > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >
Peter, On 27/08/2020 14:14, Peter Chen wrote: > On 20-08-25 15:00:58, Roger Quadros wrote: >> Controller version 0x0002450D has USB2 PHY RX sensitivity issues >> that needs to be worked around by enabling phyrst-a-enable bit >> in PHYRST_CFG register. >> >> There is no way to distinguish between the controller version >> before the device controller is started so we need to add this >> DT property. > > Maybe you should say "There is no way to know controller version > at host mode, but this workaround needs for both host and device > mode, so we have to add this DT property", the same for the comments > of your driver code patch. I will reword it to "There is no way to know controller version before device controller is started and the workaround needs to be applied for both host and device modes, so we add this DT property" cheers, -roger > > Peter >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> index 7bc0263accee..e670adc955e1 100644 >> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> @@ -58,6 +58,10 @@ properties: >> buffers expressed in KB >> $ref: /schemas/types.yaml#/definitions/uint32 >> >> + cdns,phyrst-a-enable: >> + description: Enable resetting of PHY if Rx fail is detected >> + type: boolean >> + >> required: >> - compatible >> - reg >> -- >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >> >
On 20-09-02 16:28:31, Roger Quadros wrote: > Peter, > > On 27/08/2020 14:14, Peter Chen wrote: > > On 20-08-25 15:00:58, Roger Quadros wrote: > > > Controller version 0x0002450D has USB2 PHY RX sensitivity issues > > > that needs to be worked around by enabling phyrst-a-enable bit > > > in PHYRST_CFG register. > > > > > > There is no way to distinguish between the controller version > > > before the device controller is started so we need to add this > > > DT property. > > > > Maybe you should say "There is no way to know controller version > > at host mode, but this workaround needs for both host and device > > mode, so we have to add this DT property", the same for the comments > > of your driver code patch. > > I will reword it to > > "There is no way to know controller version before device controller > is started and the workaround needs to be applied for both host and > device modes, so we add this DT property" > After apply it, feel free add: Reviewed-by: Peter Chen <peter.chen@nxp.com> Please apply above for device party commit log as well.
diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml index 7bc0263accee..e670adc955e1 100644 --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml @@ -58,6 +58,10 @@ properties: buffers expressed in KB $ref: /schemas/types.yaml#/definitions/uint32 + cdns,phyrst-a-enable: + description: Enable resetting of PHY if Rx fail is detected + type: boolean + required: - compatible - reg
Controller version 0x0002450D has USB2 PHY RX sensitivity issues that needs to be worked around by enabling phyrst-a-enable bit in PHYRST_CFG register. There is no way to distinguish between the controller version before the device controller is started so we need to add this DT property. Signed-off-by: Roger Quadros <rogerq@ti.com> --- Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++ 1 file changed, 4 insertions(+)