diff mbox series

[2/3] dt-bindings: media: ov772x: Make bus-type mandatory

Message ID 20200817155910.255883-3-jacopo+renesas@jmondi.org
State Superseded, archived
Headers show
Series dt-bindings: media: ov772x: Convert to json-schama | expand

Checks

Context Check Description
robh/checkpatch warning total: 1 errors, 0 warnings, 22 lines checked

Commit Message

Jacopo Mondi Aug. 17, 2020, 3:59 p.m. UTC 
In order to establish required properties based on the selected
bus type, make the 'bus-type' property mandatory.

Binary compatibility with existing DTB is kept as the driver does not
enforce the property to be present, and shall fall-back to default
parallel bus configuration, which was the only supported bus type, if
the property is not specified.
---
 Documentation/devicetree/bindings/media/i2c/ov772x.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Sergei Shtylyov Aug. 17, 2020, 8:14 p.m. UTC | #1 
On 8/17/20 6:59 PM, Jacopo Mondi wrote:

> In order to establish required properties based on the selected
> bus type, make the 'bus-type' property mandatory.
> 
> Binary compatibility with existing DTB is kept as the driver does not
> enforce the property to be present, and shall fall-back to default
> parallel bus configuration, which was the only supported bus type, if
> the property is not specified.

   Signed-off-by?

[...]

MBR, Sergei
Jacopo Mondi Aug. 18, 2020, 12:06 p.m. UTC | #2 
Hi Sergei

On Mon, Aug 17, 2020 at 11:14:04PM +0300, Sergei Shtylyov wrote:
> On 8/17/20 6:59 PM, Jacopo Mondi wrote:
>
> > In order to establish required properties based on the selected
> > bus type, make the 'bus-type' property mandatory.
> >
> > Binary compatibility with existing DTB is kept as the driver does not
> > enforce the property to be present, and shall fall-back to default
> > parallel bus configuration, which was the only supported bus type, if
> > the property is not specified.
>
>    Signed-off-by?
>

Who didn't run checkpatch on this binding path: o/

Will re-send, sorry for the fuss

> [...]
>
> MBR, Sergei
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml
index 2b84fefeb4aa..75dad40f70cc 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml
@@ -47,9 +47,15 @@  properties:
       endpoint:
         type: object
         properties:
+          bus-type:
+            enum: [5, 6]
+
           remote-endpoint:
             description: A phandle to the bus receiver's endpoint node.
 
+        required:
+          - bus-type
+
     additionalProperties: false
 
 required:
@@ -75,6 +81,7 @@  examples:
 
             port {
                 ov772x_0: endpoint {
+                    bus-type = <5>;
                     remote-endpoint = <&vcap1_in0>;
                 };
             };