diff mbox series

[RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties

Message ID 20200629192335.24622-1-festevam@gmail.com
State Not Applicable, archived
Headers show
Series [RFC] dt-bindings: mfd: st,stmfx: Remove extra additionalProperties | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 8 lines checked

Commit Message

Fabio Estevam June 29, 2020, 7:23 p.m. UTC
The following build error is seen with 'make dt_binding_check':

  CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
/home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'

Remove the extra 'additionalProperties' to pass the build.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
 1 file changed, 2 deletions(-)

Comments

Rob Herring June 30, 2020, 2:02 a.m. UTC | #1
On Mon, 29 Jun 2020 16:23:35 -0300, Fabio Estevam wrote:
> The following build error is seen with 'make dt_binding_check':
> 
>   CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
> 
> Remove the extra 'additionalProperties' to pass the build.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Lee Jones June 30, 2020, 7:08 a.m. UTC | #2
On Mon, 29 Jun 2020, Fabio Estevam wrote:

> The following build error is seen with 'make dt_binding_check':
> 
>   CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
> 
> Remove the extra 'additionalProperties' to pass the build.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
>  1 file changed, 2 deletions(-)

Any reason for not sending this to LKML?

> diff --git a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> index 0ce56a0da553..bed22d4abffb 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> @@ -73,8 +73,6 @@ properties:
>            output-high: true
>            output-low: true
>  
> -      additionalProperties: false
> -
>      additionalProperties: false
>  
>      required:
Benjamin GAIGNARD July 1, 2020, 7:21 a.m. UTC | #3
On 6/29/20 9:23 PM, Fabio Estevam wrote:
> The following build error is seen with 'make dt_binding_check':
>
>    CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
>
> Remove the extra 'additionalProperties' to pass the build.
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>   Documentation/devicetree/bindings/mfd/st,stmfx.yaml | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> index 0ce56a0da553..bed22d4abffb 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> @@ -73,8 +73,6 @@ properties:
>             output-high: true
>             output-low: true
>   
> -      additionalProperties: false
> -
>       additionalProperties: false
>   
>       required:
Lee Jones July 1, 2020, 9:36 a.m. UTC | #4
On Wed, 01 Jul 2020, Benjamin GAIGNARD wrote:

> 
> 
> On 6/29/20 9:23 PM, Fabio Estevam wrote:
> > The following build error is seen with 'make dt_binding_check':
> >
> >    CHKDT   Documentation/devicetree/bindings/mfd/st,stmfx.yaml
> > /home/fabio/linux-next/Documentation/devicetree/bindings/mfd/st,stmfx.yaml: properties:pinctrl:patternProperties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
> >
> > Remove the extra 'additionalProperties' to pass the build.
> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>

FYI: The resend of this patch has already been applied.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
index 0ce56a0da553..bed22d4abffb 100644
--- a/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stmfx.yaml
@@ -73,8 +73,6 @@  properties:
           output-high: true
           output-low: true
 
-      additionalProperties: false
-
     additionalProperties: false
 
     required: