diff mbox series

[v2] dt-bindings: ASoC: Convert UniPhier EVEA codec to json-schema

Message ID 20200623114005.791643-1-yamada.masahiro@socionext.com
State Not Applicable
Headers show
Series [v2] dt-bindings: ASoC: Convert UniPhier EVEA codec to json-schema | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 70 lines checked
robh/checkpatch warning total: 0 errors, 1 warnings, 70 lines checked
robh/dt-meta-schema success
robh/dt-meta-schema success

Commit Message

Masahiro Yamada June 23, 2020, 11:40 a.m. UTC
Convert the UniPhier EVEA sound codec binding to DT schema format.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v2:
  - Add schema for subnode 'port'

 .../sound/socionext,uniphier-evea.yaml        | 70 +++++++++++++++++++
 .../bindings/sound/uniphier,evea.txt          | 26 -------
 2 files changed, 70 insertions(+), 26 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/uniphier,evea.txt

Comments

Rob Herring July 14, 2020, 2:22 a.m. UTC | #1
On Tue, 23 Jun 2020 20:40:05 +0900, Masahiro Yamada wrote:
> Convert the UniPhier EVEA sound codec binding to DT schema format.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> Changes in v2:
>   - Add schema for subnode 'port'
> 
>  .../sound/socionext,uniphier-evea.yaml        | 70 +++++++++++++++++++
>  .../bindings/sound/uniphier,evea.txt          | 26 -------
>  2 files changed, 70 insertions(+), 26 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/uniphier,evea.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Masahiro Yamada July 14, 2020, 6:13 a.m. UTC | #2
On Tue, Jul 14, 2020 at 11:22 AM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, 23 Jun 2020 20:40:05 +0900, Masahiro Yamada wrote:
> > Convert the UniPhier EVEA sound codec binding to DT schema format.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > Changes in v2:
> >   - Add schema for subnode 'port'
> >
> >  .../sound/socionext,uniphier-evea.yaml        | 70 +++++++++++++++++++
> >  .../bindings/sound/uniphier,evea.txt          | 26 -------
> >  2 files changed, 70 insertions(+), 26 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/sound/uniphier,evea.txt
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>


What do you mean by Reviewed-by ?
Do you expect this to go to the asoc tree?

I just thought the schema conversion
would go through the dt tree.
Mark Brown July 14, 2020, 9:52 a.m. UTC | #3
On Tue, Jul 14, 2020 at 03:13:26PM +0900, Masahiro Yamada wrote:

> What do you mean by Reviewed-by ?
> Do you expect this to go to the asoc tree?

> I just thought the schema conversion
> would go through the dt tree.

No, bindings changes usually go through the subsystem - if there's any
other work on the binding then it'll usually also involve driver
changes.
Masahiro Yamada July 14, 2020, 11:08 a.m. UTC | #4
On Tue, Jul 14, 2020 at 6:53 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Jul 14, 2020 at 03:13:26PM +0900, Masahiro Yamada wrote:
>
> > What do you mean by Reviewed-by ?
> > Do you expect this to go to the asoc tree?
>
> > I just thought the schema conversion
> > would go through the dt tree.
>
> No, bindings changes usually go through the subsystem - if there's any
> other work on the binding then it'll usually also involve driver
> changes.

OK, then please apply the following two if they look good.

https://lore.kernel.org/patchwork/patch/1261568/
https://lore.kernel.org/patchwork/patch/1261569/

Both got Rob's Reviewed-by.
Mark Brown July 14, 2020, 11:31 a.m. UTC | #5
On Tue, Jul 14, 2020 at 08:08:45PM +0900, Masahiro Yamada wrote:
> On Tue, Jul 14, 2020 at 6:53 PM Mark Brown <broonie@kernel.org> wrote:

> > No, bindings changes usually go through the subsystem - if there's any
> > other work on the binding then it'll usually also involve driver
> > changes.

> OK, then please apply the following two if they look good.

> https://lore.kernel.org/patchwork/patch/1261568/
> https://lore.kernel.org/patchwork/patch/1261569/

> Both got Rob's Reviewed-by.

Only today...
Mark Brown July 14, 2020, 4:39 p.m. UTC | #6
On Tue, 23 Jun 2020 20:40:05 +0900, Masahiro Yamada wrote:
> Convert the UniPhier EVEA sound codec binding to DT schema format.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Convert UniPhier EVEA codec to json-schema
      commit: 08277cd63797d97185284bc3e86d085fb9ff2adc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Rob Herring July 14, 2020, 5:52 p.m. UTC | #7
On Tue, Jul 14, 2020 at 3:53 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Jul 14, 2020 at 03:13:26PM +0900, Masahiro Yamada wrote:
>
> > What do you mean by Reviewed-by ?
> > Do you expect this to go to the asoc tree?

Yes.

> > I just thought the schema conversion
> > would go through the dt tree.
>
> No, bindings changes usually go through the subsystem - if there's any
> other work on the binding then it'll usually also involve driver
> changes.

I have been taking some conversions so I can test them when they are
standalone, there's a low chance of other changes, and the maintainer
tends to be slow to apply and pickup fixes (not Mark).

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml b/Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml
new file mode 100644
index 000000000000..228168f685cf
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml
@@ -0,0 +1,70 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/socionext,uniphier-evea.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: UniPhier EVEA SoC-internal sound codec
+
+maintainers:
+  - <alsa-devel@alsa-project.org>
+
+properties:
+  compatible:
+    const: socionext,uniphier-evea
+
+  reg:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: evea
+      - const: exiv
+
+  clocks:
+    minItems: 2
+    maxItems: 2
+
+  reset-names:
+    items:
+      - const: evea
+      - const: exiv
+      - const: adamv
+
+  resets:
+    minItems: 3
+    maxItems: 3
+
+  "#sound-dai-cells":
+    const: 1
+
+patternProperties:
+  "^port@[0-9]$":
+    type: object
+    properties:
+      endpoint: true
+    required:
+      - endpoint
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - clock-names
+  - clocks
+  - reset-names
+  - resets
+  - "#sound-dai-cells"
+
+examples:
+  - |
+    codec@57900000 {
+        compatible = "socionext,uniphier-evea";
+        reg = <0x57900000 0x1000>;
+        clock-names = "evea", "exiv";
+        clocks = <&sys_clk 41>, <&sys_clk 42>;
+        reset-names = "evea", "exiv", "adamv";
+        resets = <&sys_rst 41>, <&sys_rst 42>, <&adamv_rst 0>;
+        #sound-dai-cells = <1>;
+    };
diff --git a/Documentation/devicetree/bindings/sound/uniphier,evea.txt b/Documentation/devicetree/bindings/sound/uniphier,evea.txt
deleted file mode 100644
index 3f31b235f18b..000000000000
--- a/Documentation/devicetree/bindings/sound/uniphier,evea.txt
+++ /dev/null
@@ -1,26 +0,0 @@ 
-Socionext EVEA - UniPhier SoC internal codec driver
-
-Required properties:
-- compatible      : should be "socionext,uniphier-evea".
-- reg             : offset and length of the register set for the device.
-- clock-names     : should include following entries:
-                    "evea", "exiv"
-- clocks          : a list of phandle, should contain an entry for each
-                    entries in clock-names.
-- reset-names     : should include following entries:
-                    "evea", "exiv", "adamv"
-- resets          : a list of phandle, should contain reset entries of
-                    reset-names.
-- #sound-dai-cells: should be 1.
-
-Example:
-
-	codec {
-		compatible = "socionext,uniphier-evea";
-		reg = <0x57900000 0x1000>;
-		clock-names = "evea", "exiv";
-		clocks = <&sys_clk 41>, <&sys_clk 42>;
-		reset-names = "evea", "exiv", "adamv";
-		resets = <&sys_rst 41>, <&sys_rst 42>, <&adamv_rst 0>;
-		#sound-dai-cells = <1>;
-	};