| Message ID | 20200604034655.15930-2-f.fainelli@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | spi: bcm2835: Enable shared interrupt support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Jun 03, 2020 at 08:46:53PM -0700, Florian Fainelli wrote: > The BCM2711 and BCM7211 chips use the BCM2835 SPI controller, but there > are severl instances of those in the system and they all share the same ^^^^^^ Nit: "several" And apparently they do not *all* share the interrupt, but only 4 controllers (out of 5, not counting the two bcm2835aux ones) do so. Thanks, Lukas
diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt index f11f295c8450..3d55dd64b1be 100644 --- a/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt @@ -5,7 +5,8 @@ SPI0, and the other known as the "Universal SPI Master"; part of the auxiliary block. This binding applies to the SPI0 controller. Required properties: -- compatible: Should be "brcm,bcm2835-spi". +- compatible: Should be one of "brcm,bcm2835-spi" for BCM2835/2836/2837 or + "brcm,bcm2711-spi" for BCM2711 or "brcm,bcm7211-spi" for BCM7211. - reg: Should contain register location and length. - interrupts: Should contain interrupt. - clocks: The clock feeding the SPI controller.
The BCM2711 and BCM7211 chips use the BCM2835 SPI controller, but there are severl instances of those in the system and they all share the same interrupt line. Document specific compatible strings such that the driver can take appropriate actions. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)