| Message ID | 20200328184958.16134-1-festevam@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: clock: dac: syscon-icst: Remove unneeded unit name | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 8 lines checked" |
Quoting Fabio Estevam (2020-03-28 11:49:58) > The following warnings are seen with 'make dt_binding_check': > > Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_vs_reg): /example-0/clock@00: node has a unit name, but no reg or ranges property > Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_format): /example-0/clock@00: unit name should not have leading 0s > > Fix them by removing the unneeded clock unit name. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- Rob were you going to pick this up? Doesn't look like a critical warning to fix in v5.7 final right now. > Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml > index de9a465096db..444aeea27db8 100644 > --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml > +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml > @@ -91,7 +91,7 @@ required: > > examples: > - | > - vco1: clock@00 { > + vco1: clock { > compatible = "arm,impd1-vco1"; > #clock-cells = <0>; > lock-offset = <0x08>;
On Sat, Mar 28, 2020 at 7:50 PM Fabio Estevam <festevam@gmail.com> wrote: > The following warnings are seen with 'make dt_binding_check': > > Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_vs_reg): /example-0/clock@00: node has a unit name, but no reg or ranges property > Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_format): /example-0/clock@00: unit name should not have leading 0s > > Fix them by removing the unneeded clock unit name. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml index de9a465096db..444aeea27db8 100644 --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml @@ -91,7 +91,7 @@ required: examples: - | - vco1: clock@00 { + vco1: clock { compatible = "arm,impd1-vco1"; #clock-cells = <0>; lock-offset = <0x08>;
The following warnings are seen with 'make dt_binding_check': Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_vs_reg): /example-0/clock@00: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_format): /example-0/clock@00: unit name should not have leading 0s Fix them by removing the unneeded clock unit name. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)