| Message ID | 20200319053902.3415984-3-bjorn.andersson@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | clk: qcom: gdsc: Handle supply regulators | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 19 lines checked" |
| robh/dt-meta-schema | success |
Quoting Bjorn Andersson (2020-03-18 22:39:00) > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > index 85518494ce43..65d9aa790581 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > @@ -67,6 +67,10 @@ properties: > description: > Protected clock specifier list as per common clock binding > > + vdd_gfx-supply: Why not vdd-gfx-supply? What's with the underscore? > + description: > + Regulator supply for the GPU_GX GDSC > + > required: > - compatible > - reg
On Fri 20 Mar 16:31 PDT 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-03-18 22:39:00) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > index 85518494ce43..65d9aa790581 100644 > > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > @@ -67,6 +67,10 @@ properties: > > description: > > Protected clock specifier list as per common clock binding > > > > + vdd_gfx-supply: > > Why not vdd-gfx-supply? What's with the underscore? > The pad is named "VDD_GFX" in the datasheet and the schematics. I see that we've started y/_/-/ in some of the newly added bindings, would you prefer I follow this? Regards, Bjorn > > + description: > > + Regulator supply for the GPU_GX GDSC > > + > > required: > > - compatible > > - reg
Quoting Bjorn Andersson (2020-03-20 22:16:12) > On Fri 20 Mar 16:31 PDT 2020, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2020-03-18 22:39:00) > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > > index 85518494ce43..65d9aa790581 100644 > > > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > > @@ -67,6 +67,10 @@ properties: > > > description: > > > Protected clock specifier list as per common clock binding > > > > > > + vdd_gfx-supply: > > > > Why not vdd-gfx-supply? What's with the underscore? > > > > The pad is named "VDD_GFX" in the datasheet and the schematics. I see > that we've started y/_/-/ in some of the newly added bindings, would you > prefer I follow this? If the datasheet has this then I guess it's fine. I'll wait for Rob to ack.
On Sat, Mar 21, 2020 at 11:43:12AM -0700, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-03-20 22:16:12) > > On Fri 20 Mar 16:31 PDT 2020, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2020-03-18 22:39:00) > > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > > > index 85518494ce43..65d9aa790581 100644 > > > > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > > > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > > > @@ -67,6 +67,10 @@ properties: > > > > description: > > > > Protected clock specifier list as per common clock binding > > > > > > > > + vdd_gfx-supply: > > > > > > Why not vdd-gfx-supply? What's with the underscore? > > > > > > > The pad is named "VDD_GFX" in the datasheet and the schematics. I see > > that we've started y/_/-/ in some of the newly added bindings, would you > > prefer I follow this? > > If the datasheet has this then I guess it's fine. I'll wait for Rob to > ack. vddgfx or vdd-gfx. Rob
diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml index 85518494ce43..65d9aa790581 100644 --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml @@ -67,6 +67,10 @@ properties: description: Protected clock specifier list as per common clock binding + vdd_gfx-supply: + description: + Regulator supply for the GPU_GX GDSC + required: - compatible - reg diff --git a/drivers/clk/qcom/mmcc-msm8996.c b/drivers/clk/qcom/mmcc-msm8996.c index 6c7592ddf8bb..fd43a35db13b 100644 --- a/drivers/clk/qcom/mmcc-msm8996.c +++ b/drivers/clk/qcom/mmcc-msm8996.c @@ -3064,7 +3064,9 @@ static struct gdsc gpu_gx_gdsc = { .name = "gpu_gx", }, .pwrsts = PWRSTS_OFF_ON, + .parent = &gpu_gdsc.pd, .flags = CLAMP_IO, + .supply = "vdd_gfx", }; static struct clk_regmap *mmcc_msm8996_clocks[] = {
The GPU_GX GDSC depends on both GPU GDSC being enabled and that the VDD_GX rail is powered, so update the description of the node to cover these requirements. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- Documentation/devicetree/bindings/clock/qcom,mmcc.yaml | 4 ++++ drivers/clk/qcom/mmcc-msm8996.c | 2 ++ 2 files changed, 6 insertions(+)