Message ID | 20200306132018.C268A8030792@mail.baikalelectronics.ru |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | i2c: designeware: Add Baikal-T1 SoC DW I2C specifics support | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success | |
robh/checkpatch | success |
On Fri, 6 Mar 2020 16:19:52 +0300, <Sergey.Semin@baikalelectronics.ru> wrote: > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Just add the "be,bt1-i2c" compatible string to the bindings. The rest of > the DW APB I2C properties can be freely used to describe the Baikal-T1 > I2C controller dts-node. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Paul Burton <paulburton@kernel.org> > Cc: Ralf Baechle <ralf@linux-mips.org> > --- > Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, Mar 12, 2020 at 04:43:40PM -0500, Rob Herring wrote: > On Fri, 6 Mar 2020 16:19:52 +0300, <Sergey.Semin@baikalelectronics.ru> wrote: > > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > Just add the "be,bt1-i2c" compatible string to the bindings. The rest of > > the DW APB I2C properties can be freely used to describe the Baikal-T1 > > I2C controller dts-node. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > > Cc: Paul Burton <paulburton@kernel.org> > > Cc: Ralf Baechle <ralf@linux-mips.org> > > --- > > Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > Acked-by: Rob Herring <robh@kernel.org> Seeing you and us having doubts regarding our vendor prefix and the corresponding patch still hasn't been accepted, in the next patchset release perhaps I will have to change the compatible string of this driver. It depends on a result of the discussion: https://lkml.org/lkml/2020/3/13/239 Rob, could you get back to it, so we could come up with a solution? Currently most of our team members are leaning towards "baikal,t1" = "vendor,chip" prefixes to all the SoC specific devices. So the Baikal-T1 I2C compatible string would be renamed to "baikal,t1-i2c". What do you think? Regards, -Sergey
diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml index 3f348f1ce172..eab2c9293665 100644 --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml @@ -34,6 +34,8 @@ properties: items: - const: mscc,ocelot-i2c - const: snps,designware-i2c + - description: Baikal-T1 SoCs I2C controller. + const: be,bt1-i2c reg: items: