| Message ID | 20191223100321.7364-1-geert@linux-m68k.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | of: mdio: Add missing inline to of_mdiobus_child_is_phy() dummy | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 8 lines checked" |
On Mon, Dec 23, 2019 at 11:03:21AM +0100, Geert Uytterhoeven wrote: > If CONFIG_OF_MDIO=n: > > drivers/net/phy/mdio_bus.c:23: > include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function] > static bool of_mdiobus_child_is_phy(struct device_node *child) > ^~~~~~~~~~~~~~~~~~~~~~~ > > Fix this by adding the missing "inline" keyword. > > Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Mon, Dec 23, 2019 at 11:03:21AM +0100, Geert Uytterhoeven wrote: > If CONFIG_OF_MDIO=n: > > drivers/net/phy/mdio_bus.c:23: > include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function] > static bool of_mdiobus_child_is_phy(struct device_node *child) > ^~~~~~~~~~~~~~~~~~~~~~~ > > Fix this by adding the missing "inline" keyword. > > Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > include/linux/of_mdio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h > index 79bc82e30c02333d..491a2b7e77c1e906 100644 > --- a/include/linux/of_mdio.h > +++ b/include/linux/of_mdio.h > @@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev, > } > > #else /* CONFIG_OF_MDIO */ > -static bool of_mdiobus_child_is_phy(struct device_node *child) > +static inline bool of_mdiobus_child_is_phy(struct device_node *child) > { > return false; > } > -- I'm seeing it too with rc3. Acked-by: Borislav Petkov <bp@suse.de> Thx.
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Mon, 23 Dec 2019 11:03:21 +0100 > If CONFIG_OF_MDIO=n: > > drivers/net/phy/mdio_bus.c:23: > include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function] > static bool of_mdiobus_child_is_phy(struct device_node *child) > ^~~~~~~~~~~~~~~~~~~~~~~ > > Fix this by adding the missing "inline" keyword. > > Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied, thank you.
diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h index 79bc82e30c02333d..491a2b7e77c1e906 100644 --- a/include/linux/of_mdio.h +++ b/include/linux/of_mdio.h @@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev, } #else /* CONFIG_OF_MDIO */ -static bool of_mdiobus_child_is_phy(struct device_node *child) +static inline bool of_mdiobus_child_is_phy(struct device_node *child) { return false; }
If CONFIG_OF_MDIO=n: drivers/net/phy/mdio_bus.c:23: include/linux/of_mdio.h:58:13: warning: ‘of_mdiobus_child_is_phy’ defined but not used [-Wunused-function] static bool of_mdiobus_child_is_phy(struct device_node *child) ^~~~~~~~~~~~~~~~~~~~~~~ Fix this by adding the missing "inline" keyword. Fixes: 0aa4d016c043d16a ("of: mdio: export of_mdiobus_child_is_phy") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- include/linux/of_mdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)