| Message ID | 20191008115143.14149-2-andrew@aj.id.au |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, 8 Oct 2019 at 11:50, Andrew Jeffery <andrew@aj.id.au> wrote: > > The AST2600 contains an FTGMAC100-compatible MAC, although it no-longer > contains an MDIO controller. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Acked-by: Joel Stanley <joel@jms.id.au> > --- > Documentation/devicetree/bindings/net/ftgmac100.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt > index 72e7aaf7242e..04cc0191b7dd 100644 > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt > @@ -9,6 +9,7 @@ Required properties: > > - "aspeed,ast2400-mac" > - "aspeed,ast2500-mac" > + - "aspeed,ast2600-mac" > > - reg: Address and length of the register set for the device > - interrupts: Should contain ethernet controller interrupt > -- > 2.20.1 >
On Tue, 2019-10-08 at 22:21 +1030, Andrew Jeffery wrote: > The AST2600 contains an FTGMAC100-compatible MAC, although it no- > longer > contains an MDIO controller. How do you talk to the PHY then ? Cheers, Ben. > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > Documentation/devicetree/bindings/net/ftgmac100.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt > b/Documentation/devicetree/bindings/net/ftgmac100.txt > index 72e7aaf7242e..04cc0191b7dd 100644 > --- a/Documentation/devicetree/bindings/net/ftgmac100.txt > +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt > @@ -9,6 +9,7 @@ Required properties: > > - "aspeed,ast2400-mac" > - "aspeed,ast2500-mac" > + - "aspeed,ast2600-mac" > > - reg: Address and length of the register set for the device > - interrupts: Should contain ethernet controller interrupt
On Wed, 9 Oct 2019, at 15:08, Benjamin Herrenschmidt wrote: > On Tue, 2019-10-08 at 22:21 +1030, Andrew Jeffery wrote: > > The AST2600 contains an FTGMAC100-compatible MAC, although it no- > > longer > > contains an MDIO controller. > > How do you talk to the PHY then ? There are still MDIO controllers, they're just not in the MAC IP on the 2600. Andrew
On Wed, 9 Oct 2019, at 15:19, Andrew Jeffery wrote: > > > On Wed, 9 Oct 2019, at 15:08, Benjamin Herrenschmidt wrote: > > On Tue, 2019-10-08 at 22:21 +1030, Andrew Jeffery wrote: > > > The AST2600 contains an FTGMAC100-compatible MAC, although it no- > > > longer > > > contains an MDIO controller. > > > > How do you talk to the PHY then ? > > There are still MDIO controllers, they're just not in the MAC IP on the 2600. Sorry, on reflection that description is a little ambiguous in its use of 'it'. I'll fix that in v2 as well. Does this read better? "The AST2600 contains an FTGMAC100-compatible MAC, although the MAC no-longer contains an MDIO controller." Andrew
On Wed, 2019-10-09 at 15:25 +1030, Andrew Jeffery wrote: > > On Wed, 9 Oct 2019, at 15:19, Andrew Jeffery wrote: > > > > > > On Wed, 9 Oct 2019, at 15:08, Benjamin Herrenschmidt wrote: > > > On Tue, 2019-10-08 at 22:21 +1030, Andrew Jeffery wrote: > > > > The AST2600 contains an FTGMAC100-compatible MAC, although it > > > > no- > > > > longer > > > > contains an MDIO controller. > > > > > > How do you talk to the PHY then ? > > > > There are still MDIO controllers, they're just not in the MAC IP on > > the 2600. > > Sorry, on reflection that description is a little ambiguous in its > use of 'it'. I'll > fix that in v2 as well. Does this read better? > > "The AST2600 contains an FTGMAC100-compatible MAC, although the MAC > no-longer contains an MDIO controller." That's fine. Or to be pendantic, say the MDIO controller has been moved of the MAC unit into its own separate block or something along those lines so people like me don't get anxious :) Cheers, Ben.
diff --git a/Documentation/devicetree/bindings/net/ftgmac100.txt b/Documentation/devicetree/bindings/net/ftgmac100.txt index 72e7aaf7242e..04cc0191b7dd 100644 --- a/Documentation/devicetree/bindings/net/ftgmac100.txt +++ b/Documentation/devicetree/bindings/net/ftgmac100.txt @@ -9,6 +9,7 @@ Required properties: - "aspeed,ast2400-mac" - "aspeed,ast2500-mac" + - "aspeed,ast2600-mac" - reg: Address and length of the register set for the device - interrupts: Should contain ethernet controller interrupt
The AST2600 contains an FTGMAC100-compatible MAC, although it no-longer contains an MDIO controller. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- Documentation/devicetree/bindings/net/ftgmac100.txt | 1 + 1 file changed, 1 insertion(+)