| Message ID | 20190910062103.39641-4-philippe.schenker@toradex.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add new binding regulator-fixed-clock to regulator-fixed | expand |
On Tue, Sep 10, 2019 at 7:21 AM Philippe Schenker <philippe.schenker@toradex.com> wrote: > > This adds the documentation to the compatible regulator-fixed-clock. > This binding is a special binding of regulator-fixed and adds the > ability to add a clock to regulator-fixed, so the regulator can be > enabled and disabled with that clock. If the special compatible > regulator-fixed-clock is used it is mandatory to supply a clock. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > --- > > Changes in v2: > - Change select: to if: > - Change items: to enum: > - Defined how many clocks should be given > > .../bindings/regulator/fixed-regulator.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, Sep 10, 2019 at 1:21 AM Philippe Schenker <philippe.schenker@toradex.com> wrote: > > This adds the documentation to the compatible regulator-fixed-clock. > This binding is a special binding of regulator-fixed and adds the > ability to add a clock to regulator-fixed, so the regulator can be > enabled and disabled with that clock. If the special compatible > regulator-fixed-clock is used it is mandatory to supply a clock. > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > --- > > Changes in v2: > - Change select: to if: > - Change items: to enum: > - Defined how many clocks should be given > > .../bindings/regulator/fixed-regulator.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml > index a650b457085d..a78150c47aa2 100644 > --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml > @@ -19,9 +19,19 @@ description: > allOf: > - $ref: "regulator.yaml#" > > +if: > + properties: > + compatible: > + contains: > + const: regulator-fixed-clock > + required: > + - clocks > + > properties: > compatible: > - const: regulator-fixed > + enum: > + - const: regulator-fixed > + - const: regulator-fixed-clock 'make dt_binding_check' is failing. You need to drop 'const: '. Please send a patch to fix this. Rob
On Tue, 2019-09-17 at 15:13 -0500, Rob Herring wrote: > On Tue, Sep 10, 2019 at 1:21 AM Philippe Schenker > <philippe.schenker@toradex.com> wrote: > > This adds the documentation to the compatible regulator-fixed-clock. > > This binding is a special binding of regulator-fixed and adds the > > ability to add a clock to regulator-fixed, so the regulator can be > > enabled and disabled with that clock. If the special compatible > > regulator-fixed-clock is used it is mandatory to supply a clock. > > > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > > > --- > > > > Changes in v2: > > - Change select: to if: > > - Change items: to enum: > > - Defined how many clocks should be given > > > > .../bindings/regulator/fixed-regulator.yaml | 19 > > ++++++++++++++++++- > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/regulator/fixed- > > regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed- > > regulator.yaml > > index a650b457085d..a78150c47aa2 100644 > > --- a/Documentation/devicetree/bindings/regulator/fixed- > > regulator.yaml > > +++ b/Documentation/devicetree/bindings/regulator/fixed- > > regulator.yaml > > @@ -19,9 +19,19 @@ description: > > allOf: > > - $ref: "regulator.yaml#" > > > > +if: > > + properties: > > + compatible: > > + contains: > > + const: regulator-fixed-clock > > + required: > > + - clocks > > + > > properties: > > compatible: > > - const: regulator-fixed > > + enum: > > + - const: regulator-fixed > > + - const: regulator-fixed-clock > > 'make dt_binding_check' is failing. You need to drop 'const: '. Please > send a patch to fix this. > > Rob Hi Rob, Thanks for pointing this out, I wasn't aware of that and of 'make dt_binding_check'. I was searching for it, but not finding that one, thanks for mentioning it. I will immediately patch that and send it right away. Philippe
diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml index a650b457085d..a78150c47aa2 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml @@ -19,9 +19,19 @@ description: allOf: - $ref: "regulator.yaml#" +if: + properties: + compatible: + contains: + const: regulator-fixed-clock + required: + - clocks + properties: compatible: - const: regulator-fixed + enum: + - const: regulator-fixed + - const: regulator-fixed-clock regulator-name: true @@ -29,6 +39,13 @@ properties: description: gpio to use for enable control maxItems: 1 + clocks: + description: + clock to use for enable control. This binding is only available if + the compatible is chosen to regulator-fixed-clock. The clock binding + is mandatory if compatible is chosen to regulator-fixed-clock. + maxItems: 1 + startup-delay-us: description: startup time in microseconds $ref: /schemas/types.yaml#/definitions/uint32
This adds the documentation to the compatible regulator-fixed-clock. This binding is a special binding of regulator-fixed and adds the ability to add a clock to regulator-fixed, so the regulator can be enabled and disabled with that clock. If the special compatible regulator-fixed-clock is used it is mandatory to supply a clock. Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> --- Changes in v2: - Change select: to if: - Change items: to enum: - Defined how many clocks should be given .../bindings/regulator/fixed-regulator.yaml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)