| Message ID | 20190809121918.25047-2-sr@denx.de |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, Aug 9, 2019 at 6:19 AM Stefan Roese <sr@denx.de> wrote: > > This patch adds the vendor prefix for gardena and a short description > including the compatible string for the "GARDENA smart Gateway" based > on the MT7688 SoC. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Paul Burton <paul.burton@mips.com> > Cc: Rob Herring <robh@kernel.org> > Cc: devicetree@vger.kernel.org > --- > v3: > - New patch > > .../devicetree/bindings/mips/ralink/gardena.txt | 9 +++++++++ > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 2 files changed, 11 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mips/ralink/gardena.txt Please add to ralink.txt rather than a new file. Ideally, that would be converted to DT schema first, but given this is v3 already I won't require that. A binding file per board vendor doesn't scale well and will be a lot of duplication for schemas. > diff --git a/Documentation/devicetree/bindings/mips/ralink/gardena.txt b/Documentation/devicetree/bindings/mips/ralink/gardena.txt > new file mode 100644 > index 000000000000..4022fe61a8ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/mips/ralink/gardena.txt > @@ -0,0 +1,9 @@ > +GARDENA smart Gateway (MT7688) > + > +This board is based on the MediaTek MT7688 and equipped with 128 MiB > +of DDR and 8 MiB of flash (SPI NOR) and additional 128MiB SPI NAND > +storage. > + > +------------------------------ > +Required root node properties: > +- compatible = "gardena,smartGatewayMT7688"; You need an SoC compatible for MT7688 which isn't documented either. Rob
diff --git a/Documentation/devicetree/bindings/mips/ralink/gardena.txt b/Documentation/devicetree/bindings/mips/ralink/gardena.txt new file mode 100644 index 000000000000..4022fe61a8ee --- /dev/null +++ b/Documentation/devicetree/bindings/mips/ralink/gardena.txt @@ -0,0 +1,9 @@ +GARDENA smart Gateway (MT7688) + +This board is based on the MediaTek MT7688 and equipped with 128 MiB +of DDR and 8 MiB of flash (SPI NOR) and additional 128MiB SPI NAND +storage. + +------------------------------ +Required root node properties: +- compatible = "gardena,smartGatewayMT7688"; diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 6992bbbbffab..73166adfd4ad 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -337,6 +337,8 @@ patternProperties: description: Freescale Semiconductor "^fujitsu,.*": description: Fujitsu Ltd. + "^gardena,.*": + description: GARDENA GmbH "^gateworks,.*": description: Gateworks Corporation "^gcw,.*":
This patch adds the vendor prefix for gardena and a short description including the compatible string for the "GARDENA smart Gateway" based on the MT7688 SoC. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Paul Burton <paul.burton@mips.com> Cc: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org --- v3: - New patch .../devicetree/bindings/mips/ralink/gardena.txt | 9 +++++++++ Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 2 files changed, 11 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/ralink/gardena.txt