| Message ID | 20190807020559.74458-1-saravanak@google.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | of/platform: Fix device_links_supplier_sync_state_resume() warning | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
diff --git a/drivers/of/platform.c b/drivers/of/platform.c index a2a4e4b79d43..e5f7e40df439 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -723,7 +723,8 @@ arch_initcall_sync(of_platform_default_populate_init); static int __init of_platform_sync_state_init(void) { - device_links_supplier_sync_state_resume(); + if (of_have_populated_dt()) + device_links_supplier_sync_state_resume(); return 0; } late_initcall_sync(of_platform_sync_state_init);
In platforms/devices which have CONFIG_OF turned on but don't have a populated DT, the calls to device_links_supplier_sync_state_pause() and device_links_supplier_sync_state_resume() can get mismatched. This will cause a warning during boot. Fix the warning by making sure the calls are matched even in that case. Reported-by: Qian Cai <cai@lca.pw> Signed-off-by: Saravana Kannan <saravanak@google.com> --- drivers/of/platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)