| Message ID | 20190806192654.138605-1-saravanak@google.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] of/platform: Fix fn definitons for of_link_is_valid() and of_link_property() | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Aug 6, 2019 at 1:27 PM Saravana Kannan <saravanak@google.com> wrote: > > of_link_is_valid() can be static since it's not used anywhere else. > > of_link_property() return type should have been int instead of bool. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/of/platform.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 21838226d68a..f68de5c4aeff 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -506,7 +506,7 @@ int of_platform_default_populate(struct device_node *root, } EXPORT_SYMBOL_GPL(of_platform_default_populate); -bool of_link_is_valid(struct device_node *con, struct device_node *sup) +static bool of_link_is_valid(struct device_node *con, struct device_node *sup) { of_node_get(sup); /* @@ -625,7 +625,7 @@ static const struct supplier_bindings bindings[] = { { }, }; -static bool of_link_property(struct device *dev, struct device_node *con_np, +static int of_link_property(struct device *dev, struct device_node *con_np, const char *prop) { struct device_node *phandle;
of_link_is_valid() can be static since it's not used anywhere else. of_link_property() return type should have been int instead of bool. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Saravana Kannan <saravanak@google.com> --- drivers/of/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)