| Message ID | 20190623164206.7467-3-tiny.windzz@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | add thermal driver for h6 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
Hi, On Sun, Jun 23, 2019 at 12:41:57PM -0400, Yangtao Li wrote: > This patch adds binding document for allwinner h6 thermal controller. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > .../bindings/thermal/sun8i-thermal.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > new file mode 100644 > index 000000000000..2c5acc61ed03 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings > + > +maintainers: > + - Yangtao Li <tiny.windzz@gmail.com> > + > +description: |- > + This describes the device tree binding for the Allwinner thermal > + controller which measures the on-SoC temperatures. > + > +properties: > + compatible: > + enum: > + - allwinner,sun50i-h6-ths > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 1 You can drop the minItems there > + nvmem-cells: > + items: > + - description: ths calibrate data > + > + nvmem-cell-names: > + items: > + - const: calib And for these two, you don't need the items either, it can be directly const: calib (and the description for the first one). > +required: > + - compatible > + - reg > + - reset > + - clocks > + - clock-names > + - interrupts > + - '#thermal-sensor-cells' > + > +examples: > + - | > + ths: ths@5070400 { > + compatible = "allwinner,sun50i-h6-ths"; > + reg = <0x05070400 0x100>; > + clocks = <&ccu CLK_BUS_THS>; > + clock-names = "bus"; > + resets = <&ccu RST_BUS_THS>; > + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; Did you try to run make dtbs_check? That one will probably not compile. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml new file mode 100644 index 000000000000..2c5acc61ed03 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml @@ -0,0 +1,71 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner SUN8I Thermal Controller Device Tree Bindings + +maintainers: + - Yangtao Li <tiny.windzz@gmail.com> + +description: |- + This describes the device tree binding for the Allwinner thermal + controller which measures the on-SoC temperatures. + +properties: + compatible: + enum: + - allwinner,sun50i-h6-ths + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + resets: + maxItems: 1 + + clocks: + minItems: 1 + maxItems: 1 + + clock-names: + const: bus + + '#thermal-sensor-cells': + const: 1 + + nvmem-cells: + items: + - description: ths calibrate data + + nvmem-cell-names: + items: + - const: calib + +required: + - compatible + - reg + - reset + - clocks + - clock-names + - interrupts + - '#thermal-sensor-cells' + +examples: + - | + ths: ths@5070400 { + compatible = "allwinner,sun50i-h6-ths"; + reg = <0x05070400 0x100>; + clocks = <&ccu CLK_BUS_THS>; + clock-names = "bus"; + resets = <&ccu RST_BUS_THS>; + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; + nvmem-cells = <&tsen_calib>; + nvmem-cell-names = "calib"; + #thermal-sensor-cells = <1>; + }; + +...
This patch adds binding document for allwinner h6 thermal controller. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- .../bindings/thermal/sun8i-thermal.yaml | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml