| Message ID | 20190525134140.6220-1-maxime.ripard@bootlin.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/5] dt-bindings: vendor: Escape single quote | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Sat, 25 May 2019 15:41:36 +0200, Maxime Ripard wrote: > Single quotes need to be escaped in YAML, make sure it's the case. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. Rob
On Sat, May 25, 2019 at 03:41:40PM +0200, Maxime Ripard wrote: > For some reason, the RTC vendor is reported to be phg, while the part is > actually made by the much more known NXP. Fix that. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Applied. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Sat, May 25, 2019 at 7:41 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > Single quotes need to be escaped in YAML, make sure it's the case. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 19cc3240a445..ec53162e900d 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -672,7 +672,7 @@ patternProperties: > "^plantower,.*": > description: Plantower Co., Ltd > "^plathome,.*": > - description: Plat'Home Co., Ltd. > + description: Plat\'Home Co., Ltd. Actually, I think this isn't necessary. Where was this causing a problem? Only in single quoted strings do you have to escape a single quote and it is done with 2 single quotes rather than a backslash. However, to maintain a json compatible subset of yaml, maybe we do need it. Rob
Hi, On Tue, Jun 11, 2019 at 03:18:51PM -0600, Rob Herring wrote: > On Sat, May 25, 2019 at 7:41 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > Single quotes need to be escaped in YAML, make sure it's the case. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > --- > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 19cc3240a445..ec53162e900d 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -672,7 +672,7 @@ patternProperties: > > "^plantower,.*": > > description: Plantower Co., Ltd > > "^plathome,.*": > > - description: Plat'Home Co., Ltd. > > + description: Plat\'Home Co., Ltd. > > Actually, I think this isn't necessary. Where was this causing a > problem? Only in single quoted strings do you have to escape a single > quote and it is done with 2 single quotes rather than a backslash. I guess I misread the YAML spec though... Sorry. > However, to maintain a json compatible subset of yaml, maybe we do > need it. If you don't want it anymore, I guess we can drop or revert it. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 19cc3240a445..ec53162e900d 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -672,7 +672,7 @@ patternProperties: "^plantower,.*": description: Plantower Co., Ltd "^plathome,.*": - description: Plat'Home Co., Ltd. + description: Plat\'Home Co., Ltd. "^plda,.*": description: PLDA "^plx,.*":
Single quotes need to be escaped in YAML, make sure it's the case. Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)