| Message ID | 20190322195924.70448-1-dianders@chromium.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Fri, Mar 22, 2019 at 2:59 PM Douglas Anderson <dianders@chromium.org> wrote: > > As far as I can tell/remember rev10 was originally created to support > making a SKU of jerry that had a different LCD. rev11-rev15 were > added to give some wiggle room for future builds. Downstream has a > separate device tree for rev10-rev15 (compared to rev3-rev7) with the > expectation that differences relating to the LCD would be accounted > for there but nothing was ever added to the rev10-rev15 making it > identical to the rev3-rev7 one. > > It's likely nothing actually shipped with rev10-rev15 but they are > listed in the downstream kernel's device tree and it seems like it > should add a little safety if we match them here just in case > something actually shipped with one of these revisions and that device > will break if we don't claim support. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org>
Am Freitag, 22. März 2019, 20:59:23 CET schrieb Douglas Anderson: > As far as I can tell/remember rev10 was originally created to support > making a SKU of jerry that had a different LCD. rev11-rev15 were > added to give some wiggle room for future builds. Downstream has a > separate device tree for rev10-rev15 (compared to rev3-rev7) with the > expectation that differences relating to the LCD would be accounted > for there but nothing was ever added to the rev10-rev15 making it > identical to the rev3-rev7 one. > > It's likely nothing actually shipped with rev10-rev15 but they are > listed in the downstream kernel's device tree and it seems like it > should add a little safety if we match them here just in case > something actually shipped with one of these revisions and that device > will break if we don't claim support. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> applied both for 5.2 Thanks Heiko
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 0161b4a66586..864ee1fddcb0 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -160,6 +160,12 @@ properties: - description: Google Jerry (Hisense Chromebook C11 and more) items: + - const: google,veyron-jerry-rev15 + - const: google,veyron-jerry-rev14 + - const: google,veyron-jerry-rev13 + - const: google,veyron-jerry-rev12 + - const: google,veyron-jerry-rev11 + - const: google,veyron-jerry-rev10 - const: google,veyron-jerry-rev7 - const: google,veyron-jerry-rev6 - const: google,veyron-jerry-rev5
As far as I can tell/remember rev10 was originally created to support making a SKU of jerry that had a different LCD. rev11-rev15 were added to give some wiggle room for future builds. Downstream has a separate device tree for rev10-rev15 (compared to rev3-rev7) with the expectation that differences relating to the LCD would be accounted for there but nothing was ever added to the rev10-rev15 making it identical to the rev3-rev7 one. It's likely nothing actually shipped with rev10-rev15 but they are listed in the downstream kernel's device tree and it seems like it should add a little safety if we match them here just in case something actually shipped with one of these revisions and that device will break if we don't claim support. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ 1 file changed, 6 insertions(+)