| Message ID | 20180920014705.15144-1-bjorn.andersson@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | pinctrl: qcom: spmi-gpio: Add pms405 gpio support | expand |
On Wed 19 Sep 18:47 PDT 2018, Bjorn Andersson wrote: > From: Vinod Koul <vkoul@kernel.org> > > Update the binding and driver for pms405-gpios > > Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++ > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > index ffd4345415f3..ab4000eab07d 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > @@ -19,6 +19,7 @@ PMIC's from Qualcomm. > "qcom,pm8998-gpio" > "qcom,pma8084-gpio" > "qcom,pmi8994-gpio" > + "qcom,pms405-gpio" > > And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio" > if the device is on an spmi bus or an ssbi bus respectively > @@ -91,6 +92,7 @@ to specify in a pin configuration subnode: > gpio1-gpio26 for pm8998 > gpio1-gpio22 for pma8084 > gpio1-gpio10 for pmi8994 > + gpio1-gpio11 for pms405 > > - function: > Usage: required > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index a29efbe08f48..b54891998caa 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = { > { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */ > { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */ > { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */ > + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */ > { .compatible = "qcom,spmi-gpio" }, /* Generic */ > { }, > }; > -- > 2.18.0 >
Quoting Bjorn Andersson (2018-09-19 18:47:05) > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index a29efbe08f48..b54891998caa 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = { > { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */ > { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */ > { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */ > + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */ I thought we didn't update the C driver, because there isn't anything to do here. Just make binding updates and it's all fine. > { .compatible = "qcom,spmi-gpio" }, /* Generic */ > { }, > };
On Thu 20 Sep 08:30 PDT 2018, Stephen Boyd wrote: > Quoting Bjorn Andersson (2018-09-19 18:47:05) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > index a29efbe08f48..b54891998caa 100644 > > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = { > > { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */ > > { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */ > > { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */ > > + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */ > > I thought we didn't update the C driver, because there isn't anything to > do here. Just make binding updates and it's all fine. > Right, forgot that we just use the fallback. Thanks, Bjorn > > { .compatible = "qcom,spmi-gpio" }, /* Generic */ > > { }, > > };
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt index ffd4345415f3..ab4000eab07d 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt @@ -19,6 +19,7 @@ PMIC's from Qualcomm. "qcom,pm8998-gpio" "qcom,pma8084-gpio" "qcom,pmi8994-gpio" + "qcom,pms405-gpio" And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio" if the device is on an spmi bus or an ssbi bus respectively @@ -91,6 +92,7 @@ to specify in a pin configuration subnode: gpio1-gpio26 for pm8998 gpio1-gpio22 for pma8084 gpio1-gpio10 for pmi8994 + gpio1-gpio11 for pms405 - function: Usage: required diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index a29efbe08f48..b54891998caa 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = { { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */ { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */ { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */ + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */ { .compatible = "qcom,spmi-gpio" }, /* Generic */ { }, };