| Message ID | 20180908131345.8145-3-kernel@nospam.obeliks.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | mtd concat device driver | expand |
On Sat, 8 Sep 2018 at 15:14, Bernhard Frauendienst <kernel@nospam.obeliks.de> wrote: > > Document virtual mtd-concat device bindings. > > Signed-off-by: Bernhard Frauendienst <kernel@nospam.obeliks.de> > --- > .../devicetree/bindings/mtd/mtd-concat.txt | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/mtd-concat.txt > > diff --git a/Documentation/devicetree/bindings/mtd/mtd-concat.txt b/Documentation/devicetree/bindings/mtd/mtd-concat.txt > new file mode 100644 > index 000000000000..2daf3157b163 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/mtd-concat.txt > @@ -0,0 +1,36 @@ > +Virtual MTD concat device I think you forgot to include the documentation. Please ***describe*** that binding.
Am 10.09.2018 um 12:51 schrieb Rafał Miłecki:
> On Sat, 8 Sep 2018 at 15:14, Bernhard Frauendienst > <kernel@nospam.obeliks.de> wrote: >> >> Document virtual mtd-concat
device bindings. >> >> Signed-off-by: Bernhard Frauendienst
<kernel@nospam.obeliks.de> >> --- >>
.../devicetree/bindings/mtd/mtd-concat.txt | 36 +++++++++++++++++++ >> 1
file changed, 36 insertions(+) >> create mode 100644
Documentation/devicetree/bindings/mtd/mtd-concat.txt >> >> diff --git
a/Documentation/devicetree/bindings/mtd/mtd-concat.txt
b/Documentation/devicetree/bindings/mtd/mtd-concat.txt >> new file mode
100644 >> index 000000000000..2daf3157b163 >> --- /dev/null >> +++
b/Documentation/devicetree/bindings/mtd/mtd-concat.txt >> @@ -0,0 +1,36
@@ >> +Virtual MTD concat device > > I think you forgot to include the
documentation. Please ***describe*** > that binding.
You are right, I'm afraid I was mislead by some of the rather sparse
documentation files in the mtd directory.
Would something along these lines be sufficient?
--snip--
Virtual MTD concat device
A virtual composite device that concatenates multiple child devices into a
single mtd device. The child mtd nodes must also be defined in the tree and
are referenced using phandles.
Required properties:
- compatible : must be "mtd-concat"
- devices : list of phandles to mtd nodes in the order they should be
concatenated
The device tree may optionally contain sub-nodes describing partitions
of the
address space. See partition.txt for more detail.
Example:
--snip--
Regards,
Bernhard
Am 10.09.2018 um 14:13 schrieb Bernhard Frauendienst:
> Am 10.09.2018 um 12:51 schrieb Rafał Miłecki: >> I think you forgot to include the documentation. Please
***describe*** >> that binding. > You are right, I'm afraid I was
mislead by some of the rather sparse > documentation files in the mtd
directory. > Would something along these lines be sufficient?
I'm sorry, I have no idea why my Thunderbird+External editor insists on
breaking quotes like this. I will switch to a different mailer for the
mailing
list.
diff --git a/Documentation/devicetree/bindings/mtd/mtd-concat.txt b/Documentation/devicetree/bindings/mtd/mtd-concat.txt new file mode 100644 index 000000000000..2daf3157b163 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/mtd-concat.txt @@ -0,0 +1,36 @@ +Virtual MTD concat device + +Requires properties: +- devices: list of phandles to mtd nodes that should be concatenated + +Example: + +&spi { + flash0: flash@0 { + ... + }; + flash1: flash@1 { + ... + }; +}; + +flash { + compatible = "mtd-concat"; + + devices = <&flash0 &flash1>; + + partitions { + compatible = "fixed-partitions"; + + partition@0 { + label = "boot"; + reg = <0x0000000 0x0040000>; + read-only; + }; + + partition@40000 { + label = "firmware"; + reg = <0x0040000 0x1fc0000>; + }; + } +}
Document virtual mtd-concat device bindings. Signed-off-by: Bernhard Frauendienst <kernel@nospam.obeliks.de> --- .../devicetree/bindings/mtd/mtd-concat.txt | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/mtd-concat.txt