| Message ID | 20180817191026.32245-2-ilina@codeaurora.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Wakeup GPIO support for SDM845 SoC | expand |
On Fri, 17 Aug 2018 13:10:22 -0600, Lina Iyer wrote: > Update the documentation to use interrupts-extended format for > specifying the TLMM summary IRQ line that is requested from GIC and the > PDC interrupts corresponding to the wakeup capable GPIOs. > > Update the example to show PDC interrupts for the wakeup capable GPIOs > for SDM845. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > --- > .../bindings/pinctrl/qcom,sdm845-pinctrl.txt | 58 ++++++++++++++++++- > 1 file changed, 55 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Fri 17 Aug 12:10 PDT 2018, Lina Iyer wrote: > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt [..] > @@ -155,11 +166,52 @@ Example: > tlmm: pinctrl@3400000 { > compatible = "qcom,sdm845-pinctrl"; > reg = <0x03400000 0xc00000>; > - interrupts = <GIC_SPI 208 0>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > + interrupts-extended = <&intc GIC_SPI 208 0>, > + <&pdc 510 0>, <&pdc 511 0>, <&pdc 512 0>, <&pdc 513 0>, > + <&pdc 514 0>, <&pdc 515 0>, <&pdc 516 0>, <&pdc 517 0>, > + <&pdc 518 0>, <&pdc 519 0>, <&pdc 632 0>, <&pdc 639 0>, > + <&pdc 521 0>, <&pdc 522 0>, <&pdc 523 0>, <&pdc 524 0>, > + <&pdc 525 0>, <&pdc 526 0>, <&pdc 527 0>, <&pdc 630 0>, > + <&pdc 637 0>, <&pdc 529 0>, <&pdc 530 0>, <&pdc 531 0>, > + <&pdc 532 0>, <&pdc 633 0>, <&pdc 640 0>, <&pdc 534 0>, > + <&pdc 535 0>, <&pdc 536 0>, <&pdc 537 0>, <&pdc 538 0>, > + <&pdc 539 0>, <&pdc 540 0>, <&pdc 541 0>, <&pdc 542 0>, > + <&pdc 543 0>, <&pdc 544 0>, <&pdc 545 0>, <&pdc 546 0>, > + <&pdc 547 0>, <&pdc 548 0>, <&pdc 549 0>, <&pdc 550 0>, > + <&pdc 551 0>, <&pdc 552 0>, <&pdc 553 0>, <&pdc 554 0>, > + <&pdc 555 0>, <&pdc 556 0>, <&pdc 557 0>, <&pdc 631 0>, > + <&pdc 638 0>, <&pdc 559 0>, <&pdc 560 0>, <&pdc 561 0>, > + <&pdc 562 0>, <&pdc 563 0>, <&pdc 564 0>, <&pdc 565 0>, > + <&pdc 566 0>, <&pdc 570 0>, <&pdc 571 0>, <&pdc 572 0>, > + <&pdc 573 0>, <&pdc 609 0>, <&pdc 610 0>, <&pdc 611 0>, > + <&pdc 612 0>, <&pdc 613 0>, <&pdc 614 0>, <&pdc 615 0>, > + <&pdc 617 0>, <&pdc 618 0>, <&pdc 619 0>, <&pdc 620 0>, > + <&pdc 621 0>, <&pdc 622 0>, <&pdc 623 0>; I would expect that there are about 80 WARN_ON() hit in the irq code when you boot mainline with this. Have you tried that? Looks reasonable otherwise. Regards, Bjorn
On 21/08/18 00:19, Bjorn Andersson wrote: > On Fri 17 Aug 12:10 PDT 2018, Lina Iyer wrote: >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt > [..] >> @@ -155,11 +166,52 @@ Example: >> tlmm: pinctrl@3400000 { >> compatible = "qcom,sdm845-pinctrl"; >> reg = <0x03400000 0xc00000>; >> - interrupts = <GIC_SPI 208 0>; >> gpio-controller; >> #gpio-cells = <2>; >> interrupt-controller; >> #interrupt-cells = <2>; >> + interrupts-extended = <&intc GIC_SPI 208 0>, >> + <&pdc 510 0>, <&pdc 511 0>, <&pdc 512 0>, <&pdc 513 0>, >> + <&pdc 514 0>, <&pdc 515 0>, <&pdc 516 0>, <&pdc 517 0>, >> + <&pdc 518 0>, <&pdc 519 0>, <&pdc 632 0>, <&pdc 639 0>, >> + <&pdc 521 0>, <&pdc 522 0>, <&pdc 523 0>, <&pdc 524 0>, >> + <&pdc 525 0>, <&pdc 526 0>, <&pdc 527 0>, <&pdc 630 0>, >> + <&pdc 637 0>, <&pdc 529 0>, <&pdc 530 0>, <&pdc 531 0>, >> + <&pdc 532 0>, <&pdc 633 0>, <&pdc 640 0>, <&pdc 534 0>, >> + <&pdc 535 0>, <&pdc 536 0>, <&pdc 537 0>, <&pdc 538 0>, >> + <&pdc 539 0>, <&pdc 540 0>, <&pdc 541 0>, <&pdc 542 0>, >> + <&pdc 543 0>, <&pdc 544 0>, <&pdc 545 0>, <&pdc 546 0>, >> + <&pdc 547 0>, <&pdc 548 0>, <&pdc 549 0>, <&pdc 550 0>, >> + <&pdc 551 0>, <&pdc 552 0>, <&pdc 553 0>, <&pdc 554 0>, >> + <&pdc 555 0>, <&pdc 556 0>, <&pdc 557 0>, <&pdc 631 0>, >> + <&pdc 638 0>, <&pdc 559 0>, <&pdc 560 0>, <&pdc 561 0>, >> + <&pdc 562 0>, <&pdc 563 0>, <&pdc 564 0>, <&pdc 565 0>, >> + <&pdc 566 0>, <&pdc 570 0>, <&pdc 571 0>, <&pdc 572 0>, >> + <&pdc 573 0>, <&pdc 609 0>, <&pdc 610 0>, <&pdc 611 0>, >> + <&pdc 612 0>, <&pdc 613 0>, <&pdc 614 0>, <&pdc 615 0>, >> + <&pdc 617 0>, <&pdc 618 0>, <&pdc 619 0>, <&pdc 620 0>, >> + <&pdc 621 0>, <&pdc 622 0>, <&pdc 623 0>; > > I would expect that there are about 80 WARN_ON() hit in the irq code > when you boot mainline with this. Have you tried that? Dunno about the ones pointing to the PDC, but the one pointing to the GIC is definitely a howler. Another reason for this code to be developed and tested with mainline. Thanks, M.
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt index 665aadb5ea28..d7408cc74e01 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt @@ -13,10 +13,21 @@ SDM845 platform. Value type: <prop-encoded-array> Definition: the base address and size of the TLMM register space. -- interrupts: +- interrupts-extended: Usage: required Value type: <prop-encoded-array> - Definition: should specify the TLMM summary IRQ. + Definition: should specify the TLMM summary IRQ as the first + interrupt. Optionally, wake up capable GPIOs may list + their corresponding PDC interrupts here. + +- interrupt-names: + Usage: required + Value type: <string> + Definition: the names matching the interrupt definition in the + interrupts-extended property. The first interrupt name + must be "summary-irq" for the TLMM summary IRQ. PDC + interrupts must be described by "gpioN", where N is the + GPIO line corresponding to the PDC IRQ. - interrupt-controller: Usage: required @@ -155,11 +166,52 @@ Example: tlmm: pinctrl@3400000 { compatible = "qcom,sdm845-pinctrl"; reg = <0x03400000 0xc00000>; - interrupts = <GIC_SPI 208 0>; gpio-controller; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; + interrupts-extended = <&intc GIC_SPI 208 0>, + <&pdc 510 0>, <&pdc 511 0>, <&pdc 512 0>, <&pdc 513 0>, + <&pdc 514 0>, <&pdc 515 0>, <&pdc 516 0>, <&pdc 517 0>, + <&pdc 518 0>, <&pdc 519 0>, <&pdc 632 0>, <&pdc 639 0>, + <&pdc 521 0>, <&pdc 522 0>, <&pdc 523 0>, <&pdc 524 0>, + <&pdc 525 0>, <&pdc 526 0>, <&pdc 527 0>, <&pdc 630 0>, + <&pdc 637 0>, <&pdc 529 0>, <&pdc 530 0>, <&pdc 531 0>, + <&pdc 532 0>, <&pdc 633 0>, <&pdc 640 0>, <&pdc 534 0>, + <&pdc 535 0>, <&pdc 536 0>, <&pdc 537 0>, <&pdc 538 0>, + <&pdc 539 0>, <&pdc 540 0>, <&pdc 541 0>, <&pdc 542 0>, + <&pdc 543 0>, <&pdc 544 0>, <&pdc 545 0>, <&pdc 546 0>, + <&pdc 547 0>, <&pdc 548 0>, <&pdc 549 0>, <&pdc 550 0>, + <&pdc 551 0>, <&pdc 552 0>, <&pdc 553 0>, <&pdc 554 0>, + <&pdc 555 0>, <&pdc 556 0>, <&pdc 557 0>, <&pdc 631 0>, + <&pdc 638 0>, <&pdc 559 0>, <&pdc 560 0>, <&pdc 561 0>, + <&pdc 562 0>, <&pdc 563 0>, <&pdc 564 0>, <&pdc 565 0>, + <&pdc 566 0>, <&pdc 570 0>, <&pdc 571 0>, <&pdc 572 0>, + <&pdc 573 0>, <&pdc 609 0>, <&pdc 610 0>, <&pdc 611 0>, + <&pdc 612 0>, <&pdc 613 0>, <&pdc 614 0>, <&pdc 615 0>, + <&pdc 617 0>, <&pdc 618 0>, <&pdc 619 0>, <&pdc 620 0>, + <&pdc 621 0>, <&pdc 622 0>, <&pdc 623 0>; + interrupt-names = "summary-irq", + "gpio1", "gpio3", "gpio5", "gpio10", + "gpio11", "gpio20", "gpio22", "gpio24", + "gpio26", "gpio30", "gpio31", "gpio31", + "gpio32", "gpio34", "gpio36", "gpio37", + "gpio38", "gpio39", "gpio40", "gpio41", + "gpio41", "gpio43", "gpio44", "gpio46", + "gpio48", "gpio49", "gpio49", "gpio52", + "gpio53", "gpio54", "gpio56", "gpio57", + "gpio58", "gpio59", "gpio60", "gpio61", + "gpio62", "gpio63", "gpio64", "gpio66", + "gpio68", "gpio71", "gpio73", "gpio77", + "gpio78", "gpio79", "gpio80", "gpio84", + "gpio85", "gpio86", "gpio88", "gpio89", + "gpio89", "gpio91", "gpio92", "gpio95", + "gpio96", "gpio97", "gpio101", "gpio103", + "gpio104", "gpio115", "gpio116", "gpio117", + "gpio118", "gpio119", "gpio120", "gpio121", + "gpio122", "gpio123", "gpio124", "gpio125", + "gpio127", "gpio128", "gpio129", "gpio130", + "gpio132", "gpio133", "gpio145"; qup9_active: qup9-active { mux {
Update the documentation to use interrupts-extended format for specifying the TLMM summary IRQ line that is requested from GIC and the PDC interrupts corresponding to the wakeup capable GPIOs. Update the example to show PDC interrupts for the wakeup capable GPIOs for SDM845. Cc: devicetree@vger.kernel.org Signed-off-by: Lina Iyer <ilina@codeaurora.org> --- .../bindings/pinctrl/qcom,sdm845-pinctrl.txt | 58 ++++++++++++++++++- 1 file changed, 55 insertions(+), 3 deletions(-)