| Message ID | 20180713151450.2098-1-alexander.sverdlin@nokia.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | of: Export of_node_ktype | expand |
Hi Alexander, On 07/13/18 08:14, Alexander Sverdlin wrote: > This is necessary for of_node_init() to work in modules. > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> > --- > drivers/of/kobj.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c > index 7a0a18980b98..6348174ff615 100644 > --- a/drivers/of/kobj.c > +++ b/drivers/of/kobj.c > @@ -27,6 +27,7 @@ static void of_node_release(struct kobject *kobj) > struct kobj_type of_node_ktype = { > .release = of_node_release, > }; > +EXPORT_SYMBOL_GPL(of_node_ktype); > > static ssize_t of_node_property_read(struct file *filp, struct kobject *kobj, > struct bin_attribute *bin_attr, char *buf, > I would not expect a generic module to need of_node_init(). So digging a little bit deeper, what module needs of_node_init() and how is it using it? Thanks, Frank -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Frank, On 13/07/18 18:05, Frank Rowand wrote: > I would not expect a generic module to need of_node_init(). So digging a > little bit deeper, what module needs of_node_init() and how is it using it? legacy out-of-tree modules which were implementing DT overlay functionality in pre-overlay times.
On 07/13/18 09:11, Alexander Sverdlin wrote: > Hello Frank, > > On 13/07/18 18:05, Frank Rowand wrote: >> I would not expect a generic module to need of_node_init(). So digging a >> little bit deeper, what module needs of_node_init() and how is it using it? > > legacy out-of-tree modules which were implementing DT overlay functionality in pre-overlay > times. Thanks for the description. The export should also stay out of tree. -Frank -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c index 7a0a18980b98..6348174ff615 100644 --- a/drivers/of/kobj.c +++ b/drivers/of/kobj.c @@ -27,6 +27,7 @@ static void of_node_release(struct kobject *kobj) struct kobj_type of_node_ktype = { .release = of_node_release, }; +EXPORT_SYMBOL_GPL(of_node_ktype); static ssize_t of_node_property_read(struct file *filp, struct kobject *kobj, struct bin_attribute *bin_attr, char *buf,
This is necessary for of_node_init() to work in modules. Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> --- drivers/of/kobj.c | 1 + 1 file changed, 1 insertion(+)