| Message ID | 20180411164036.8046-2-manivannan.sadhasivam@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add Actions Semi S900 SPS support | expand |
On Wed, Apr 11, 2018 at 10:10:33PM +0530, Manivannan Sadhasivam wrote: > Define power domains for Actions Semi S900 SoC Smart Power System (SPS). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ > include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > create mode 100644 include/dt-bindings/power/owl-s900-powergate.h Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mani, Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > Define power domains for Actions Semi S900 SoC Smart Power System (SPS). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ > include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > create mode 100644 include/dt-bindings/power/owl-s900-powergate.h > > diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > index 78edd63641e8..a3571937b019 100644 > --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt > +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > @@ -3,11 +3,13 @@ Actions Semi Owl Smart Power System (SPS) > Required properties: > - compatible : "actions,s500-sps" for S500 > "actions,s700-sps" for S700 > + "actions,s900-sps" for S900 > - reg : Offset and length of the register set for the device. > - #power-domain-cells : Must be 1. > See macros in: > include/dt-bindings/power/owl-s500-powergate.h for S500 > include/dt-bindings/power/owl-s700-powergate.h for S700 > + include/dt-bindings/power/owl-s900-powergate.h for S900 > > > Example: > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > new file mode 100644 > index 000000000000..f1aaf761112b > --- /dev/null > +++ b/include/dt-bindings/power/owl-s900-powergate.h > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: GPL-2.0+ checkpatch.pl warns about this line due to not using /* ... */ syntax for headers. I could fix that up on my own, but it made me realize that you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is supposed to be dual-licensed. Can you please give your consent to make this /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ like my S500 and S700 bindings? Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? Otherwise looks fine, except that I'll need a topic branch (v4.19/s900-sps-bindings) if we want to merge the driver portion at the same time. Regards, Andreas > +/* > + * Actions Semi S900 SPS > + * > + * Copyright (c) 2018 Linaro Ltd. > + */ > +#ifndef DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > +#define DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > + > +#define S900_PD_GPU_B 0 > +#define S900_PD_VCE 1 > +#define S900_PD_SENSOR 2 > +#define S900_PD_VDE 3 > +#define S900_PD_HDE 4 > +#define S900_PD_USB3 5 > +#define S900_PD_DDR0 6 > +#define S900_PD_DDR1 7 > +#define S900_PD_DE 8 > +#define S900_PD_NAND 9 > +#define S900_PD_USB2_H0 10 > +#define S900_PD_USB2_H1 11 > + > +#endif >
Hi Andreas, On Sun, Jun 24, 2018 at 03:04:21PM +0200, Andreas Färber wrote: > Hi Mani, > > Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > > Define power domains for Actions Semi S900 SoC Smart Power System (SPS). > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ > > include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ > > 2 files changed, 25 insertions(+) > > create mode 100644 include/dt-bindings/power/owl-s900-powergate.h > > > > diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > > index 78edd63641e8..a3571937b019 100644 > > --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt > > +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > > @@ -3,11 +3,13 @@ Actions Semi Owl Smart Power System (SPS) > > Required properties: > > - compatible : "actions,s500-sps" for S500 > > "actions,s700-sps" for S700 > > + "actions,s900-sps" for S900 > > - reg : Offset and length of the register set for the device. > > - #power-domain-cells : Must be 1. > > See macros in: > > include/dt-bindings/power/owl-s500-powergate.h for S500 > > include/dt-bindings/power/owl-s700-powergate.h for S700 > > + include/dt-bindings/power/owl-s900-powergate.h for S900 > > > > > > Example: > > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > > new file mode 100644 > > index 000000000000..f1aaf761112b > > --- /dev/null > > +++ b/include/dt-bindings/power/owl-s900-powergate.h > > @@ -0,0 +1,23 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > checkpatch.pl warns about this line due to not using /* ... */ syntax > for headers. I could fix that up on my own, but it made me realize that > you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is > supposed to be dual-licensed. > > Can you please give your consent to make this > > /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > You can change the license to GPL-2.0+ OR MIT. > like my S500 and S700 bindings? > > Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? > I think GPL-2.0+ is fine. Thanks, Mani > Otherwise looks fine, except that I'll need a topic branch > (v4.19/s900-sps-bindings) if we want to merge the driver portion at the > same time. > > Regards, > Andreas > > > +/* > > + * Actions Semi S900 SPS > > + * > > + * Copyright (c) 2018 Linaro Ltd. > > + */ > > +#ifndef DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > > +#define DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > > + > > +#define S900_PD_GPU_B 0 > > +#define S900_PD_VCE 1 > > +#define S900_PD_SENSOR 2 > > +#define S900_PD_VDE 3 > > +#define S900_PD_HDE 4 > > +#define S900_PD_USB3 5 > > +#define S900_PD_DDR0 6 > > +#define S900_PD_DDR1 7 > > +#define S900_PD_DE 8 > > +#define S900_PD_NAND 9 > > +#define S900_PD_USB2_H0 10 > > +#define S900_PD_USB2_H1 11 > > + > > +#endif > > > > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 26, 2018 at 10:11:17PM +0530, Manivannan Sadhasivam wrote: > > > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > > > new file mode 100644 > > > index 000000000000..f1aaf761112b > > > --- /dev/null > > > +++ b/include/dt-bindings/power/owl-s900-powergate.h > > > @@ -0,0 +1,23 @@ > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > checkpatch.pl warns about this line due to not using /* ... */ syntax > > for headers. I could fix that up on my own, but it made me realize that > > you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is > > supposed to be dual-licensed. > > > > Can you please give your consent to make this > > > > /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > > > > You can change the license to GPL-2.0+ OR MIT. > > > like my S500 and S700 bindings? > > > > Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? > > > > I think GPL-2.0+ is fine. So... when I saw this I did wonder why one would knowly choose to use a deprecated license identifier (https://spdx.org/licenses/ ). However running `git diff v4.17..v4.18-rc1` through some filters does indicate that GPL-2.0+ is the more popular choice by 256 to 0! Doesn't mean you couldn't break the mould though ;-). Daniel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 27.06.2018 um 16:57 schrieb Daniel Thompson: > On Tue, Jun 26, 2018 at 10:11:17PM +0530, Manivannan Sadhasivam wrote: >>> Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? >> >> I think GPL-2.0+ is fine. > > So... when I saw this I did wonder why one would knowly choose to use a > deprecated license identifier (https://spdx.org/licenses/ ). > > However running `git diff v4.17..v4.18-rc1` through some filters does > indicate that GPL-2.0+ is the more popular choice by 256 to 0! Doesn't > mean you couldn't break the mould though ;-). The kernel.org documentation does not mention the new ones yet. I checked under LICENSES/ - preferred/GPL-2.0.txt actually lists both identifiers, and checkpatch.pl did not complain about either. So for my personal patches I'll be going with the new identifier, unless I hear of reasons not to. Cheers, Andreas
On Wed, Jun 27, 2018 at 03:57:13PM +0100, Daniel Thompson wrote: > On Tue, Jun 26, 2018 at 10:11:17PM +0530, Manivannan Sadhasivam wrote: > > > > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > > > > new file mode 100644 > > > > index 000000000000..f1aaf761112b > > > > --- /dev/null > > > > +++ b/include/dt-bindings/power/owl-s900-powergate.h > > > > @@ -0,0 +1,23 @@ > > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > > > checkpatch.pl warns about this line due to not using /* ... */ syntax > > > for headers. I could fix that up on my own, but it made me realize that > > > you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is > > > supposed to be dual-licensed. > > > > > > Can you please give your consent to make this > > > > > > /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > > > > > > > You can change the license to GPL-2.0+ OR MIT. > > > > > like my S500 and S700 bindings? > > > > > > Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? > > > > > > > I think GPL-2.0+ is fine. > > So... when I saw this I did wonder why one would knowly choose to use a > deprecated license identifier (https://spdx.org/licenses/ ). > > However running `git diff v4.17..v4.18-rc1` through some filters does > indicate that GPL-2.0+ is the more popular choice by 256 to 0! Doesn't > mean you couldn't break the mould though ;-). > I did grep through the source and hit with same numbers ;-) But I was not sure whether to break the mould or not, so chose the safest path :) Since you already gave the green signal, I think we can move to new style identifier. Thanks, Mani > > Daniel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt index 78edd63641e8..a3571937b019 100644 --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt @@ -3,11 +3,13 @@ Actions Semi Owl Smart Power System (SPS) Required properties: - compatible : "actions,s500-sps" for S500 "actions,s700-sps" for S700 + "actions,s900-sps" for S900 - reg : Offset and length of the register set for the device. - #power-domain-cells : Must be 1. See macros in: include/dt-bindings/power/owl-s500-powergate.h for S500 include/dt-bindings/power/owl-s700-powergate.h for S700 + include/dt-bindings/power/owl-s900-powergate.h for S900 Example: diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h new file mode 100644 index 000000000000..f1aaf761112b --- /dev/null +++ b/include/dt-bindings/power/owl-s900-powergate.h @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Actions Semi S900 SPS + * + * Copyright (c) 2018 Linaro Ltd. + */ +#ifndef DT_BINDINGS_POWER_OWL_S900_POWERGATE_H +#define DT_BINDINGS_POWER_OWL_S900_POWERGATE_H + +#define S900_PD_GPU_B 0 +#define S900_PD_VCE 1 +#define S900_PD_SENSOR 2 +#define S900_PD_VDE 3 +#define S900_PD_HDE 4 +#define S900_PD_USB3 5 +#define S900_PD_DDR0 6 +#define S900_PD_DDR1 7 +#define S900_PD_DE 8 +#define S900_PD_NAND 9 +#define S900_PD_USB2_H0 10 +#define S900_PD_USB2_H1 11 + +#endif
Define power domains for Actions Semi S900 SoC Smart Power System (SPS). Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 include/dt-bindings/power/owl-s900-powergate.h