| Message ID | 20180317092857.4396-4-wens@csie.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
Hello! On 3/17/2018 12:28 PM, Chen-Yu Tsai wrote: > The clock delay chains found in the glue layer for dwmac-sun8i are only > used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as > MII external PHYs or the internal PHY. Also, a recent SoC has a smaller > range of possible values for the delay chain. > > This patch reformats the delay chain section of the device tree binding > to make it clear that the delay chains only apply to RGMII PHYs, and > make it easier to add the R40-specific bits later. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt > index 3d6d5fa0c4d5..b8a3028d6c30 100644 > --- a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt > +++ b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt > @@ -28,10 +28,13 @@ Required properties: > - allwinner,sun8i-a83t-system-controller > > Optional properties: > -- allwinner,tx-delay-ps: TX clock delay chain value in ps. Range value is 0-700. Default is 0) > -- allwinner,rx-delay-ps: RX clock delay chain value in ps. Range value is 0-3100. Default is 0) > -Both delay properties need to be a multiple of 100. They control the delay for > -external PHY. > +- allwinner,tx-delay-ps: TX clock delay chain value in ps. > + Range is 0-700. Default is 0. > +- allwinner,rx-delay-ps: RX clock delay chain value in ps. > + Range is 0-3100. Default is 0. > +Both delay properties need to be a multiple of 100. They control the > +clock delay for external RGMII PHY. They are do apply to the internal s/are do/do not/? > +PHY or external non-RGMII PHYs. > > Optional properties for the following compatibles: > - "allwinner,sun8i-h3-emac", MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Mar 18, 2018 at 5:21 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello! > > > On 3/17/2018 12:28 PM, Chen-Yu Tsai wrote: > >> The clock delay chains found in the glue layer for dwmac-sun8i are only >> used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as >> MII external PHYs or the internal PHY. Also, a recent SoC has a smaller >> range of possible values for the delay chain. >> >> This patch reformats the delay chain section of the device tree binding >> to make it clear that the delay chains only apply to RGMII PHYs, and >> make it easier to add the R40-specific bits later. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt >> b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt >> index 3d6d5fa0c4d5..b8a3028d6c30 100644 >> --- a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt >> +++ b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt >> @@ -28,10 +28,13 @@ Required properties: >> - allwinner,sun8i-a83t-system-controller >> Optional properties: >> -- allwinner,tx-delay-ps: TX clock delay chain value in ps. Range value is >> 0-700. Default is 0) >> -- allwinner,rx-delay-ps: RX clock delay chain value in ps. Range value is >> 0-3100. Default is 0) >> -Both delay properties need to be a multiple of 100. They control the >> delay for >> -external PHY. >> +- allwinner,tx-delay-ps: TX clock delay chain value in ps. >> + Range is 0-700. Default is 0. >> +- allwinner,rx-delay-ps: RX clock delay chain value in ps. >> + Range is 0-3100. Default is 0. >> +Both delay properties need to be a multiple of 100. They control the >> +clock delay for external RGMII PHY. They are do apply to the internal > > > s/are do/do not/? Fixed. Thanks! ChenYu -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt index 3d6d5fa0c4d5..b8a3028d6c30 100644 --- a/Documentation/devicetree/bindings/net/dwmac-sun8i.txt +++ b/Documentation/devicetree/bindings/net/dwmac-sun8i.txt @@ -28,10 +28,13 @@ Required properties: - allwinner,sun8i-a83t-system-controller Optional properties: -- allwinner,tx-delay-ps: TX clock delay chain value in ps. Range value is 0-700. Default is 0) -- allwinner,rx-delay-ps: RX clock delay chain value in ps. Range value is 0-3100. Default is 0) -Both delay properties need to be a multiple of 100. They control the delay for -external PHY. +- allwinner,tx-delay-ps: TX clock delay chain value in ps. + Range is 0-700. Default is 0. +- allwinner,rx-delay-ps: RX clock delay chain value in ps. + Range is 0-3100. Default is 0. +Both delay properties need to be a multiple of 100. They control the +clock delay for external RGMII PHY. They are do apply to the internal +PHY or external non-RGMII PHYs. Optional properties for the following compatibles: - "allwinner,sun8i-h3-emac",
The clock delay chains found in the glue layer for dwmac-sun8i are only used with RGMII PHYs. They are not intended for non-RGMII PHYs, such as MII external PHYs or the internal PHY. Also, a recent SoC has a smaller range of possible values for the delay chain. This patch reformats the delay chain section of the device tree binding to make it clear that the delay chains only apply to RGMII PHYs, and make it easier to add the R40-specific bits later. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)