| Message ID | 20170609125730.25502-2-o.rempel@pengutronix.de |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
Hi Oleksij, Am 09.06.2017 um 14:57 schrieb Oleksij Rempel: > Documentation bindings for the Low Power General Purpose Register > available on i.MX6 SoCs in the Secure Non-Volatile Storage. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/nvmem/snvs-lpgpr.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > new file mode 100644 > index 000000000000..21910fb3159f > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > @@ -0,0 +1,19 @@ > +Device tree bindings for Low Power General Purpose Register found in i.MX6Q/D > +Secure Non-Volatile Storage. > + > +This DT node should be represented as a sub-node of a "syscon", > +"simple-mfd" node. > + > +Required properties: > +- compatible: should be: > + "fsl,imx6q-snvs-lpgpr" for Freescale i.MX6Q/D/DL/S > + > +Example: > +snvs: snvs@020cc000 { > + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd"; > + reg = <0x020cc000 0x4000>; > + > + snvs_lpgpr: snvs-lpgpr { > + compatible = "fsl,imx6q-snvs-lpgpr"; according to the reference manual at least the clock "lp_ipg_clk_s" is required for register R/W access. So it should be added to the binding and enabled by the driver. Best regards Stefan > + }; > +}; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/06/2017 15:57, Oleksij Rempel wrote: > Documentation bindings for the Low Power General Purpose Register > available on i.MX6 SoCs in the Secure Non-Volatile Storage. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/nvmem/snvs-lpgpr.txt | 19 > +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > new file mode 100644 > index 000000000000..21910fb3159f > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > @@ -0,0 +1,19 @@ > +Device tree bindings for Low Power General Purpose Register found in > i.MX6Q/D > +Secure Non-Volatile Storage. > + > +This DT node should be represented as a sub-node of a "syscon", > +"simple-mfd" node. > + > +Required properties: > +- compatible: should be: > + "fsl,imx6q-snvs-lpgpr" for Freescale i.MX6Q/D/DL/S I've tested the basic functionality on i.MX6UL. It seems to work as is. Please add "/UL" on the next version. Regards, Guy > + > +Example: > +snvs: snvs@020cc000 { > + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd"; > + reg = <0x020cc000 0x4000>; > + > + snvs_lpgpr: snvs-lpgpr { > + compatible = "fsl,imx6q-snvs-lpgpr"; > + }; > +}; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 09, 2017 at 04:59:00PM +0200, Stefan Wahren wrote: Hi Stefan, > Hi Oleksij, > > Am 09.06.2017 um 14:57 schrieb Oleksij Rempel: > > Documentation bindings for the Low Power General Purpose Register > > available on i.MX6 SoCs in the Secure Non-Volatile Storage. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > .../devicetree/bindings/nvmem/snvs-lpgpr.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > > > diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > new file mode 100644 > > index 000000000000..21910fb3159f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > @@ -0,0 +1,19 @@ > > +Device tree bindings for Low Power General Purpose Register found in i.MX6Q/D > > +Secure Non-Volatile Storage. > > + > > +This DT node should be represented as a sub-node of a "syscon", > > +"simple-mfd" node. > > + > > +Required properties: > > +- compatible: should be: > > + "fsl,imx6q-snvs-lpgpr" for Freescale i.MX6Q/D/DL/S > > + > > +Example: > > +snvs: snvs@020cc000 { > > + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd"; > > + reg = <0x020cc000 0x4000>; > > + > > + snvs_lpgpr: snvs-lpgpr { > > + compatible = "fsl,imx6q-snvs-lpgpr"; > > according to the reference manual at least the clock "lp_ipg_clk_s" is > required for register R/W access. > So it should be added to the binding and enabled by the driver. Hm... Non of current SNVS drives use, set or defines *_ipg_clk_s. I can't find in the docs how can I control this clocks. lp_ipg_clk_s and hp_ipg_clk_s depend on ipg_clk_root, which seems to be not gated. So, it is always on. Or do I miss something.
Hi Fabio, Am 19.06.2017 um 08:06 schrieb Oleksij Rempel: > On Fri, Jun 09, 2017 at 04:59:00PM +0200, Stefan Wahren wrote: > Hi Stefan, > >> Hi Oleksij, >> >> Am 09.06.2017 um 14:57 schrieb Oleksij Rempel: >>> Documentation bindings for the Low Power General Purpose Register >>> available on i.MX6 SoCs in the Secure Non-Volatile Storage. >>> >>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> >>> --- >>> .../devicetree/bindings/nvmem/snvs-lpgpr.txt | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt >>> >>> diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt >>> new file mode 100644 >>> index 000000000000..21910fb3159f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt >>> @@ -0,0 +1,19 @@ >>> +Device tree bindings for Low Power General Purpose Register found in i.MX6Q/D >>> +Secure Non-Volatile Storage. >>> + >>> +This DT node should be represented as a sub-node of a "syscon", >>> +"simple-mfd" node. >>> + >>> +Required properties: >>> +- compatible: should be: >>> + "fsl,imx6q-snvs-lpgpr" for Freescale i.MX6Q/D/DL/S >>> + >>> +Example: >>> +snvs: snvs@020cc000 { >>> + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd"; >>> + reg = <0x020cc000 0x4000>; >>> + >>> + snvs_lpgpr: snvs-lpgpr { >>> + compatible = "fsl,imx6q-snvs-lpgpr"; >> according to the reference manual at least the clock "lp_ipg_clk_s" is >> required for register R/W access. >> So it should be added to the binding and enabled by the driver. > Hm... > Non of current SNVS drives use, set or defines *_ipg_clk_s. I can't find > in the docs how can I control this clocks. > lp_ipg_clk_s and hp_ipg_clk_s depend on ipg_clk_root, which seems to be > not gated. So, it is always on. Or do I miss something. > do you know how the clock "lp_ipg_clk_s" should be handled? Thanks Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Stefan,
On Mon, Jun 19, 2017 at 7:58 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> do you know how the clock "lp_ipg_clk_s" should be handled?
As per the Reference Manual there is no CCM gating bits for this clock.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 19.06.2017 um 14:52 schrieb Fabio Estevam: > Hi Stefan, > > On Mon, Jun 19, 2017 at 7:58 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote: > >> do you know how the clock "lp_ipg_clk_s" should be handled? > As per the Reference Manual there is no CCM gating bits for this clock. I was only surprised that there is no clock handling in the driver. Sorry, about that noise. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt new file mode 100644 index 000000000000..21910fb3159f --- /dev/null +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt @@ -0,0 +1,19 @@ +Device tree bindings for Low Power General Purpose Register found in i.MX6Q/D +Secure Non-Volatile Storage. + +This DT node should be represented as a sub-node of a "syscon", +"simple-mfd" node. + +Required properties: +- compatible: should be: + "fsl,imx6q-snvs-lpgpr" for Freescale i.MX6Q/D/DL/S + +Example: +snvs: snvs@020cc000 { + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd"; + reg = <0x020cc000 0x4000>; + + snvs_lpgpr: snvs-lpgpr { + compatible = "fsl,imx6q-snvs-lpgpr"; + }; +};
Documentation bindings for the Low Power General Purpose Register available on i.MX6 SoCs in the Secure Non-Volatile Storage. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/nvmem/snvs-lpgpr.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt