diff mbox

dt-bindings: Document optional "reserved-names" property

Message ID 20170509171847.27457-1-f.fainelli@gmail.com
State Changes Requested, archived
Headers show

Commit Message

Florian Fainelli May 9, 2017, 5:18 p.m. UTC
Define an optional string property: "reserved-names" which can be used
by the client program to tag/identify reserved memory regions.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rob Herring May 12, 2017, 11:55 p.m. UTC | #1
On Tue, May 09, 2017 at 10:18:47AM -0700, Florian Fainelli wrote:
> Define an optional string property: "reserved-names" which can be used
> by the client program to tag/identify reserved memory regions.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> index 3da0ebdba8d9..bd3c9485f637 100644
> --- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> +++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
> @@ -64,6 +64,10 @@ reusable (optional) - empty property
>        system can use that region to store volatile or cached data that
>        can be otherwise regenerated or migrated elsewhere.
>  
> +reserved-names (optional)
> +    - Provides a named tag to the client program to help pretty print/identify
> +      the reserved memory region.

*-names is normally on the client side. I'd like to keep that 
consistent.

Second, I don't see the need for this. The compatible is not enough?

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Florian Fainelli May 19, 2017, 11:59 p.m. UTC | #2
On 05/12/2017 04:55 PM, Rob Herring wrote:
> On Tue, May 09, 2017 at 10:18:47AM -0700, Florian Fainelli wrote:
>> Define an optional string property: "reserved-names" which can be used
>> by the client program to tag/identify reserved memory regions.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
>> index 3da0ebdba8d9..bd3c9485f637 100644
>> --- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
>> +++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
>> @@ -64,6 +64,10 @@ reusable (optional) - empty property
>>        system can use that region to store volatile or cached data that
>>        can be otherwise regenerated or migrated elsewhere.
>>  
>> +reserved-names (optional)
>> +    - Provides a named tag to the client program to help pretty print/identify
>> +      the reserved memory region.
> 
> *-names is normally on the client side. I'd like to keep that 
> consistent.
> 
> Second, I don't see the need for this. The compatible is not enough?

Sounds like you are right, compatible is good enough, thanks
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
index 3da0ebdba8d9..bd3c9485f637 100644
--- a/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
+++ b/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
@@ -64,6 +64,10 @@  reusable (optional) - empty property
       system can use that region to store volatile or cached data that
       can be otherwise regenerated or migrated elsewhere.
 
+reserved-names (optional)
+    - Provides a named tag to the client program to help pretty print/identify
+      the reserved memory region.
+
 Linux implementation note:
 - If a "linux,cma-default" property is present, then Linux will use the
   region for the default pool of the contiguous memory allocator.