| Message ID | 20170329160057.8298-1-javier@osg.samsung.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, Mar 29, 2017 at 12:00:56PM -0400, Javier Martinez Canillas wrote: > The DT binding document for LTC2941 and LTC2943 battery gauges did not use > a vendor prefix in the listed compatible strings. The driver says that the > manufacturer is Linear Technology which is "lltc" in vendor-prefixes.txt. > > There isn't an upstream Device Tree source file that has nodes defined for > these devices, so there's no need to keep the old compatible strings. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/power/supply/ltc2941.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Mar 29, 2017 at 12:00:56PM -0400, Javier Martinez Canillas wrote: > The DT binding document for LTC2941 and LTC2943 battery gauges did not use > a vendor prefix in the listed compatible strings. The driver says that the > manufacturer is Linear Technology which is "lltc" in vendor-prefixes.txt. > > There isn't an upstream Device Tree source file that has nodes defined for > these devices, so there's no need to keep the old compatible strings. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Thanks, queued. -- Sebastian
Hi, On Wed, Mar 29, 2017 at 12:00:57PM -0400, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Thanks, queued. -- Sebastian
diff --git a/Documentation/devicetree/bindings/power/supply/ltc2941.txt b/Documentation/devicetree/bindings/power/supply/ltc2941.txt index ea42ae12d924..a9d7aa60558b 100644 --- a/Documentation/devicetree/bindings/power/supply/ltc2941.txt +++ b/Documentation/devicetree/bindings/power/supply/ltc2941.txt @@ -6,8 +6,8 @@ temperature monitoring, and uses a slightly different conversion formula for the charge counter. Required properties: -- compatible: Should contain "ltc2941" or "ltc2943" which also indicates the - type of I2C chip attached. +- compatible: Should contain "lltc,ltc2941" or "lltc,ltc2943" which also + indicates the type of I2C chip attached. - reg: The 7-bit I2C address. - lltc,resistor-sense: The sense resistor value in milli-ohms. Can be a 32-bit negative value when the battery has been connected to the wrong end of the @@ -20,7 +20,7 @@ Required properties: Example from the Topic Miami Florida board: fuelgauge: ltc2943@64 { - compatible = "ltc2943"; + compatible = "lltc,ltc2943"; reg = <0x64>; lltc,resistor-sense = <15>; lltc,prescaler-exponent = <5>; /* 2^(2*5) = 1024 */
The DT binding document for LTC2941 and LTC2943 battery gauges did not use a vendor prefix in the listed compatible strings. The driver says that the manufacturer is Linear Technology which is "lltc" in vendor-prefixes.txt. There isn't an upstream Device Tree source file that has nodes defined for these devices, so there's no need to keep the old compatible strings. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes in v4: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/power/supply/ltc2941.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)