| Message ID | 20161114183040.GB28778@amd |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Mon, Nov 14, 2016 at 12:30 PM, Pavel Machek <pavel@ucw.cz> wrote: > Add device tree binding documentation for toshiba et8ek8 sensor. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > Signed-off-by: Pavel Machek <pavel@ucw.cz> Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Pavel, On Mon, Nov 14, 2016 at 07:30:40PM +0100, Pavel Machek wrote: > Add device tree binding documentation for toshiba et8ek8 sensor. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > --- > > v6: added missing article, fixed signal polarity. > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > new file mode 100644 > index 0000000..b03b21d > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > @@ -0,0 +1,53 @@ > +Toshiba et8ek8 5MP sensor > + > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device > + > +More detailed documentation can be found in > +Documentation/devicetree/bindings/media/video-interfaces.txt . > + > + > +Mandatory properties > +-------------------- > + > +- compatible: "toshiba,et8ek8" > +- reg: I2C address (0x3e, or an alternative address) > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > +- clocks: External clock to the sensor > +- clock-frequency: Frequency of the external clock to the sensor. Camera > + driver will set this frequency on the external clock. The clock frequency is > + a pre-determined frequency known to be suitable to the board. > +- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor > + is in hardware standby mode when the signal is in the low state. > + > + > +Endpoint node mandatory properties > +---------------------------------- > + > +- remote-endpoint: A phandle to the bus receiver's endpoint node. > + > +Endpoint node optional properties > +---------------------------------- > + > +- clock-lanes: <0> > +- data-lanes: <1..n> The driver makes no use of them and CCP2 only supports a single lane. I'll just remove these and apply it to my tree. Let's continue discussing the driver patch in the other thread. > + > +Example > +------- > + > +&i2c3 { > + clock-frequency = <400000>; > + > + cam1: camera@3e { > + compatible = "toshiba,et8ek8"; > + reg = <0x3e>; > + vana-supply = <&vaux4>; > + clocks = <&isp 0>; > + clock-frequency = <9600000>; > + reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */ > + port { > + csi_cam1: endpoint { > + remote-endpoint = <&csi_out1>; > + }; > + }; > + }; > +}; >
On Tue 2016-12-20 15:05:39, Sakari Ailus wrote: > Hi Pavel, > > > +Endpoint node mandatory properties > > +---------------------------------- > > + > > +- remote-endpoint: A phandle to the bus receiver's endpoint node. > > + > > +Endpoint node optional properties > > +---------------------------------- > > + > > +- clock-lanes: <0> > > +- data-lanes: <1..n> > > The driver makes no use of them and CCP2 only supports a single lane. I'll > just remove these and apply it to my tree. Let's continue discussing the > driver patch in the other thread. Ok, thanks! Pavel
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt new file mode 100644 index 0000000..b03b21d --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt @@ -0,0 +1,53 @@ +Toshiba et8ek8 5MP sensor + +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device + +More detailed documentation can be found in +Documentation/devicetree/bindings/media/video-interfaces.txt . + + +Mandatory properties +-------------------- + +- compatible: "toshiba,et8ek8" +- reg: I2C address (0x3e, or an alternative address) +- vana-supply: Analogue voltage supply (VANA), 2.8 volts +- clocks: External clock to the sensor +- clock-frequency: Frequency of the external clock to the sensor. Camera + driver will set this frequency on the external clock. The clock frequency is + a pre-determined frequency known to be suitable to the board. +- reset-gpios: XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor + is in hardware standby mode when the signal is in the low state. + + +Endpoint node mandatory properties +---------------------------------- + +- remote-endpoint: A phandle to the bus receiver's endpoint node. + +Endpoint node optional properties +---------------------------------- + +- clock-lanes: <0> +- data-lanes: <1..n> + +Example +------- + +&i2c3 { + clock-frequency = <400000>; + + cam1: camera@3e { + compatible = "toshiba,et8ek8"; + reg = <0x3e>; + vana-supply = <&vaux4>; + clocks = <&isp 0>; + clock-frequency = <9600000>; + reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */ + port { + csi_cam1: endpoint { + remote-endpoint = <&csi_out1>; + }; + }; + }; +};