| Message ID | 1714385807-22393-2-git-send-email-alina_yu@richtek.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Fix rtq2208 buck ramp_delay and ldo discharge and dvs setting | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 28 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 29/04/2024 12:16, Alina Yu wrote: > Since there is no way to check is ldo is adjustable or not. > 'richtek,use-fix-dvs' is added for that. user is supposed to know whether vout of ldo is adjustable. 1. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 2. Start sentences with capital letters. LDO is acronym. 3. Constraints already tell you that, don't they? Explain why they are not enough and you need new property. > > Signed-off-by: Alina Yu <alina_yu@richtek.com> > --- > .../devicetree/bindings/regulator/richtek,rtq2208.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > index 609c066..3951679 100644 > --- a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > @@ -75,6 +75,14 @@ properties: > description: > regulator description for ldo[1-2]. > > + properties: > + richtek,use-fix-dvs: > + type: boolean > + description: | > + ldo vout ability is determined by this setting. If it's set, the voltage is unadjustable. > + There is no risk-free method for software to determine whether the ldo vout is fixed or not. > + Therefore, it can only be done in this way. Wrap according to Linux style (as expressed in Linux coding style document). Best regards, Krzysztof
On Mon, Apr 29, 2024 at 06:16:46PM +0800, Alina Yu wrote: > Since there is no way to check is ldo is adjustable or not. > 'richtek,use-fix-dvs' is added for that. user is supposed to know whether vout of ldo is adjustable. As Krzysztof said we already know if the voltage can change since in order for Linux to change the voltage there must be a voltage range specified (and see comment on patch 2).
diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml index 609c066..3951679 100644 --- a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml @@ -75,6 +75,14 @@ properties: description: regulator description for ldo[1-2]. + properties: + richtek,use-fix-dvs: + type: boolean + description: | + ldo vout ability is determined by this setting. If it's set, the voltage is unadjustable. + There is no risk-free method for software to determine whether the ldo vout is fixed or not. + Therefore, it can only be done in this way. + required: - compatible - reg @@ -180,6 +188,7 @@ examples: regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; regulator-always-on; + richtek,use-fix-dvs; regulator-state-mem { regulator-on-in-suspend; }; @@ -188,6 +197,7 @@ examples: regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + richtek,use-fix-dvs; regulator-state-mem { regulator-on-in-suspend; };
Since there is no way to check is ldo is adjustable or not. 'richtek,use-fix-dvs' is added for that. user is supposed to know whether vout of ldo is adjustable. Signed-off-by: Alina Yu <alina_yu@richtek.com> --- .../devicetree/bindings/regulator/richtek,rtq2208.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)