| Message ID | 1695030341-20711-2-git-send-email-cy_huang@richtek.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ASoC: Add rtq9128 audio amplifier | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 51 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 18/09/2023 11:45, cy_huang@richtek.com wrote: > From: ChiYuan Huang <cy_huang@richtek.com> > > Create richtek,rtq9128.yaml for rtq9128 amplifier. > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > --- > .../bindings/sound/richtek,rtq9128.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml > > diff --git a/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml b/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml > new file mode 100644 > index 000000000000..a79694c2b169 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license is needed. Just like checkpatch is asking for. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/richtek,rtq9128.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Richtek RTQ9128 Automative Audio Power Amplifier > + > +maintainers: > + - ChiYuan Huang <cy_huang@richtek.com> > + > +description: | Do not need '|' unless you need to preserve formatting. > + The RTQ9128 is a ultra-low output noise, high-efficiency, four-channel > + class-D audio power amplifier and delivering 4x75W into 4OHm at 10% > + THD+N from a 25V supply in automotive applications. > + Missing ref to dai common. > +properties: > + compatible: > + enum: > + - richtek,rtq9128 > + > + reg: > + maxItems: 1 > + > + enable-gpios: > + maxItems: 1 > + > + '#sound-dai-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - '#sound-dai-cells' > + > +unevaluatedProperties: false This goes with mentioned $ref. Alone would not be correct. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml b/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml new file mode 100644 index 000000000000..a79694c2b169 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/richtek,rtq9128.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Richtek RTQ9128 Automative Audio Power Amplifier + +maintainers: + - ChiYuan Huang <cy_huang@richtek.com> + +description: | + The RTQ9128 is a ultra-low output noise, high-efficiency, four-channel + class-D audio power amplifier and delivering 4x75W into 4OHm at 10% + THD+N from a 25V supply in automotive applications. + +properties: + compatible: + enum: + - richtek,rtq9128 + + reg: + maxItems: 1 + + enable-gpios: + maxItems: 1 + + '#sound-dai-cells': + const: 0 + +required: + - compatible + - reg + - '#sound-dai-cells' + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + speaker@1a { + compatible = "richtek,rtq9128"; + reg = <0x1a>; + enable-gpios = <&gpio 26 GPIO_ACTIVE_HIGH>; + #sound-dai-cells = <0>; + }; + };