| Message ID | 1678164097-13247-2-git-send-email-quic_mmanikan@quicinc.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add multipd remoteproc support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 07 Mar 2023 10:11:27 +0530, Manikanta Mylavarapu wrote: > Add new binding document for multipd model remoteproc. > IPQ5018, IPQ9574 follows multipd model. > > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> > --- > .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ > 1 file changed, 282 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dts:22:18: fatal error: dt-bindings/clock/qcom,gcc-ipq5018.h: No such file or directory 22 | #include <dt-bindings/clock/qcom,gcc-ipq5018.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1678164097-13247-2-git-send-email-quic_mmanikan@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Mar 07, 2023 at 10:11:27AM +0530, Manikanta Mylavarapu wrote: > Add new binding document for multipd model remoteproc. > IPQ5018, IPQ9574 follows multipd model. > > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> > --- > .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ > 1 file changed, 282 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml > new file mode 100644 > index 000000000000..b788607f5abd > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml > @@ -0,0 +1,282 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Multipd Secure Peripheral Image Loader > + > +maintainers: > + - Bjorn Andersson <andersson@kernel.org> > + - Mathieu Poirier <mathieu.poirier@linaro.org> > + > +description: > + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd > + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. What is PD? I don't see it defined anywhere. > + > +properties: > + compatible: > + enum: > + - qcom,ipq5018-q6-mpd > + - qcom,ipq9574-q6-mpd > + > + '#address-cells': true Need to define the size. > + > + '#size-cells': true ditto > + > + 'ranges': true Don't need quotes > + > + reg: > + maxItems: 1 > + > + interrupts-extended: Just 'interrupts'. Both forms are always supported. > + items: > + - description: Watchdog interrupt > + - description: Fatal interrupt > + - description: Ready interrupt > + - description: Handover interrupt > + - description: Stop acknowledge interrupt > + > + interrupt-names: > + items: > + - const: wdog > + - const: fatal > + - const: ready > + - const: handover > + - const: stop-ack > + > + clocks: > + minItems: 25 > + maxItems: 25 You need to list out what the clocks are. > + > + clock-names: > + minItems: 25 > + maxItems: 25 > + > + assigned-clocks: You can drop this. Implicitly supported. > + minItems: 13 > + maxItems: 13 > + > + assigned-clock-rates: > + minItems: 13 > + maxItems: 13 > + > + qcom,smem-states: > + $ref: /schemas/types.yaml#/definitions/phandle-array I believe this already has a type. It should be defined in a common schema if not already and then included in this schema. > + description: States used by the AP to signal the remoteprocessor > + items: > + - description: Shutdown Q6 > + - description: Stop Q6 > + > + qcom,smem-state-names: > + description: > + Names of the states used by the AP to signal the remoteprocessor > + items: > + - const: shutdown > + - const: stop > + > + memory-region: > + items: > + - description: Q6 pd reserved region > + > + glink-edge: > + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# > + description: > + Qualcomm G-Link subnode which represents communication edge, channels > + and devices related to the Modem. > + > +patternProperties: > + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": > + type: object > + description: > + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before > + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 > + device node. > + > + properties: > + compatible: > + enum: > + - "qcom,ipq5018-wcss-ahb-mpd" Don't need quotes. > + - "qcom,ipq9574-wcss-ahb-mpd" > + - "qcom,ipq5018-wcss-pcie-mpd" > + > + interrupts-extended: Just interrupts > + items: > + - description: Fatal interrupt > + - description: Ready interrupt > + - description: Spawn acknowledge interrupt > + - description: Stop acknowledge interrupt > + > + interrupt-names: > + items: > + - const: fatal > + - const: ready > + - const: spawn-ack > + - const: stop-ack > + > + qcom,smem-states: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: States used by the AP to signal the remoteprocessor > + items: > + - description: Shutdown WCSS pd > + - description: Stop WCSS pd > + - description: Spawn WCSS pd > + > + qcom,smem-state-names: > + description: > + Names of the states used by the AP to signal the remoteprocessor > + items: > + - const: shutdown > + - const: stop > + - const: spawn > + > + required: > + - compatible > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts-extended > + - interrupt-names > + - qcom,smem-states > + - qcom,smem-state-names > + - memory-region > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - qcom,ipq9574-q6-mpd > + then: > + properties: > + assigned-clocks: Don't need to define assigned-clocks > + items: > + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK > + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK > + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK > + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK > + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK > + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK > + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK > + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK > + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK > + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK > + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK > + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK > + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK > + assigned-clock-rates: > + items: > + - description: Must be 266666667 HZ > + - description: Must be 133333333 HZ > + - description: Must be 133333333 HZ > + - description: Must be 133333333 HZ > + - description: Must be 266666667 HZ > + - description: Must be 533000000 HZ > + - description: Must be 342857143 HZ > + - description: Must be 133333333 HZ > + - description: Must be 133333333 HZ > + - description: Must be 342857143 HZ > + - description: Must be 533000000 HZ > + - description: Must be 533000000 HZ > + - description: Must be 133333333 HZ > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> > + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> > + > + q6v5_wcss: remoteproc@cd00000 { > + compatible = "qcom,ipq5018-q6-mpd"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + reg = <0x0cd00000 0x4040>; > + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, > + <&wcss_smp2p_in 0 0>, > + <&wcss_smp2p_in 1 0>, > + <&wcss_smp2p_in 2 0>, > + <&wcss_smp2p_in 3 0>; > + interrupt-names = "wdog", > + "fatal", > + "ready", > + "handover", > + "stop-ack"; > + > + qcom,smem-states = <&wcss_smp2p_out 0>, > + <&wcss_smp2p_out 1>; > + qcom,smem-state-names = "shutdown", > + "stop"; > + > + memory-region = <&q6_region>; > + > + glink-edge { > + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; > + label = "rtr"; > + qcom,remote-pid = <1>; > + mboxes = <&apcs_glb 8>; > + }; > + > + q6_wcss_pd1: remoteproc_pd1 { > + compatible = "qcom,ipq5018-wcss-ahb-mpd"; > + interrupts-extended = <&wcss_smp2p_in 8 0>, > + <&wcss_smp2p_in 9 0>, > + <&wcss_smp2p_in 12 0>, > + <&wcss_smp2p_in 11 0>; > + interrupt-names = "fatal", > + "ready", > + "spawn-ack", > + "stop-ack"; > + qcom,smem-states = <&wcss_smp2p_out 8>, > + <&wcss_smp2p_out 9>, > + <&wcss_smp2p_out 10>; > + qcom,smem-state-names = "shutdown", > + "stop", > + "spawn"; > + }; > + > + q6_wcss_pd2: remoteproc_pd2 { > + compatible = "qcom,ipq5018-wcss-pcie-mpd"; > + interrupts-extended = <&wcss_smp2p_in 16 0>, > + <&wcss_smp2p_in 17 0>, > + <&wcss_smp2p_in 20 0>, > + <&wcss_smp2p_in 19 0>; > + interrupt-names = "fatal", > + "ready", > + "spawn-ack", > + "stop-ack"; > + > + qcom,smem-states = <&wcss_smp2p_out 16>, > + <&wcss_smp2p_out 17>, > + <&wcss_smp2p_out 18>; > + qcom,smem-state-names = "shutdown", > + "stop", > + "spawn"; > + status = "okay"; Don't need status in examples. > + }; > + > + q6_wcss_pd3: remoteproc_pd3 { > + compatible = "qcom,ipq5018-wcss-pcie-mpd"; > + interrupts-extended = <&wcss_smp2p_in 24 0>, > + <&wcss_smp2p_in 25 0>, > + <&wcss_smp2p_in 28 0>, > + <&wcss_smp2p_in 27 0>; > + interrupt-names = "fatal", > + "ready", > + "spawn-ack", > + "stop-ack"; > + > + qcom,smem-states = <&wcss_smp2p_out 24>, > + <&wcss_smp2p_out 25>, > + <&wcss_smp2p_out 26>; > + qcom,smem-state-names = "shutdown", > + "stop", > + "spawn"; > + status = "okay"; > + }; > + }; > -- > 2.34.1 >
On 07/03/2023 05:41, Manikanta Mylavarapu wrote: > Add new binding document for multipd model remoteproc. > IPQ5018, IPQ9574 follows multipd model. > > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> > --- > .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ > 1 file changed, 282 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml > new file mode 100644 > index 000000000000..b788607f5abd > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml > @@ -0,0 +1,282 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Multipd Secure Peripheral Image Loader > + > +maintainers: > + - Bjorn Andersson <andersson@kernel.org> > + - Mathieu Poirier <mathieu.poirier@linaro.org> > + > +description: > + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd > + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. What is a "pd"? > + > +properties: > + compatible: > + enum: > + - qcom,ipq5018-q6-mpd > + - qcom,ipq9574-q6-mpd > + > + '#address-cells': true > + > + '#size-cells': true Why do you need both? If really needed, these should be const. > + > + 'ranges': true > + Same question - why do you need it? > + reg: > + maxItems: 1 > + > + interrupts-extended: Instead interrupts > + items: > + - description: Watchdog interrupt > + - description: Fatal interrupt > + - description: Ready interrupt > + - description: Handover interrupt > + - description: Stop acknowledge interrupt > + > + interrupt-names: > + items: > + - const: wdog > + - const: fatal > + - const: ready > + - const: handover > + - const: stop-ack > + > + clocks: > + minItems: 25 > + maxItems: 25 Drop both and instead describe the items. Anyway minItems are not needed here. > + > + clock-names: > + minItems: 25 > + maxItems: 25 Drop both and instead list the names. > + > + assigned-clocks: > + minItems: 13 > + maxItems: 13 Drop, they do not have to be mentioned in the binding. If you think they need to, then why? > + > + assigned-clock-rates: > + minItems: 13 > + maxItems: 13 Ditto > + > + qcom,smem-states: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: States used by the AP to signal the remoteprocessor > + items: > + - description: Shutdown Q6 > + - description: Stop Q6 > + > + qcom,smem-state-names: > + description: > + Names of the states used by the AP to signal the remoteprocessor > + items: > + - const: shutdown > + - const: stop > + > + memory-region: > + items: > + - description: Q6 pd reserved region > + > + glink-edge: > + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# unevaluatedProperties: false > + description: > + Qualcomm G-Link subnode which represents communication edge, channels > + and devices related to the Modem. > + > +patternProperties: > + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": No, underscores are not allowed. Also, what is pd? > + type: object > + description: > + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before > + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 > + device node. > + > + properties: > + compatible: > + enum: > + - "qcom,ipq5018-wcss-ahb-mpd" > + - "qcom,ipq9574-wcss-ahb-mpd" > + - "qcom,ipq5018-wcss-pcie-mpd" Drop quotes > + > + interrupts-extended: Same as before > + items: > + - description: Fatal interrupt > + - description: Ready interrupt > + - description: Spawn acknowledge interrupt > + - description: Stop acknowledge interrupt > + > + interrupt-names: > + items: > + - const: fatal > + - const: ready > + - const: spawn-ack > + - const: stop-ack > + > + qcom,smem-states: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: States used by the AP to signal the remoteprocessor > + items: > + - description: Shutdown WCSS pd > + - description: Stop WCSS pd > + - description: Spawn WCSS pd > + > + qcom,smem-state-names: > + description: > + Names of the states used by the AP to signal the remoteprocessor remote processor > + items: > + - const: shutdown > + - const: stop > + - const: spawn This is confusing. Why your children have the same properties as parent? > + > + required: > + - compatible > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts-extended interrupts > + - interrupt-names > + - qcom,smem-states > + - qcom,smem-state-names > + - memory-region > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - qcom,ipq9574-q6-mpd > + then: > + properties: > + assigned-clocks: > + items: > + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK > + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK > + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK > + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK > + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK > + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK > + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK > + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK > + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK > + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK > + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK > + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK > + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK Eh, so here they are. But Why? Do you expect different clocks for others? If so, where are they? Anyway, drop useless "Phandle, clock specifier of". Clocks cannot be anything else than phandle and a clock specifier. Instead of using some cryptic ACRONYM_OR_SOME_CLK, describe them. Just like we do for other bindings. You have plenty of good examples, so please start from them. > + assigned-clock-rates: > + items: > + - description: Must be 266666667 HZ > + - description: Must be 133333333 HZ > + - description: Must be 133333333 HZ > + - description: Must be 133333333 HZ > + - description: Must be 266666667 HZ > + - description: Must be 533000000 HZ > + - description: Must be 342857143 HZ > + - description: Must be 133333333 HZ > + - description: Must be 133333333 HZ > + - description: Must be 342857143 HZ > + - description: Must be 533000000 HZ > + - description: Must be 533000000 HZ > + - description: Must be 133333333 HZ ??? If these are fixed, why this is in DT? DT is for variable and non-discoverable pieces and you do not have here anything variable, but fixed. > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> > + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> Use 4 spaces for example indentation. > + > + q6v5_wcss: remoteproc@cd00000 { > + compatible = "qcom,ipq5018-q6-mpd"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + reg = <0x0cd00000 0x4040>; > + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, > + <&wcss_smp2p_in 0 0>, Wrong alignment of indentation > + <&wcss_smp2p_in 1 0>, > + <&wcss_smp2p_in 2 0>, > + <&wcss_smp2p_in 3 0>; > + interrupt-names = "wdog", > + "fatal", > + "ready", > + "handover", > + "stop-ack"; > + > + qcom,smem-states = <&wcss_smp2p_out 0>, > + <&wcss_smp2p_out 1>; > + qcom,smem-state-names = "shutdown", > + "stop"; > + > + memory-region = <&q6_region>; > + > + glink-edge { > + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; > + label = "rtr"; > + qcom,remote-pid = <1>; > + mboxes = <&apcs_glb 8>; > + }; > + > + q6_wcss_pd1: remoteproc_pd1 { > + compatible = "qcom,ipq5018-wcss-ahb-mpd"; > + interrupts-extended = <&wcss_smp2p_in 8 0>, > + <&wcss_smp2p_in 9 0>, > + <&wcss_smp2p_in 12 0>, > + <&wcss_smp2p_in 11 0>; > + interrupt-names = "fatal", > + "ready", > + "spawn-ack", > + "stop-ack"; > + qcom,smem-states = <&wcss_smp2p_out 8>, > + <&wcss_smp2p_out 9>, > + <&wcss_smp2p_out 10>; > + qcom,smem-state-names = "shutdown", > + "stop", > + "spawn"; > + }; > + > + q6_wcss_pd2: remoteproc_pd2 { > + compatible = "qcom,ipq5018-wcss-pcie-mpd"; > + interrupts-extended = <&wcss_smp2p_in 16 0>, > + <&wcss_smp2p_in 17 0>, > + <&wcss_smp2p_in 20 0>, > + <&wcss_smp2p_in 19 0>; > + interrupt-names = "fatal", > + "ready", > + "spawn-ack", > + "stop-ack"; > + > + qcom,smem-states = <&wcss_smp2p_out 16>, > + <&wcss_smp2p_out 17>, > + <&wcss_smp2p_out 18>; > + qcom,smem-state-names = "shutdown", > + "stop", > + "spawn"; > + status = "okay"; Drop statuses from the example. Best regards, Krzysztof
On 3/7/2023 6:53 PM, Rob Herring wrote: > > On Tue, 07 Mar 2023 10:11:27 +0530, Manikanta Mylavarapu wrote: >> Add new binding document for multipd model remoteproc. >> IPQ5018, IPQ9574 follows multipd model. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >> 1 file changed, 282 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dts:22:18: fatal error: dt-bindings/clock/qcom,gcc-ipq5018.h: No such file or directory > 22 | #include <dt-bindings/clock/qcom,gcc-ipq5018.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1512: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1678164097-13247-2-git-send-email-quic_mmanikan@quicinc.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > I mentioned dependency link (https://lore.kernel.org/linux-arm-msm/20220621161126.15883-1-quic_srichara@quicinc.com/) in cover page patch because it's required for entire series. I will add dependency link's and raise new patchset. Thanks & Regards, Manikanta.
On 03/05/2023 12:59, Manikanta Mylavarapu wrote: > > > On 3/7/2023 6:53 PM, Rob Herring wrote: >> >> On Tue, 07 Mar 2023 10:11:27 +0530, Manikanta Mylavarapu wrote: >>> Add new binding document for multipd model remoteproc. >>> IPQ5018, IPQ9574 follows multipd model. >>> >>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >>> --- >>> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >>> 1 file changed, 282 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dts:22:18: fatal error: dt-bindings/clock/qcom,gcc-ipq5018.h: No such file or directory >> 22 | #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. >> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dtb] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [Makefile:1512: dt_binding_check] Error 2 >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1678164097-13247-2-git-send-email-quic_mmanikan@quicinc.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> > > I mentioned dependency link > (https://lore.kernel.org/linux-arm-msm/20220621161126.15883-1-quic_srichara@quicinc.com/) > in cover page patch because it's required for entire series. I will add > dependency link's and raise new patchset. Is the dependency merged for v6.4-rc1? Looks not, so this means the patch cannot be merged for next three months. Why do you need any dependency here in this binding? Best regards, Krzysztof
On 3/7/2023 8:47 PM, Krzysztof Kozlowski wrote: > On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >> Add new binding document for multipd model remoteproc. >> IPQ5018, IPQ9574 follows multipd model. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >> 1 file changed, 282 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> new file mode 100644 >> index 000000000000..b788607f5abd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> @@ -0,0 +1,282 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Multipd Secure Peripheral Image Loader >> + >> +maintainers: >> + - Bjorn Andersson <andersson@kernel.org> >> + - Mathieu Poirier <mathieu.poirier@linaro.org> >> + >> +description: >> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd >> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. > > What is a "pd"? > Pd means protection domain. It's similar to process in Linux. Here QDSP6 processor runs each wifi radio functionality on a separate process. One process can't access other process resources, so this is termed as PD i.e protection domain. Here we have two pd's called root and user pd. We can correlate Root pd as root and user pd as user in linux. Root pd has more privileges than user pd. From remoteproc driver perspective, root pd corresponds to QDSP6 processor bring up and user pd corresponds to Wifi radio (WCSS) bring up. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,ipq5018-q6-mpd >> + - qcom,ipq9574-q6-mpd >> + >> + '#address-cells': true >> + >> + '#size-cells': true > > Why do you need both? > > If really needed, these should be const. > It's not required. I am going to remove it. >> + >> + 'ranges': true >> + > > Same question - why do you need it? > It's not required. I am going to remove it. >> + reg: >> + maxItems: 1 >> + >> + interrupts-extended: > > Instead interrupts > Sure. I will use 'interrupts'. >> + items: >> + - description: Watchdog interrupt >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Handover interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: wdog >> + - const: fatal >> + - const: ready >> + - const: handover >> + - const: stop-ack >> + >> + clocks: >> + minItems: 25 >> + maxItems: 25 > > Drop both and instead describe the items. Anyway minItems are not needed > here. > Sure. I will drop min & max items and describe clocks. >> + >> + clock-names: >> + minItems: 25 >> + maxItems: 25 > > Drop both and instead list the names. > Sure. I will drop. >> + >> + assigned-clocks: >> + minItems: 13 >> + maxItems: 13 > > Drop, they do not have to be mentioned in the binding. If you think they > need to, then why? > >> + >> + assigned-clock-rates: >> + minItems: 13 >> + maxItems: 13 > > Ditto > >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown Q6 >> + - description: Stop Q6 >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + >> + memory-region: >> + items: >> + - description: Q6 pd reserved region >> + >> + glink-edge: >> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# > > unevaluatedProperties: false > Sure, will add. >> + description: >> + Qualcomm G-Link subnode which represents communication edge, channels >> + and devices related to the Modem. >> + >> +patternProperties: >> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": > > No, underscores are not allowed. Also, what is pd? > Sure, will remove underscores. >> + type: object >> + description: >> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >> + device node. >> + >> + properties: >> + compatible: >> + enum: >> + - "qcom,ipq5018-wcss-ahb-mpd" >> + - "qcom,ipq9574-wcss-ahb-mpd" >> + - "qcom,ipq5018-wcss-pcie-mpd" > > Drop quotes Sure, will remove it. > >> + >> + interrupts-extended: > > Same as before > Sure, will use 'interrupts'. >> + items: >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Spawn acknowledge interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: fatal >> + - const: ready >> + - const: spawn-ack >> + - const: stop-ack >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown WCSS pd >> + - description: Stop WCSS pd >> + - description: Spawn WCSS pd >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor > > remote processor > I will update. >> + items: >> + - const: shutdown >> + - const: stop >> + - const: spawn > > This is confusing. Why your children have the same properties as parent? > Here both parent & child considered as remote processor. So once they powered up/power down/crashed, they used to do some handshaking with APPS processor. So interrupts are common between parent i.e root pd and child i.e user pd >> + >> + required: >> + - compatible >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - interrupts-extended > > interrupts > Sure. I will use 'interrupts' instead of interrupts-extended >> + - interrupt-names >> + - qcom,smem-states >> + - qcom,smem-state-names >> + - memory-region >> + >> +additionalProperties: false >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,ipq9574-q6-mpd >> + then: >> + properties: >> + assigned-clocks: >> + items: >> + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK >> + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK >> + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK > > Eh, so here they are. But Why? Do you expect different clocks for > others? If so, where are they? > > Anyway, drop useless "Phandle, clock specifier of". Clocks cannot be > anything else than phandle and a clock specifier. Instead of using some > cryptic ACRONYM_OR_SOME_CLK, describe them. Just like we do for other > bindings. You have plenty of good examples, so please start from them. > > >> + assigned-clock-rates: >> + items: >> + - description: Must be 266666667 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 266666667 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 133333333 HZ > > ??? > > If these are fixed, why this is in DT? DT is for variable and > non-discoverable pieces and you do not have here anything variable, but > fixed. > >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >> + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> > > Use 4 spaces for example indentation. > Sure, will use 4 spaces. >> + >> + q6v5_wcss: remoteproc@cd00000 { >> + compatible = "qcom,ipq5018-q6-mpd"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + reg = <0x0cd00000 0x4040>; >> + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, >> + <&wcss_smp2p_in 0 0>, > > Wrong alignment of indentation > Sure, will update alignment. >> + <&wcss_smp2p_in 1 0>, >> + <&wcss_smp2p_in 2 0>, >> + <&wcss_smp2p_in 3 0>; >> + interrupt-names = "wdog", >> + "fatal", >> + "ready", >> + "handover", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 0>, >> + <&wcss_smp2p_out 1>; >> + qcom,smem-state-names = "shutdown", >> + "stop"; >> + >> + memory-region = <&q6_region>; >> + >> + glink-edge { >> + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; >> + label = "rtr"; >> + qcom,remote-pid = <1>; >> + mboxes = <&apcs_glb 8>; >> + }; >> + >> + q6_wcss_pd1: remoteproc_pd1 { >> + compatible = "qcom,ipq5018-wcss-ahb-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 8 0>, >> + <&wcss_smp2p_in 9 0>, >> + <&wcss_smp2p_in 12 0>, >> + <&wcss_smp2p_in 11 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + qcom,smem-states = <&wcss_smp2p_out 8>, >> + <&wcss_smp2p_out 9>, >> + <&wcss_smp2p_out 10>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + }; >> + >> + q6_wcss_pd2: remoteproc_pd2 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 16 0>, >> + <&wcss_smp2p_in 17 0>, >> + <&wcss_smp2p_in 20 0>, >> + <&wcss_smp2p_in 19 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 16>, >> + <&wcss_smp2p_out 17>, >> + <&wcss_smp2p_out 18>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; > > Drop statuses from the example. > Sure, will drop status property. > > Best regards, > Krzysztof > Thanks & Regards, Manikanta.
On 3/7/2023 7:56 PM, Rob Herring wrote: > On Tue, Mar 07, 2023 at 10:11:27AM +0530, Manikanta Mylavarapu wrote: >> Add new binding document for multipd model remoteproc. >> IPQ5018, IPQ9574 follows multipd model. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >> 1 file changed, 282 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> new file mode 100644 >> index 000000000000..b788607f5abd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> @@ -0,0 +1,282 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Multipd Secure Peripheral Image Loader >> + >> +maintainers: >> + - Bjorn Andersson <andersson@kernel.org> >> + - Mathieu Poirier <mathieu.poirier@linaro.org> >> + >> +description: >> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd >> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. > > What is PD? I don't see it defined anywhere. > Pd means protection domain. It's similar to process in Linux. Here QDSP6 processor runs each wifi radio functionality on a separate process. One process can't access other process resources, so this is termed as PD i.e protection domain. Here we have two pd's called root and user pd. We can correlate Root pd as root and user pd as user in linux. Root pd has more privileges than user pd. From remoteproc driver perspective, root pd corresponds to QDSP6 processor bring up and user pd corresponds to Wifi radio (WCSS) bring up. I will try to add this info in cover page. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,ipq5018-q6-mpd >> + - qcom,ipq9574-q6-mpd >> + >> + '#address-cells': true > > Need to define the size. > >> + >> + '#size-cells': true > > ditto > It's not required. I am going to remove it. >> + >> + 'ranges': true > > Don't need quotes > It's not required. I am going to remove it. >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts-extended: > > Just 'interrupts'. Both forms are always supported. > Sure, will use 'interrupts' >> + items: >> + - description: Watchdog interrupt >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Handover interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: wdog >> + - const: fatal >> + - const: ready >> + - const: handover >> + - const: stop-ack >> + >> + clocks: >> + minItems: 25 >> + maxItems: 25 > > You need to list out what the clocks are. > Sure. I will do. >> + >> + clock-names: >> + minItems: 25 >> + maxItems: 25 >> + >> + assigned-clocks: > > You can drop this. Implicitly supported. > >> + minItems: 13 >> + maxItems: 13 >> + >> + assigned-clock-rates: >> + minItems: 13 >> + maxItems: 13 >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array > > I believe this already has a type. It should be defined in a common > schema if not already and then included in this schema. > >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown Q6 >> + - description: Stop Q6 >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + >> + memory-region: >> + items: >> + - description: Q6 pd reserved region >> + >> + glink-edge: >> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# >> + description: >> + Qualcomm G-Link subnode which represents communication edge, channels >> + and devices related to the Modem. >> + >> +patternProperties: >> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >> + type: object >> + description: >> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >> + device node. >> + >> + properties: >> + compatible: >> + enum: >> + - "qcom,ipq5018-wcss-ahb-mpd" > > Don't need quotes. > I will remove it. >> + - "qcom,ipq9574-wcss-ahb-mpd" >> + - "qcom,ipq5018-wcss-pcie-mpd" >> + >> + interrupts-extended: > > Just interrupts > I will use 'interrupts' >> + items: >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Spawn acknowledge interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: fatal >> + - const: ready >> + - const: spawn-ack >> + - const: stop-ack >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown WCSS pd >> + - description: Stop WCSS pd >> + - description: Spawn WCSS pd >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + - const: spawn >> + >> + required: >> + - compatible >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - interrupts-extended >> + - interrupt-names >> + - qcom,smem-states >> + - qcom,smem-state-names >> + - memory-region >> + >> +additionalProperties: false >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,ipq9574-q6-mpd >> + then: >> + properties: >> + assigned-clocks: > > Don't need to define assigned-clocks > >> + items: >> + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK >> + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK >> + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK >> + assigned-clock-rates: >> + items: >> + - description: Must be 266666667 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 266666667 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 133333333 HZ >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >> + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> >> + >> + q6v5_wcss: remoteproc@cd00000 { >> + compatible = "qcom,ipq5018-q6-mpd"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + reg = <0x0cd00000 0x4040>; >> + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, >> + <&wcss_smp2p_in 0 0>, >> + <&wcss_smp2p_in 1 0>, >> + <&wcss_smp2p_in 2 0>, >> + <&wcss_smp2p_in 3 0>; >> + interrupt-names = "wdog", >> + "fatal", >> + "ready", >> + "handover", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 0>, >> + <&wcss_smp2p_out 1>; >> + qcom,smem-state-names = "shutdown", >> + "stop"; >> + >> + memory-region = <&q6_region>; >> + >> + glink-edge { >> + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; >> + label = "rtr"; >> + qcom,remote-pid = <1>; >> + mboxes = <&apcs_glb 8>; >> + }; >> + >> + q6_wcss_pd1: remoteproc_pd1 { >> + compatible = "qcom,ipq5018-wcss-ahb-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 8 0>, >> + <&wcss_smp2p_in 9 0>, >> + <&wcss_smp2p_in 12 0>, >> + <&wcss_smp2p_in 11 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + qcom,smem-states = <&wcss_smp2p_out 8>, >> + <&wcss_smp2p_out 9>, >> + <&wcss_smp2p_out 10>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + }; >> + >> + q6_wcss_pd2: remoteproc_pd2 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 16 0>, >> + <&wcss_smp2p_in 17 0>, >> + <&wcss_smp2p_in 20 0>, >> + <&wcss_smp2p_in 19 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 16>, >> + <&wcss_smp2p_out 17>, >> + <&wcss_smp2p_out 18>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; > > Don't need status in examples. > I will remove status property. Thanks & Regards, Manikanta. >> + }; >> + >> + q6_wcss_pd3: remoteproc_pd3 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 24 0>, >> + <&wcss_smp2p_in 25 0>, >> + <&wcss_smp2p_in 28 0>, >> + <&wcss_smp2p_in 27 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 24>, >> + <&wcss_smp2p_out 25>, >> + <&wcss_smp2p_out 26>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; >> + }; >> + }; >> -- >> 2.34.1 >>
On 08/05/2023 15:45, Manikanta Mylavarapu wrote: > > > On 3/7/2023 8:47 PM, Krzysztof Kozlowski wrote: >> On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >>> Add new binding document for multipd model remoteproc. >>> IPQ5018, IPQ9574 follows multipd model. >>> >>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >>> --- >>> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >>> 1 file changed, 282 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> new file mode 100644 >>> index 000000000000..b788607f5abd >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> @@ -0,0 +1,282 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Multipd Secure Peripheral Image Loader >>> + >>> +maintainers: >>> + - Bjorn Andersson <andersson@kernel.org> >>> + - Mathieu Poirier <mathieu.poirier@linaro.org> >>> + >>> +description: >>> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd >>> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. >> >> What is a "pd"? >> > Pd means protection domain. > It's similar to process in Linux. Here QDSP6 processor runs each wifi > radio functionality on a separate process. One process can't access > other process resources, so this is termed as PD i.e protection domain. > Here we have two pd's called root and user pd. We can correlate Root pd > as root and user pd as user in linux. Root pd has more privileges than > user pd. > From remoteproc driver perspective, root pd corresponds to QDSP6 > processor bring up and user pd corresponds to Wifi radio (WCSS) bring up. Parts of it should be in description. And definitely "pd" should be explained. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - qcom,ipq5018-q6-mpd >>> + - qcom,ipq9574-q6-mpd >>> + >>> + '#address-cells': true >>> + >>> + '#size-cells': true ... >> > Sure, will add. >>> + description: >>> + Qualcomm G-Link subnode which represents communication edge, channels >>> + and devices related to the Modem. >>> + >>> +patternProperties: >>> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >> >> No, underscores are not allowed. Also, what is pd? >> > Sure, will remove underscores. Shouldn't this be just pd-1? >>> + type: object >>> + description: >>> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >>> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >>> + device node. >>> + >>> + properties: >>> + compatible: >>> + enum: >>> + - "qcom,ipq5018-wcss-ahb-mpd" >>> + - "qcom,ipq9574-wcss-ahb-mpd" >>> + - "qcom,ipq5018-wcss-pcie-mpd" Best regards, Krzysztof
On 5/9/2023 12:38 PM, Krzysztof Kozlowski wrote: > On 08/05/2023 15:45, Manikanta Mylavarapu wrote: >> >> >> On 3/7/2023 8:47 PM, Krzysztof Kozlowski wrote: >>> On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >>>> Add new binding document for multipd model remoteproc. >>>> IPQ5018, IPQ9574 follows multipd model. >>>> >>>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >>>> --- >>>> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >>>> 1 file changed, 282 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>>> new file mode 100644 >>>> index 000000000000..b788607f5abd >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>>> @@ -0,0 +1,282 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Qualcomm Multipd Secure Peripheral Image Loader >>>> + >>>> +maintainers: >>>> + - Bjorn Andersson <andersson@kernel.org> >>>> + - Mathieu Poirier <mathieu.poirier@linaro.org> >>>> + >>>> +description: >>>> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd >>>> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. >>> >>> What is a "pd"? >>> >> Pd means protection domain. >> It's similar to process in Linux. Here QDSP6 processor runs each wifi >> radio functionality on a separate process. One process can't access >> other process resources, so this is termed as PD i.e protection domain. >> Here we have two pd's called root and user pd. We can correlate Root pd >> as root and user pd as user in linux. Root pd has more privileges than >> user pd. >> From remoteproc driver perspective, root pd corresponds to QDSP6 >> processor bring up and user pd corresponds to Wifi radio (WCSS) bring up. > > Parts of it should be in description. And definitely "pd" should be > explained. > Sure, i will add it in cover page. >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - qcom,ipq5018-q6-mpd >>>> + - qcom,ipq9574-q6-mpd >>>> + >>>> + '#address-cells': true >>>> + >>>> + '#size-cells': true > > ... > >>> >> Sure, will add. >>>> + description: >>>> + Qualcomm G-Link subnode which represents communication edge, channels >>>> + and devices related to the Modem. >>>> + >>>> +patternProperties: >>>> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >>> >>> No, underscores are not allowed. Also, what is pd? >>> >> Sure, will remove underscores. > > Shouldn't this be just pd-1? > > I think 'pd-1' not enough. Because child's i.e userpd's also considered as remote processor's, so name should be like "remoteproc-pd1". >>>> + type: object >>>> + description: >>>> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >>>> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >>>> + device node. >>>> + >>>> + properties: >>>> + compatible: >>>> + enum: >>>> + - "qcom,ipq5018-wcss-ahb-mpd" >>>> + - "qcom,ipq9574-wcss-ahb-mpd" >>>> + - "qcom,ipq5018-wcss-pcie-mpd" > > > > Best regards, > Krzysztof > Thanks & Regards, Manikanta.
On 09/05/2023 12:34, Manikanta Mylavarapu wrote: >>> Sure, will add. >>>>> + description: >>>>> + Qualcomm G-Link subnode which represents communication edge, channels >>>>> + and devices related to the Modem. >>>>> + >>>>> +patternProperties: >>>>> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >>>> >>>> No, underscores are not allowed. Also, what is pd? >>>> >>> Sure, will remove underscores. >> >> Shouldn't this be just pd-1? >> >> > I think 'pd-1' not enough. Because child's i.e userpd's also considered > as remote processor's, so name should be like "remoteproc-pd1". "pd-1" is not enough for what? Why the node name has to be more specific? Best regards, Krzysztof
On 5/9/2023 6:31 PM, Krzysztof Kozlowski wrote: > On 09/05/2023 12:34, Manikanta Mylavarapu wrote: >>>> Sure, will add. >>>>>> + description: >>>>>> + Qualcomm G-Link subnode which represents communication edge, channels >>>>>> + and devices related to the Modem. >>>>>> + >>>>>> +patternProperties: >>>>>> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >>>>> >>>>> No, underscores are not allowed. Also, what is pd? >>>>> >>>> Sure, will remove underscores. >>> >>> Shouldn't this be just pd-1? >>> >>> >> I think 'pd-1' not enough. Because child's i.e userpd's also considered >> as remote processor's, so name should be like "remoteproc-pd1". > > "pd-1" is not enough for what? Why the node name has to be more specific? > > > Best regards, > Krzysztof > Sure. "pd-1" also seems fine. I will change child node name to "pd-1". Thanks & Regards, Manikanta.
On 3/7/2023 7:56 PM, Rob Herring wrote: > On Tue, Mar 07, 2023 at 10:11:27AM +0530, Manikanta Mylavarapu wrote: >> Add new binding document for multipd model remoteproc. >> IPQ5018, IPQ9574 follows multipd model. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >> 1 file changed, 282 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> new file mode 100644 >> index 000000000000..b788607f5abd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> @@ -0,0 +1,282 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Multipd Secure Peripheral Image Loader >> + >> +maintainers: >> + - Bjorn Andersson <andersson@kernel.org> >> + - Mathieu Poirier <mathieu.poirier@linaro.org> >> + >> +description: >> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd >> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. > > What is PD? I don't see it defined anywhere. > >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,ipq5018-q6-mpd >> + - qcom,ipq9574-q6-mpd >> + >> + '#address-cells': true > > Need to define the size. > >> + >> + '#size-cells': true > > ditto > >> + >> + 'ranges': true > > Don't need quotes > >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts-extended: > > Just 'interrupts'. Both forms are always supported. > >> + items: >> + - description: Watchdog interrupt >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Handover interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: wdog >> + - const: fatal >> + - const: ready >> + - const: handover >> + - const: stop-ack >> + >> + clocks: >> + minItems: 25 >> + maxItems: 25 > > You need to list out what the clocks are. > >> + >> + clock-names: >> + minItems: 25 >> + maxItems: 25 >> + >> + assigned-clocks: > > You can drop this. Implicitly supported. > Clocks in multipd architecture will be handled by QDSP6 firmware. So i am going to remove clock handling. >> + minItems: 13 >> + maxItems: 13 >> + >> + assigned-clock-rates: >> + minItems: 13 >> + maxItems: 13 >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array > > I believe this already has a type. It should be defined in a common > schema if not already and then included in this schema. > >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown Q6 >> + - description: Stop Q6 >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + >> + memory-region: >> + items: >> + - description: Q6 pd reserved region >> + >> + glink-edge: >> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# >> + description: >> + Qualcomm G-Link subnode which represents communication edge, channels >> + and devices related to the Modem. >> + >> +patternProperties: >> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >> + type: object >> + description: >> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >> + device node. >> + >> + properties: >> + compatible: >> + enum: >> + - "qcom,ipq5018-wcss-ahb-mpd" > > Don't need quotes. > >> + - "qcom,ipq9574-wcss-ahb-mpd" >> + - "qcom,ipq5018-wcss-pcie-mpd" >> + >> + interrupts-extended: > > Just interrupts > >> + items: >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Spawn acknowledge interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: fatal >> + - const: ready >> + - const: spawn-ack >> + - const: stop-ack >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown WCSS pd >> + - description: Stop WCSS pd >> + - description: Spawn WCSS pd >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + - const: spawn >> + >> + required: >> + - compatible >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - interrupts-extended >> + - interrupt-names >> + - qcom,smem-states >> + - qcom,smem-state-names >> + - memory-region >> + >> +additionalProperties: false >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,ipq9574-q6-mpd >> + then: >> + properties: >> + assigned-clocks: > > Don't need to define assigned-clocks > Clocks in multipd architecture will be handled by QDSP6 firmware. So i am going to remove clock handling. >> + items: >> + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK >> + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK >> + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK >> + assigned-clock-rates: >> + items: >> + - description: Must be 266666667 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 266666667 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 133333333 HZ >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >> + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> >> + >> + q6v5_wcss: remoteproc@cd00000 { >> + compatible = "qcom,ipq5018-q6-mpd"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + reg = <0x0cd00000 0x4040>; >> + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, >> + <&wcss_smp2p_in 0 0>, >> + <&wcss_smp2p_in 1 0>, >> + <&wcss_smp2p_in 2 0>, >> + <&wcss_smp2p_in 3 0>; >> + interrupt-names = "wdog", >> + "fatal", >> + "ready", >> + "handover", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 0>, >> + <&wcss_smp2p_out 1>; >> + qcom,smem-state-names = "shutdown", >> + "stop"; >> + >> + memory-region = <&q6_region>; >> + >> + glink-edge { >> + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; >> + label = "rtr"; >> + qcom,remote-pid = <1>; >> + mboxes = <&apcs_glb 8>; >> + }; >> + >> + q6_wcss_pd1: remoteproc_pd1 { >> + compatible = "qcom,ipq5018-wcss-ahb-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 8 0>, >> + <&wcss_smp2p_in 9 0>, >> + <&wcss_smp2p_in 12 0>, >> + <&wcss_smp2p_in 11 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + qcom,smem-states = <&wcss_smp2p_out 8>, >> + <&wcss_smp2p_out 9>, >> + <&wcss_smp2p_out 10>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + }; >> + >> + q6_wcss_pd2: remoteproc_pd2 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 16 0>, >> + <&wcss_smp2p_in 17 0>, >> + <&wcss_smp2p_in 20 0>, >> + <&wcss_smp2p_in 19 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 16>, >> + <&wcss_smp2p_out 17>, >> + <&wcss_smp2p_out 18>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; > > Don't need status in examples. > >> + }; >> + >> + q6_wcss_pd3: remoteproc_pd3 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 24 0>, >> + <&wcss_smp2p_in 25 0>, >> + <&wcss_smp2p_in 28 0>, >> + <&wcss_smp2p_in 27 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 24>, >> + <&wcss_smp2p_out 25>, >> + <&wcss_smp2p_out 26>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; >> + }; >> + }; >> -- >> 2.34.1 >> Thanks & Regards, Manikanta.
On 3/7/2023 8:47 PM, Krzysztof Kozlowski wrote: > On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >> Add new binding document for multipd model remoteproc. >> IPQ5018, IPQ9574 follows multipd model. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >> 1 file changed, 282 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> new file mode 100644 >> index 000000000000..b788607f5abd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> @@ -0,0 +1,282 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Multipd Secure Peripheral Image Loader >> + >> +maintainers: >> + - Bjorn Andersson <andersson@kernel.org> >> + - Mathieu Poirier <mathieu.poirier@linaro.org> >> + >> +description: >> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd >> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. > > What is a "pd"? > >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,ipq5018-q6-mpd >> + - qcom,ipq9574-q6-mpd >> + >> + '#address-cells': true >> + >> + '#size-cells': true > > Why do you need both? > > If really needed, these should be const. > >> + >> + 'ranges': true >> + > > Same question - why do you need it? > >> + reg: >> + maxItems: 1 >> + >> + interrupts-extended: > > Instead interrupts > >> + items: >> + - description: Watchdog interrupt >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Handover interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: wdog >> + - const: fatal >> + - const: ready >> + - const: handover >> + - const: stop-ack >> + >> + clocks: >> + minItems: 25 >> + maxItems: 25 > > Drop both and instead describe the items. Anyway minItems are not needed > here. > >> + >> + clock-names: >> + minItems: 25 >> + maxItems: 25 > > Drop both and instead list the names. > >> + >> + assigned-clocks: >> + minItems: 13 >> + maxItems: 13 > > Drop, they do not have to be mentioned in the binding. If you think they > need to, then why? > >> + >> + assigned-clock-rates: >> + minItems: 13 >> + maxItems: 13 > > Ditto > Clocks in multipd architecture will be handled by QDSP6 firmware. So i am going to remove clock handling. >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown Q6 >> + - description: Stop Q6 >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + >> + memory-region: >> + items: >> + - description: Q6 pd reserved region >> + >> + glink-edge: >> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# > > unevaluatedProperties: false > >> + description: >> + Qualcomm G-Link subnode which represents communication edge, channels >> + and devices related to the Modem. >> + >> +patternProperties: >> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": > > No, underscores are not allowed. Also, what is pd? > >> + type: object >> + description: >> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >> + device node. >> + >> + properties: >> + compatible: >> + enum: >> + - "qcom,ipq5018-wcss-ahb-mpd" >> + - "qcom,ipq9574-wcss-ahb-mpd" >> + - "qcom,ipq5018-wcss-pcie-mpd" > > Drop quotes > >> + >> + interrupts-extended: > > Same as before > >> + items: >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Spawn acknowledge interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: fatal >> + - const: ready >> + - const: spawn-ack >> + - const: stop-ack >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown WCSS pd >> + - description: Stop WCSS pd >> + - description: Spawn WCSS pd >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor > > remote processor > >> + items: >> + - const: shutdown >> + - const: stop >> + - const: spawn > > This is confusing. Why your children have the same properties as parent? > >> + >> + required: >> + - compatible >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - interrupts-extended > > interrupts > >> + - interrupt-names >> + - qcom,smem-states >> + - qcom,smem-state-names >> + - memory-region >> + >> +additionalProperties: false >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,ipq9574-q6-mpd >> + then: >> + properties: >> + assigned-clocks: >> + items: >> + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK >> + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK >> + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK > > Eh, so here they are. But Why? Do you expect different clocks for > others? If so, where are they? > > Anyway, drop useless "Phandle, clock specifier of". Clocks cannot be > anything else than phandle and a clock specifier. Instead of using some > cryptic ACRONYM_OR_SOME_CLK, describe them. Just like we do for other > bindings. You have plenty of good examples, so please start from them. > > Clocks in multipd architecture will be handled by QDSP6 firmware. So i am going to remove clock handling. >> + assigned-clock-rates: >> + items: >> + - description: Must be 266666667 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 266666667 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 133333333 HZ > > ??? > > If these are fixed, why this is in DT? DT is for variable and > non-discoverable pieces and you do not have here anything variable, but > fixed. > Clocks in multipd architecture will be handled by QDSP6 firmware. So i am going to remove clock handling. Thanks & Regards, Manikanta. >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >> + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> > > Use 4 spaces for example indentation. > >> + >> + q6v5_wcss: remoteproc@cd00000 { >> + compatible = "qcom,ipq5018-q6-mpd"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + reg = <0x0cd00000 0x4040>; >> + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, >> + <&wcss_smp2p_in 0 0>, > > Wrong alignment of indentation > >> + <&wcss_smp2p_in 1 0>, >> + <&wcss_smp2p_in 2 0>, >> + <&wcss_smp2p_in 3 0>; >> + interrupt-names = "wdog", >> + "fatal", >> + "ready", >> + "handover", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 0>, >> + <&wcss_smp2p_out 1>; >> + qcom,smem-state-names = "shutdown", >> + "stop"; >> + >> + memory-region = <&q6_region>; >> + >> + glink-edge { >> + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; >> + label = "rtr"; >> + qcom,remote-pid = <1>; >> + mboxes = <&apcs_glb 8>; >> + }; >> + >> + q6_wcss_pd1: remoteproc_pd1 { >> + compatible = "qcom,ipq5018-wcss-ahb-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 8 0>, >> + <&wcss_smp2p_in 9 0>, >> + <&wcss_smp2p_in 12 0>, >> + <&wcss_smp2p_in 11 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + qcom,smem-states = <&wcss_smp2p_out 8>, >> + <&wcss_smp2p_out 9>, >> + <&wcss_smp2p_out 10>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + }; >> + >> + q6_wcss_pd2: remoteproc_pd2 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 16 0>, >> + <&wcss_smp2p_in 17 0>, >> + <&wcss_smp2p_in 20 0>, >> + <&wcss_smp2p_in 19 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 16>, >> + <&wcss_smp2p_out 17>, >> + <&wcss_smp2p_out 18>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; > > Drop statuses from the example. > > > Best regards, > Krzysztof >
On 5/8/2023 7:15 PM, Manikanta Mylavarapu wrote: > > > On 3/7/2023 8:47 PM, Krzysztof Kozlowski wrote: >> On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >>> Add new binding document for multipd model remoteproc. >>> IPQ5018, IPQ9574 follows multipd model. >>> >>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >>> --- >>> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >>> 1 file changed, 282 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> new file mode 100644 >>> index 000000000000..b788607f5abd >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>> @@ -0,0 +1,282 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Multipd Secure Peripheral Image Loader >>> + >>> +maintainers: >>> + - Bjorn Andersson <andersson@kernel.org> >>> + - Mathieu Poirier <mathieu.poirier@linaro.org> >>> + >>> +description: >>> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, >>> WCSS pd >>> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. >> >> What is a "pd"? >> > Pd means protection domain. > It's similar to process in Linux. Here QDSP6 processor runs each wifi > radio functionality on a separate process. One process can't access > other process resources, so this is termed as PD i.e protection domain. > Here we have two pd's called root and user pd. We can correlate Root pd > as root and user pd as user in linux. Root pd has more privileges than > user pd. > From remoteproc driver perspective, root pd corresponds to QDSP6 > processor bring up and user pd corresponds to Wifi radio (WCSS) bring up. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - qcom,ipq5018-q6-mpd >>> + - qcom,ipq9574-q6-mpd >>> + >>> + '#address-cells': true >>> + >>> + '#size-cells': true >> >> Why do you need both? >> >> If really needed, these should be const. > > It's not required. I am going to remove it. >>> + >>> + 'ranges': true >>> + >> >> Same question - why do you need it? >> > It's not required. I am going to remove it. >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts-extended: >> >> Instead interrupts >> > Sure. I will use 'interrupts'. > Please discard my previous reply. Here i couldn't able to use 'interrupts' because i am using interrupts from two different interrupt controllers. Sorry for previous wrong reply. >>> + items: >>> + - description: Watchdog interrupt >>> + - description: Fatal interrupt >>> + - description: Ready interrupt >>> + - description: Handover interrupt >>> + - description: Stop acknowledge interrupt >>> + >>> + interrupt-names: >>> + items: >>> + - const: wdog >>> + - const: fatal >>> + - const: ready >>> + - const: handover >>> + - const: stop-ack >>> + >>> + clocks: >>> + minItems: 25 >>> + maxItems: 25 >> >> Drop both and instead describe the items. Anyway minItems are not needed >> here. >> > Sure. I will drop min & max items and describe clocks. > >>> + >>> + clock-names: >>> + minItems: 25 >>> + maxItems: 25 >> >> Drop both and instead list the names. >> > Sure. I will drop. > >>> + >>> + assigned-clocks: >>> + minItems: 13 >>> + maxItems: 13 >> >> Drop, they do not have to be mentioned in the binding. If you think they >> need to, then why? >> >>> + >>> + assigned-clock-rates: >>> + minItems: 13 >>> + maxItems: 13 >> >> Ditto >> >>> + >>> + qcom,smem-states: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + description: States used by the AP to signal the remoteprocessor >>> + items: >>> + - description: Shutdown Q6 >>> + - description: Stop Q6 >>> + >>> + qcom,smem-state-names: >>> + description: >>> + Names of the states used by the AP to signal the remoteprocessor >>> + items: >>> + - const: shutdown >>> + - const: stop >>> + >>> + memory-region: >>> + items: >>> + - description: Q6 pd reserved region >>> + >>> + glink-edge: >>> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# >> >> unevaluatedProperties: false >> > Sure, will add. >>> + description: >>> + Qualcomm G-Link subnode which represents communication edge, >>> channels >>> + and devices related to the Modem. >>> + >>> +patternProperties: >>> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >> >> No, underscores are not allowed. Also, what is pd? >> > Sure, will remove underscores. >>> + type: object >>> + description: >>> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be >>> up before >>> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >>> + device node. >>> + >>> + properties: >>> + compatible: >>> + enum: >>> + - "qcom,ipq5018-wcss-ahb-mpd" >>> + - "qcom,ipq9574-wcss-ahb-mpd" >>> + - "qcom,ipq5018-wcss-pcie-mpd" >> >> Drop quotes > Sure, will remove it. >> >>> + >>> + interrupts-extended: >> >> Same as before >> > Sure, will use 'interrupts'. Please discard my previous reply.Here i couldn't able to use 'interrupts' because i am using interrupts from other interrupt controller than inherited one. Sorry for previous wrong reply. Thanks & Regards, Manikanta. >>> + items: >>> + - description: Fatal interrupt >>> + - description: Ready interrupt >>> + - description: Spawn acknowledge interrupt >>> + - description: Stop acknowledge interrupt >>> + >>> + interrupt-names: >>> + items: >>> + - const: fatal >>> + - const: ready >>> + - const: spawn-ack >>> + - const: stop-ack >>> + >>> + qcom,smem-states: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + description: States used by the AP to signal the >>> remoteprocessor >>> + items: >>> + - description: Shutdown WCSS pd >>> + - description: Stop WCSS pd >>> + - description: Spawn WCSS pd >>> + >>> + qcom,smem-state-names: >>> + description: >>> + Names of the states used by the AP to signal the >>> remoteprocessor >> >> remote processor >> > I will update. > >>> + items: >>> + - const: shutdown >>> + - const: stop >>> + - const: spawn >> >> This is confusing. Why your children have the same properties as parent? >> > Here both parent & child considered as remote processor. So once they > powered up/power down/crashed, they used to do some handshaking with > APPS processor. So interrupts are common between parent i.e root pd and > child i.e user pd >>> + >>> + required: >>> + - compatible >>> + >>> + additionalProperties: false >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts-extended >> >> interrupts >> > Sure. I will use 'interrupts' instead of interrupts-extended >>> + - interrupt-names >>> + - qcom,smem-states >>> + - qcom,smem-state-names >>> + - memory-region >>> + >>> +additionalProperties: false >>> + >>> +allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,ipq9574-q6-mpd >>> + then: >>> + properties: >>> + assigned-clocks: >>> + items: >>> + - description: Phandle, clock specifier of >>> GCC_ANOC_WCSS_AXI_M_CLK >>> + - description: Phandle, clock specifier of >>> GCC_WCSS_AHB_S_CLK >>> + - description: Phandle, clock specifier of >>> GCC_WCSS_ECAHB_CLK >>> + - description: Phandle, clock specifier of >>> GCC_WCSS_ACMT_CLK >>> + - description: Phandle, clock specifier of >>> GCC_WCSS_AXI_M_CLK >>> + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK >>> + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK >>> + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK >>> + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK >>> + - description: Phandle, clock specifier of >>> GCC_Q6SS_BOOT_CLK >>> + - description: Phandle, clock specifier of >>> GCC_MEM_NOC_Q6_AXI_CLK >>> + - description: Phandle, clock specifier of >>> GCC_WCSS_Q6_TBU_CLK >>> + - description: Phandle, clock specifier of >>> GCC_SYS_NOC_WCSS_AHB_CLK >> >> Eh, so here they are. But Why? Do you expect different clocks for >> others? If so, where are they? >> >> Anyway, drop useless "Phandle, clock specifier of". Clocks cannot be >> anything else than phandle and a clock specifier. Instead of using some >> cryptic ACRONYM_OR_SOME_CLK, describe them. Just like we do for other >> bindings. You have plenty of good examples, so please start from them. >> >> >>> + assigned-clock-rates: >>> + items: >>> + - description: Must be 266666667 HZ >>> + - description: Must be 133333333 HZ >>> + - description: Must be 133333333 HZ >>> + - description: Must be 133333333 HZ >>> + - description: Must be 266666667 HZ >>> + - description: Must be 533000000 HZ >>> + - description: Must be 342857143 HZ >>> + - description: Must be 133333333 HZ >>> + - description: Must be 133333333 HZ >>> + - description: Must be 342857143 HZ >>> + - description: Must be 533000000 HZ >>> + - description: Must be 533000000 HZ >>> + - description: Must be 133333333 HZ >> >> ??? >> >> If these are fixed, why this is in DT? DT is for variable and >> non-discoverable pieces and you do not have here anything variable, but >> fixed. >> >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/interrupt-controller/arm-gic.h> >>> + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >>> + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> >> >> Use 4 spaces for example indentation. >> > Sure, will use 4 spaces. >>> + >>> + q6v5_wcss: remoteproc@cd00000 { >>> + compatible = "qcom,ipq5018-q6-mpd"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + reg = <0x0cd00000 0x4040>; >>> + interrupts-extended = <&intc GIC_SPI 291 >>> IRQ_TYPE_EDGE_RISING>, >>> + <&wcss_smp2p_in 0 0>, >> >> Wrong alignment of indentation >> > Sure, will update alignment. >>> + <&wcss_smp2p_in 1 0>, >>> + <&wcss_smp2p_in 2 0>, >>> + <&wcss_smp2p_in 3 0>; >>> + interrupt-names = "wdog", >>> + "fatal", >>> + "ready", >>> + "handover", >>> + "stop-ack"; >>> + >>> + qcom,smem-states = <&wcss_smp2p_out 0>, >>> + <&wcss_smp2p_out 1>; >>> + qcom,smem-state-names = "shutdown", >>> + "stop"; >>> + >>> + memory-region = <&q6_region>; >>> + >>> + glink-edge { >>> + interrupts = <GIC_SPI 179 >>> IRQ_TYPE_EDGE_RISING>; >>> + label = "rtr"; >>> + qcom,remote-pid = <1>; >>> + mboxes = <&apcs_glb 8>; >>> + }; >>> + >>> + q6_wcss_pd1: remoteproc_pd1 { >>> + compatible = "qcom,ipq5018-wcss-ahb-mpd"; >>> + interrupts-extended = <&wcss_smp2p_in 8 0>, >>> + <&wcss_smp2p_in 9 0>, >>> + <&wcss_smp2p_in 12 0>, >>> + <&wcss_smp2p_in 11 0>; >>> + interrupt-names = "fatal", >>> + "ready", >>> + "spawn-ack", >>> + "stop-ack"; >>> + qcom,smem-states = <&wcss_smp2p_out 8>, >>> + <&wcss_smp2p_out 9>, >>> + <&wcss_smp2p_out 10>; >>> + qcom,smem-state-names = "shutdown", >>> + "stop", >>> + "spawn"; >>> + }; >>> + >>> + q6_wcss_pd2: remoteproc_pd2 { >>> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >>> + interrupts-extended = <&wcss_smp2p_in 16 0>, >>> + <&wcss_smp2p_in 17 0>, >>> + <&wcss_smp2p_in 20 0>, >>> + <&wcss_smp2p_in 19 0>; >>> + interrupt-names = "fatal", >>> + "ready", >>> + "spawn-ack", >>> + "stop-ack"; >>> + >>> + qcom,smem-states = <&wcss_smp2p_out 16>, >>> + <&wcss_smp2p_out 17>, >>> + <&wcss_smp2p_out 18>; >>> + qcom,smem-state-names = "shutdown", >>> + "stop", >>> + "spawn"; >>> + status = "okay"; >> >> Drop statuses from the example. >> > Sure, will drop status property. >> >> Best regards, >> Krzysztof >> > > Thanks & Regards, > Manikanta.
On 3/7/2023 7:56 PM, Rob Herring wrote: > On Tue, Mar 07, 2023 at 10:11:27AM +0530, Manikanta Mylavarapu wrote: >> Add new binding document for multipd model remoteproc. >> IPQ5018, IPQ9574 follows multipd model. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >> 1 file changed, 282 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> new file mode 100644 >> index 000000000000..b788607f5abd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >> @@ -0,0 +1,282 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Multipd Secure Peripheral Image Loader >> + >> +maintainers: >> + - Bjorn Andersson <andersson@kernel.org> >> + - Mathieu Poirier <mathieu.poirier@linaro.org> >> + >> +description: >> + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd >> + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. > > What is PD? I don't see it defined anywhere. > >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,ipq5018-q6-mpd >> + - qcom,ipq9574-q6-mpd >> + >> + '#address-cells': true > > Need to define the size. > >> + >> + '#size-cells': true > > ditto > >> + >> + 'ranges': true > > Don't need quotes > >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts-extended: > > Just 'interrupts'. Both forms are always supported. > >> + items: >> + - description: Watchdog interrupt >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Handover interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: wdog >> + - const: fatal >> + - const: ready >> + - const: handover >> + - const: stop-ack >> + >> + clocks: >> + minItems: 25 >> + maxItems: 25 > > You need to list out what the clocks are. > >> + >> + clock-names: >> + minItems: 25 >> + maxItems: 25 >> + >> + assigned-clocks: > > You can drop this. Implicitly supported. > >> + minItems: 13 >> + maxItems: 13 >> + >> + assigned-clock-rates: >> + minItems: 13 >> + maxItems: 13 >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array > > I believe this already has a type. It should be defined in a common > schema if not already and then included in this schema. > It's not defined in common schema, so i included here. Thanks & Regards, Manikanta. >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown Q6 >> + - description: Stop Q6 >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + >> + memory-region: >> + items: >> + - description: Q6 pd reserved region >> + >> + glink-edge: >> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# >> + description: >> + Qualcomm G-Link subnode which represents communication edge, channels >> + and devices related to the Modem. >> + >> +patternProperties: >> + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": >> + type: object >> + description: >> + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before >> + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 >> + device node. >> + >> + properties: >> + compatible: >> + enum: >> + - "qcom,ipq5018-wcss-ahb-mpd" > > Don't need quotes. > >> + - "qcom,ipq9574-wcss-ahb-mpd" >> + - "qcom,ipq5018-wcss-pcie-mpd" >> + >> + interrupts-extended: > > Just interrupts > >> + items: >> + - description: Fatal interrupt >> + - description: Ready interrupt >> + - description: Spawn acknowledge interrupt >> + - description: Stop acknowledge interrupt >> + >> + interrupt-names: >> + items: >> + - const: fatal >> + - const: ready >> + - const: spawn-ack >> + - const: stop-ack >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the remoteprocessor >> + items: >> + - description: Shutdown WCSS pd >> + - description: Stop WCSS pd >> + - description: Spawn WCSS pd >> + >> + qcom,smem-state-names: >> + description: >> + Names of the states used by the AP to signal the remoteprocessor >> + items: >> + - const: shutdown >> + - const: stop >> + - const: spawn >> + >> + required: >> + - compatible >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - interrupts-extended >> + - interrupt-names >> + - qcom,smem-states >> + - qcom,smem-state-names >> + - memory-region >> + >> +additionalProperties: false >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,ipq9574-q6-mpd >> + then: >> + properties: >> + assigned-clocks: > > Don't need to define assigned-clocks > >> + items: >> + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK >> + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK >> + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK >> + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK >> + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK >> + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK >> + assigned-clock-rates: >> + items: >> + - description: Must be 266666667 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 266666667 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 133333333 HZ >> + - description: Must be 342857143 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 533000000 HZ >> + - description: Must be 133333333 HZ >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >> + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> >> + >> + q6v5_wcss: remoteproc@cd00000 { >> + compatible = "qcom,ipq5018-q6-mpd"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + reg = <0x0cd00000 0x4040>; >> + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, >> + <&wcss_smp2p_in 0 0>, >> + <&wcss_smp2p_in 1 0>, >> + <&wcss_smp2p_in 2 0>, >> + <&wcss_smp2p_in 3 0>; >> + interrupt-names = "wdog", >> + "fatal", >> + "ready", >> + "handover", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 0>, >> + <&wcss_smp2p_out 1>; >> + qcom,smem-state-names = "shutdown", >> + "stop"; >> + >> + memory-region = <&q6_region>; >> + >> + glink-edge { >> + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; >> + label = "rtr"; >> + qcom,remote-pid = <1>; >> + mboxes = <&apcs_glb 8>; >> + }; >> + >> + q6_wcss_pd1: remoteproc_pd1 { >> + compatible = "qcom,ipq5018-wcss-ahb-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 8 0>, >> + <&wcss_smp2p_in 9 0>, >> + <&wcss_smp2p_in 12 0>, >> + <&wcss_smp2p_in 11 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + qcom,smem-states = <&wcss_smp2p_out 8>, >> + <&wcss_smp2p_out 9>, >> + <&wcss_smp2p_out 10>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + }; >> + >> + q6_wcss_pd2: remoteproc_pd2 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 16 0>, >> + <&wcss_smp2p_in 17 0>, >> + <&wcss_smp2p_in 20 0>, >> + <&wcss_smp2p_in 19 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 16>, >> + <&wcss_smp2p_out 17>, >> + <&wcss_smp2p_out 18>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; > > Don't need status in examples. > >> + }; >> + >> + q6_wcss_pd3: remoteproc_pd3 { >> + compatible = "qcom,ipq5018-wcss-pcie-mpd"; >> + interrupts-extended = <&wcss_smp2p_in 24 0>, >> + <&wcss_smp2p_in 25 0>, >> + <&wcss_smp2p_in 28 0>, >> + <&wcss_smp2p_in 27 0>; >> + interrupt-names = "fatal", >> + "ready", >> + "spawn-ack", >> + "stop-ack"; >> + >> + qcom,smem-states = <&wcss_smp2p_out 24>, >> + <&wcss_smp2p_out 25>, >> + <&wcss_smp2p_out 26>; >> + qcom,smem-state-names = "shutdown", >> + "stop", >> + "spawn"; >> + status = "okay"; >> + }; >> + }; >> -- >> 2.34.1 >>
On 5/3/2023 9:57 PM, Krzysztof Kozlowski wrote: > On 03/05/2023 12:59, Manikanta Mylavarapu wrote: >> >> >> On 3/7/2023 6:53 PM, Rob Herring wrote: >>> >>> On Tue, 07 Mar 2023 10:11:27 +0530, Manikanta Mylavarapu wrote: >>>> Add new binding document for multipd model remoteproc. >>>> IPQ5018, IPQ9574 follows multipd model. >>>> >>>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >>>> --- >>>> .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ >>>> 1 file changed, 282 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dts:22:18: fatal error: dt-bindings/clock/qcom,gcc-ipq5018.h: No such file or directory >>> 22 | #include <dt-bindings/clock/qcom,gcc-ipq5018.h> >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> compilation terminated. >>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.example.dtb] Error 1 >>> make[1]: *** Waiting for unfinished jobs.... >>> make: *** [Makefile:1512: dt_binding_check] Error 2 >>> >>> doc reference errors (make refcheckdocs): >>> >>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1678164097-13247-2-git-send-email-quic_mmanikan@quicinc.com >>> >>> The base for the series is generally the latest rc1. A different dependency >>> should be noted in *this* patch. >>> >>> If you already ran 'make dt_binding_check' and didn't see the above >>> error(s), then make sure 'yamllint' is installed and dt-schema is up to >>> date: >>> >>> pip3 install dtschema --upgrade >>> >>> Please check and re-submit after running the above command yourself. Note >>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >>> your schema. However, it must be unset to test all examples with your schema. >>> >> >> I mentioned dependency link >> (https://lore.kernel.org/linux-arm-msm/20220621161126.15883-1-quic_srichara@quicinc.com/) >> in cover page patch because it's required for entire series. I will add >> dependency link's and raise new patchset. > > Is the dependency merged for v6.4-rc1? Looks not, so this means the > patch cannot be merged for next three months. > > Why do you need any dependency here in this binding? > > Best regards, > Krzysztof > Since i removed gcc clocks from DTS nodes, dt-bindings are not required. I will remove it. Thanks & Regards, Manikanta.
On 18/05/2023 19:22, Manikanta Mylavarapu wrote: >>> >> It's not required. I am going to remove it. >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + interrupts-extended: >>> >>> Instead interrupts >>> >> Sure. I will use 'interrupts'. >> > Please discard my previous reply. Here i couldn't able to use > 'interrupts' because i am using interrupts from two different interrupt > controllers. Sorry for previous wrong reply. The bindings still should have interrupts. I did not comment on DTS, but on bindings. interrupts imply (or allow) interrupts-extended. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml new file mode 100644 index 000000000000..b788607f5abd --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml @@ -0,0 +1,282 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Multipd Secure Peripheral Image Loader + +maintainers: + - Bjorn Andersson <andersson@kernel.org> + - Mathieu Poirier <mathieu.poirier@linaro.org> + +description: + Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd + remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. + +properties: + compatible: + enum: + - qcom,ipq5018-q6-mpd + - qcom,ipq9574-q6-mpd + + '#address-cells': true + + '#size-cells': true + + 'ranges': true + + reg: + maxItems: 1 + + interrupts-extended: + items: + - description: Watchdog interrupt + - description: Fatal interrupt + - description: Ready interrupt + - description: Handover interrupt + - description: Stop acknowledge interrupt + + interrupt-names: + items: + - const: wdog + - const: fatal + - const: ready + - const: handover + - const: stop-ack + + clocks: + minItems: 25 + maxItems: 25 + + clock-names: + minItems: 25 + maxItems: 25 + + assigned-clocks: + minItems: 13 + maxItems: 13 + + assigned-clock-rates: + minItems: 13 + maxItems: 13 + + qcom,smem-states: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: States used by the AP to signal the remoteprocessor + items: + - description: Shutdown Q6 + - description: Stop Q6 + + qcom,smem-state-names: + description: + Names of the states used by the AP to signal the remoteprocessor + items: + - const: shutdown + - const: stop + + memory-region: + items: + - description: Q6 pd reserved region + + glink-edge: + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# + description: + Qualcomm G-Link subnode which represents communication edge, channels + and devices related to the Modem. + +patternProperties: + "^remoteproc_pd1|remoteproc_pd2|remoteproc_pd3": + type: object + description: + In Multipd model, WCSS pd depends on Q6 pd i.e Q6 pd should be up before + WCSS. It can be achieved by keeping wcss pd node as subnode of Q6 + device node. + + properties: + compatible: + enum: + - "qcom,ipq5018-wcss-ahb-mpd" + - "qcom,ipq9574-wcss-ahb-mpd" + - "qcom,ipq5018-wcss-pcie-mpd" + + interrupts-extended: + items: + - description: Fatal interrupt + - description: Ready interrupt + - description: Spawn acknowledge interrupt + - description: Stop acknowledge interrupt + + interrupt-names: + items: + - const: fatal + - const: ready + - const: spawn-ack + - const: stop-ack + + qcom,smem-states: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: States used by the AP to signal the remoteprocessor + items: + - description: Shutdown WCSS pd + - description: Stop WCSS pd + - description: Spawn WCSS pd + + qcom,smem-state-names: + description: + Names of the states used by the AP to signal the remoteprocessor + items: + - const: shutdown + - const: stop + - const: spawn + + required: + - compatible + + additionalProperties: false + +required: + - compatible + - reg + - interrupts-extended + - interrupt-names + - qcom,smem-states + - qcom,smem-state-names + - memory-region + +additionalProperties: false + +allOf: + - if: + properties: + compatible: + enum: + - qcom,ipq9574-q6-mpd + then: + properties: + assigned-clocks: + items: + - description: Phandle, clock specifier of GCC_ANOC_WCSS_AXI_M_CLK + - description: Phandle, clock specifier of GCC_WCSS_AHB_S_CLK + - description: Phandle, clock specifier of GCC_WCSS_ECAHB_CLK + - description: Phandle, clock specifier of GCC_WCSS_ACMT_CLK + - description: Phandle, clock specifier of GCC_WCSS_AXI_M_CLK + - description: Phandle, clock specifier of GCC_Q6_AXIM_CLK + - description: Phandle, clock specifier of GCC_Q6_AXIM2_CLK + - description: Phandle, clock specifier of GCC_Q6_AHB_CLK + - description: Phandle, clock specifier of GCC_Q6_AHB_S_CLK + - description: Phandle, clock specifier of GCC_Q6SS_BOOT_CLK + - description: Phandle, clock specifier of GCC_MEM_NOC_Q6_AXI_CLK + - description: Phandle, clock specifier of GCC_WCSS_Q6_TBU_CLK + - description: Phandle, clock specifier of GCC_SYS_NOC_WCSS_AHB_CLK + assigned-clock-rates: + items: + - description: Must be 266666667 HZ + - description: Must be 133333333 HZ + - description: Must be 133333333 HZ + - description: Must be 133333333 HZ + - description: Must be 266666667 HZ + - description: Must be 533000000 HZ + - description: Must be 342857143 HZ + - description: Must be 133333333 HZ + - description: Must be 133333333 HZ + - description: Must be 342857143 HZ + - description: Must be 533000000 HZ + - description: Must be 533000000 HZ + - description: Must be 133333333 HZ + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/qcom,gcc-ipq5018.h> + #include <dt-bindings/reset/qcom,gcc-ipq5018.h> + + q6v5_wcss: remoteproc@cd00000 { + compatible = "qcom,ipq5018-q6-mpd"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + reg = <0x0cd00000 0x4040>; + interrupts-extended = <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, + <&wcss_smp2p_in 0 0>, + <&wcss_smp2p_in 1 0>, + <&wcss_smp2p_in 2 0>, + <&wcss_smp2p_in 3 0>; + interrupt-names = "wdog", + "fatal", + "ready", + "handover", + "stop-ack"; + + qcom,smem-states = <&wcss_smp2p_out 0>, + <&wcss_smp2p_out 1>; + qcom,smem-state-names = "shutdown", + "stop"; + + memory-region = <&q6_region>; + + glink-edge { + interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>; + label = "rtr"; + qcom,remote-pid = <1>; + mboxes = <&apcs_glb 8>; + }; + + q6_wcss_pd1: remoteproc_pd1 { + compatible = "qcom,ipq5018-wcss-ahb-mpd"; + interrupts-extended = <&wcss_smp2p_in 8 0>, + <&wcss_smp2p_in 9 0>, + <&wcss_smp2p_in 12 0>, + <&wcss_smp2p_in 11 0>; + interrupt-names = "fatal", + "ready", + "spawn-ack", + "stop-ack"; + qcom,smem-states = <&wcss_smp2p_out 8>, + <&wcss_smp2p_out 9>, + <&wcss_smp2p_out 10>; + qcom,smem-state-names = "shutdown", + "stop", + "spawn"; + }; + + q6_wcss_pd2: remoteproc_pd2 { + compatible = "qcom,ipq5018-wcss-pcie-mpd"; + interrupts-extended = <&wcss_smp2p_in 16 0>, + <&wcss_smp2p_in 17 0>, + <&wcss_smp2p_in 20 0>, + <&wcss_smp2p_in 19 0>; + interrupt-names = "fatal", + "ready", + "spawn-ack", + "stop-ack"; + + qcom,smem-states = <&wcss_smp2p_out 16>, + <&wcss_smp2p_out 17>, + <&wcss_smp2p_out 18>; + qcom,smem-state-names = "shutdown", + "stop", + "spawn"; + status = "okay"; + }; + + q6_wcss_pd3: remoteproc_pd3 { + compatible = "qcom,ipq5018-wcss-pcie-mpd"; + interrupts-extended = <&wcss_smp2p_in 24 0>, + <&wcss_smp2p_in 25 0>, + <&wcss_smp2p_in 28 0>, + <&wcss_smp2p_in 27 0>; + interrupt-names = "fatal", + "ready", + "spawn-ack", + "stop-ack"; + + qcom,smem-states = <&wcss_smp2p_out 24>, + <&wcss_smp2p_out 25>, + <&wcss_smp2p_out 26>; + qcom,smem-state-names = "shutdown", + "stop", + "spawn"; + status = "okay"; + }; + };
Add new binding document for multipd model remoteproc. IPQ5018, IPQ9574 follows multipd model. Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> --- .../bindings/remoteproc/qcom,multipd-pil.yaml | 282 ++++++++++++++++++ 1 file changed, 282 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml