| Message ID | 1670432278-30643-3-git-send-email-quic_khsieh@quicinc.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add data-lanes and link-frequencies to dp_out endpoint | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 31 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 07/12/2022 18:57, Kuogee Hsieh wrote: > Add both data-lanes and link-frequencies property into endpoint > > Changes in v7: > -- split yaml out of dtsi patch > -- link-frequencies from link rate to symbol rate > -- deprecation of old data-lanes property > > Changes in v8: > -- correct Bjorn mail address to kernel.org > > Changes in v10: > -- add menu item to data-lanes and link-frequecnis > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>` > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index f2515af..c4a278f 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -81,6 +81,7 @@ properties: > > data-lanes: > $ref: /schemas/types.yaml#/definitions/uint32-array > + deprecated: true > minItems: 1 > maxItems: 4 > items: > @@ -104,6 +105,15 @@ properties: > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: Output endpoint of the controller > + data-lanes: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 4 > + > + link-frequencies: > + $ref: /schemas/types.yaml#/definitions/uint64-array > + minItems: 1 > + maxItems: 4 There is an issue here. You are describing the properties beneath the port@1, while in reality they are found beneath the endpoint node. See analogix,anx7625.yaml for a proper example. > > required: > - compatible > @@ -193,6 +203,9 @@ examples: > reg = <1>; > endpoint { > remote-endpoint = <&typec>; > + data-lanes = <1 2>; > + link-frequencies = /bits/ 64 <1620000000 2700000000 > + 5400000000 8100000000>; > }; > }; > };
On Wed, 07 Dec 2022 08:57:55 -0800, Kuogee Hsieh wrote: > Add both data-lanes and link-frequencies property into endpoint > > Changes in v7: > -- split yaml out of dtsi patch > -- link-frequencies from link rate to symbol rate > -- deprecation of old data-lanes property > > Changes in v8: > -- correct Bjorn mail address to kernel.org > > Changes in v10: > -- add menu item to data-lanes and link-frequecnis > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>` > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/display/msm/dp-controller.yaml:108:21: [error] syntax error: mapping values are not allowed here (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/msm/dp-controller.example.dts' Documentation/devicetree/bindings/display/msm/dp-controller.yaml:108:21: mapping values are not allowed in this context make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/msm/dp-controller.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/display/msm/dp-controller.yaml:108:21: mapping values are not allowed in this context /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: ignoring, error parsing file make: *** [Makefile:1492: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1670432278-30643-3-git-send-email-quic_khsieh@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index f2515af..c4a278f 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -81,6 +81,7 @@ properties: data-lanes: $ref: /schemas/types.yaml#/definitions/uint32-array + deprecated: true minItems: 1 maxItems: 4 items: @@ -104,6 +105,15 @@ properties: port@1: $ref: /schemas/graph.yaml#/properties/port description: Output endpoint of the controller + data-lanes: + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 4 + + link-frequencies: + $ref: /schemas/types.yaml#/definitions/uint64-array + minItems: 1 + maxItems: 4 required: - compatible @@ -193,6 +203,9 @@ examples: reg = <1>; endpoint { remote-endpoint = <&typec>; + data-lanes = <1 2>; + link-frequencies = /bits/ 64 <1620000000 2700000000 + 5400000000 8100000000>; }; }; };
Add both data-lanes and link-frequencies property into endpoint Changes in v7: -- split yaml out of dtsi patch -- link-frequencies from link rate to symbol rate -- deprecation of old data-lanes property Changes in v8: -- correct Bjorn mail address to kernel.org Changes in v10: -- add menu item to data-lanes and link-frequecnis Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>` --- .../devicetree/bindings/display/msm/dp-controller.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)