| Message ID | 1669018873-4718-2-git-send-email-quic_taozha@quicinc.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support to configure TPDM DSB subunit | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 21/11/2022 08:21, Tao Zhang wrote: > Add property "qcom,dsb-elem-size" to support DSB(Discrete Single > Bit) element for TPDA. Specifies the DSB element size supported > by each monitor connected to the aggregator on each port. Should > be specified in pairs (port, dsb element size). > > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > index c46ddea..e3b58b5 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > @@ -58,6 +58,13 @@ properties: > minItems: 1 > maxItems: 2 > > + qcom,dsb-elem-size: minor nit: Couldn't this be qcom,dsb-element-size ? Its not too long from what we have and is more meaningful. Otherwise, Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> > + description: | > + Specifies the DSB element size supported by each monitor > + connected to the aggregator on each port. Should be specified > + in pairs (port, dsb element size). > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > clocks: > maxItems: 1 > > @@ -100,6 +107,8 @@ examples: > compatible = "qcom,coresight-tpda", "arm,primecell"; > reg = <0x6004000 0x1000>; > > + qcom,dsb-elem-size = <0 32>; > + > clocks = <&aoss_qmp>; > clock-names = "apb_pclk"; >
On 21/11/2022 09:21, Tao Zhang wrote: > Add property "qcom,dsb-elem-size" to support DSB(Discrete Single > Bit) element for TPDA. Specifies the DSB element size supported > by each monitor connected to the aggregator on each port. Should > be specified in pairs (port, dsb element size). > > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > index c46ddea..e3b58b5 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > @@ -58,6 +58,13 @@ properties: > minItems: 1 > maxItems: 2 > > + qcom,dsb-elem-size: > + description: | > + Specifies the DSB element size supported by each monitor > + connected to the aggregator on each port. Should be specified > + in pairs (port, dsb element size). > + $ref: /schemas/types.yaml#/definitions/uint32-matrix Then you need items, probably with maxItems as well, like: https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml#L278 > + > clocks: > maxItems: 1 > Best regards, Krzysztof
On Mon, Nov 21, 2022 at 04:21:05PM +0800, Tao Zhang wrote: > Add property "qcom,dsb-elem-size" to support DSB(Discrete Single > Bit) element for TPDA. Specifies the DSB element size supported > by each monitor connected to the aggregator on each port. Should > be specified in pairs (port, dsb element size). > > Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > index c46ddea..e3b58b5 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > @@ -58,6 +58,13 @@ properties: > minItems: 1 > maxItems: 2 > > + qcom,dsb-elem-size: > + description: | > + Specifies the DSB element size supported by each monitor > + connected to the aggregator on each port. Should be specified > + in pairs (port, dsb element size). Please define DSB somewhere here and not just the commit msg. > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > clocks: > maxItems: 1 > > @@ -100,6 +107,8 @@ examples: > compatible = "qcom,coresight-tpda", "arm,primecell"; > reg = <0x6004000 0x1000>; > > + qcom,dsb-elem-size = <0 32>; > + > clocks = <&aoss_qmp>; > clock-names = "apb_pclk"; > > -- > 2.7.4 > >
diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml index c46ddea..e3b58b5 100644 --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml @@ -58,6 +58,13 @@ properties: minItems: 1 maxItems: 2 + qcom,dsb-elem-size: + description: | + Specifies the DSB element size supported by each monitor + connected to the aggregator on each port. Should be specified + in pairs (port, dsb element size). + $ref: /schemas/types.yaml#/definitions/uint32-matrix + clocks: maxItems: 1 @@ -100,6 +107,8 @@ examples: compatible = "qcom,coresight-tpda", "arm,primecell"; reg = <0x6004000 0x1000>; + qcom,dsb-elem-size = <0 32>; + clocks = <&aoss_qmp>; clock-names = "apb_pclk";
Add property "qcom,dsb-elem-size" to support DSB(Discrete Single Bit) element for TPDA. Specifies the DSB element size supported by each monitor connected to the aggregator on each port. Should be specified in pairs (port, dsb element size). Signed-off-by: Tao Zhang <quic_taozha@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)