| Message ID | 1640085372-1972-1-git-send-email-abel.vesa@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | success |
On Tue, Dec 21, 2021 at 7:16 AM Abel Vesa <abel.vesa@nxp.com> wrote: > > Add i.MX8DXL lpuart compatible to the bindings documentation. > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > --- > > This is a resend of the following, but as a separate patch. > > https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/ > > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > index 6e04e3848261..1f482e166467 100644 > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > @@ -30,6 +30,10 @@ properties: > - items: > - const: fsl,imx8qm-lpuart > - const: fsl,imx8qxp-lpuart > + - items: > + - const: fsl,imx8dxl-lpuart > + - const: fsl,imx8qxp-lpuart > + - const: fsl,imx7ulp-lpuart It doesn't really make sense that imx8qm and imx8dxl are backwards compatible with imx8qxp, but only imx8qm is backwards compatible to imx7ulp. Ir only makes sense if some feature/quirk specific to fsl,imx7ulp-lpuart is gone in imx8qm. Rob
On 21-12-21 09:43:39, Rob Herring wrote: > On Tue, Dec 21, 2021 at 7:16 AM Abel Vesa <abel.vesa@nxp.com> wrote: > > > > Add i.MX8DXL lpuart compatible to the bindings documentation. > > > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > > --- > > > > This is a resend of the following, but as a separate patch. > > > > https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/ > > > > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > index 6e04e3848261..1f482e166467 100644 > > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml > > @@ -30,6 +30,10 @@ properties: > > - items: > > - const: fsl,imx8qm-lpuart > > - const: fsl,imx8qxp-lpuart > > + - items: > > + - const: fsl,imx8dxl-lpuart > > + - const: fsl,imx8qxp-lpuart > > + - const: fsl,imx7ulp-lpuart > > It doesn't really make sense that imx8qm and imx8dxl are backwards > compatible with imx8qxp, but only imx8qm is backwards compatible to > imx7ulp. Ir only makes sense if some feature/quirk specific to > fsl,imx7ulp-lpuart is gone in imx8qm. > Actually, I'll just drop the imx7ulp from the imx8dxl dts nodes and then from this patch. The imx7ulp compatible is not needed anymore because the following commit: b4b844930f27bf7019 ("tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP" got reverted by: 4e9679738a918d8a48 ('Revert "tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"') Will resend with proper changes. > Rob
diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml index 6e04e3848261..1f482e166467 100644 --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml @@ -30,6 +30,10 @@ properties: - items: - const: fsl,imx8qm-lpuart - const: fsl,imx8qxp-lpuart + - items: + - const: fsl,imx8dxl-lpuart + - const: fsl,imx8qxp-lpuart + - const: fsl,imx7ulp-lpuart reg: maxItems: 1
Add i.MX8DXL lpuart compatible to the bindings documentation. Signed-off-by: Abel Vesa <abel.vesa@nxp.com> --- This is a resend of the following, but as a separate patch. https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/ Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++ 1 file changed, 4 insertions(+)