| Message ID | 1634521033-17003-8-git-send-email-hayashi.kunihiko@socionext.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | phy: socionext: Introduce some features for UniPhier SoCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 18 Oct 2021 10:37:12 +0900, Kunihiko Hayashi wrote: > Update AHCI-PHY binding document for UniPhier Pro4 SoC. Pro4 AHCI-PHY > needs to control additional reset lines, "pm", "tx", and "rx" and > additional I/O clock line "gio". > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/phy/socionext,uniphier-ahci-phy.yaml | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml:50:9: [warning] wrong indentation: expected 10 but found 8 (indentation) ./Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml:56:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1542355 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml index 745c525ce6b9..341d9b6a7aa6 100644 --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml @@ -16,6 +16,7 @@ maintainers: properties: compatible: enum: + - socionext,uniphier-pro4-ahci-phy - socionext,uniphier-pxs2-ahci-phy - socionext,uniphier-pxs3-ahci-phy @@ -30,6 +31,9 @@ properties: clock-names: oneOf: + - items: # for Pro4 + - const: gio + - const: link - items: # for PXs2 - const: link - items: # for others @@ -37,12 +41,20 @@ properties: - const: phy resets: - maxItems: 2 + minItems: 2 + maxItems: 5 reset-names: - items: - - const: link - - const: phy + oneOf: + - items: # for Pro4 + - const: gio + - const: link + - const: pm + - const: tx + - const: rx + - items: # for others + - const: link + - const: phy required: - compatible
Update AHCI-PHY binding document for UniPhier Pro4 SoC. Pro4 AHCI-PHY needs to control additional reset lines, "pm", "tx", and "rx" and additional I/O clock line "gio". Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../bindings/phy/socionext,uniphier-ahci-phy.yaml | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)