| Message ID | 1626853288-31223-2-git-send-email-dillon.minfei@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add ilitek ili9341 panel driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Wed, Jul 21, 2021 at 9:41 AM <dillon.minfei@gmail.com> wrote: > From: Dillon Min <dillon.minfei@gmail.com> > > Add documentation for "ilitek,ili9341" panel. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Dillon Min <dillon.minfei@gmail.com> > Reviewed-by: Rob Herring <robh@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Wed, Jul 21, 2021 at 4:18 PM Sam Ravnborg <sam@ravnborg.org> wrote: > Hi Linus, > On Wed, Jul 21, 2021 at 04:00:35PM +0200, Linus Walleij wrote: > > On Wed, Jul 21, 2021 at 9:41 AM <dillon.minfei@gmail.com> wrote: > > > > > From: Dillon Min <dillon.minfei@gmail.com> > > > > > > Add documentation for "ilitek,ili9341" panel. > > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Signed-off-by: Dillon Min <dillon.minfei@gmail.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > will you take care to push the patches now you did the review? Yes but uncertain about patch 2/3 which fixes a DTS file. Normally that should go through the SoC tree. I'm fine with applying 1 & 3 but don't want to cause excess errors in schema validation so I'm a bit ambivalent. I would prefer if patch 2 gets applied to the SoC tree and propagate all the way to linux-next before applying patch 1 & 3 but I understand that will take some time. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml new file mode 100644 index 000000000000..2ed010f91e2d --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9341.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ilitek-9341 Display Panel + +maintainers: + - Dillon Min <dillon.minfei@gmail.com> + +description: | + Ilitek ILI9341 TFT panel driver with SPI control bus + This is a driver for 320x240 TFT panels, accepting a rgb input + streams with 16 bits or 18 bits. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + # ili9341 240*320 Color on stm32f429-disco board + - st,sf-tc240t-9370-t + - const: ilitek,ili9341 + + reg: true + + dc-gpios: + maxItems: 1 + description: Display data/command selection (D/CX) of this DBI panel + + spi-3wire: true + + spi-max-frequency: + const: 10000000 + + port: true + + vci-supply: + description: Analog voltage supply (2.5 .. 3.3V) + + vddi-supply: + description: Voltage supply for interface logic (1.65 .. 3.3 V) + + vddi-led-supply: + description: Voltage supply for the LED driver (1.65 .. 3.3 V) + +additionalProperties: false + +required: + - compatible + - reg + - dc-gpios + - port + +examples: + - |+ + spi { + #address-cells = <1>; + #size-cells = <0>; + panel: display@0 { + compatible = "st,sf-tc240t-9370-t", + "ilitek,ili9341"; + reg = <0>; + spi-3wire; + spi-max-frequency = <10000000>; + dc-gpios = <&gpiod 13 0>; + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; + }; + }; +... +