| Message ID | 1623726033-16073-2-git-send-email-wenbin.mei@mediatek.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 8 lines checked |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Tue, 15 Jun 2021 11:00:33 +0800, Wenbin Mei wrote: > MT8195 mmc host IP is compatible with MT8183, and currently it shows: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which means the compatible string in the device tree would be: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc", > "mediatek,mt8183-mmc"; > The bindings is wrong and that isn't the result we want. > instead we want: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8183-mmc > - items: > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which would give us: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc"; > and > compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc"; > > Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195) > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 15 Jun 2021 at 05:01, Wenbin Mei <wenbin.mei@mediatek.com> wrote: > > MT8195 mmc host IP is compatible with MT8183, and currently it shows: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which means the compatible string in the device tree would be: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc", > "mediatek,mt8183-mmc"; > The bindings is wrong and that isn't the result we want. > instead we want: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8183-mmc > - items: > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which would give us: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc"; > and > compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc"; > > Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195) > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com> Applied for fixes, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index 8648d48..adaba90 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -31,6 +31,8 @@ properties: > - const: mediatek,mt2701-mmc > - items: > - const: mediatek,mt8192-mmc > + - const: mediatek,mt8183-mmc > + - items: > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > > -- > 1.9.1 >
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index 8648d48..adaba90 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -31,6 +31,8 @@ properties: - const: mediatek,mt2701-mmc - items: - const: mediatek,mt8192-mmc + - const: mediatek,mt8183-mmc + - items: - const: mediatek,mt8195-mmc - const: mediatek,mt8183-mmc
MT8195 mmc host IP is compatible with MT8183, and currently it shows: properties: compatible: oneOf: ... - items: - const: mediatek,mt8192-mmc - const: mediatek,mt8195-mmc - const: mediatek,mt8183-mmc which means the compatible string in the device tree would be: compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc", "mediatek,mt8183-mmc"; The bindings is wrong and that isn't the result we want. instead we want: properties: compatible: oneOf: ... - items: - const: mediatek,mt8192-mmc - const: mediatek,mt8183-mmc - items: - const: mediatek,mt8195-mmc - const: mediatek,mt8183-mmc which would give us: compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc"; and compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc"; Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195) Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com> --- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ 1 file changed, 2 insertions(+)