| Message ID | 1611198593-16287-3-git-send-email-peng.fan@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | imx esdhc dt/driver update | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 21 Jan 2021 11:09:51 +0800, peng.fan@nxp.com wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add clock bindings for fsl-imx-esdhc yaml > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:1: 'ahb' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:2: 'per' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml See https://patchwork.ozlabs.org/patch/1429619 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob, > Subject: Re: [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock > bindings > > On Thu, 21 Jan 2021 11:09:51 +0800, peng.fan@nxp.com wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add clock bindings for fsl-imx-esdhc yaml > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 11 > +++++++++++ > > 1 file changed, 11 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: Patch 3/4 addresses the dts, actually I think it is the dts not use correct clock order. Thanks, Peng. > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock > /imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:1: 'ahb' was > expected > From schema: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc > /fsl-imx-esdhc.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock > /imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: clock-names:2: 'per' was > expected > From schema: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc > /fsl-imx-esdhc.yaml > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch > work.ozlabs.org%2Fpatch%2F1429619&data=04%7C01%7Cpeng.fan%40 > nxp.com%7Cc543c002a0b54348d48408d8be25ec0b%7C686ea1d3bc2b4c6fa > 92cd99c5c301635%7C0%7C0%7C637468417375412086%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > JXVCI6Mn0%3D%7C1000&sdata=cISWAn3kYIoqvxr39Mu5NL6rwkebmk > VN1drRi%2BDNwAs%3D&reserved=0 > > This check can fail if there are any dependencies. The base for a patch series > is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
On Thu, Jan 21, 2021 at 6:55 PM Peng Fan <peng.fan@nxp.com> wrote: > > Hi Rob, > > > Subject: Re: [PATCH V2 2/4] dt-bindings: mmc: fsl-imx-esdhc: add clock > > bindings > > > > On Thu, 21 Jan 2021 11:09:51 +0800, peng.fan@nxp.com wrote: > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > Add clock bindings for fsl-imx-esdhc yaml > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 11 > > +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Patch 3/4 addresses the dts, actually I think it is the dts not use correct > clock order. These errors are on the example. Rob
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml index f91e97cd7d4e..c42a3880abf0 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml @@ -103,6 +103,17 @@ properties: Only eMMC HS400 mode need to take care of this property. default: 0 + clocks: + maxItems: 3 + description: + Handle clocks for the sdhc controller. + + clock-names: + items: + - const: ipg + - const: ahb + - const: per + pinctrl-0: minItems: 1 maxItems: 2