diff mbox series

[v13,3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions

Message ID 1608547554-6602-4-git-send-email-gene.chen.richtek@gmail.com
State Not Applicable, archived
Headers show
Series leds: mt6360: Add LED driver for MT6360 | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Gene Chen Dec. 21, 2020, 10:45 a.m. UTC 
From: Gene Chen <gene_chen@richtek.com>

Add LED_FUNCTION_MOONLIGHT definitions

Signed-off-by: Gene Chen <gene_chen@richtek.com>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 include/dt-bindings/leds/common.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Pavel Machek Feb. 19, 2021, 10:47 a.m. UTC | #1 
Hi!

> From: Gene Chen <gene_chen@richtek.com>
> 
> Add LED_FUNCTION_MOONLIGHT definitions
> 
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>

No, sorry, I don't believe we need another define for flash/torch.

Best regards,
								Pavel
Gene Chen March 2, 2021, 6:08 a.m. UTC | #2 
Pavel Machek <pavel@ucw.cz> 於 2021年2月19日 週五 下午6:47寫道：
>
> Hi!
>
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add LED_FUNCTION_MOONLIGHT definitions
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Acked-by: Rob Herring <robh@kernel.org>
>
> No, sorry, I don't believe we need another define for flash/torch.
>

As previous discuss,
> We use term "Moonlight" as reference says
> "When you are trying to imitate moonlight you need to use low voltage,
> softer lighting. You don’t want something that’s too bright"
> which is focus on brightness instead of color.

If any concern about this change, maybe we use LED_FUNCTION_INDICATOR instead?
(refs: https://lkml.org/lkml/2020/11/24/1267)


> Best regards,
>                                                                 Pavel
> --
> http://www.livejournal.com/~pavelmachek
Gene Chen March 22, 2021, 10:54 a.m. UTC | #3 
Gene Chen <gene.chen.richtek@gmail.com> 於 2021年3月2日 週二 下午2:08寫道：
>
> Pavel Machek <pavel@ucw.cz> 於 2021年2月19日 週五 下午6:47寫道：
> >
> > Hi!
> >
> > > From: Gene Chen <gene_chen@richtek.com>
> > >
> > > Add LED_FUNCTION_MOONLIGHT definitions
> > >
> > > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > > Acked-by: Rob Herring <robh@kernel.org>
> >
> > No, sorry, I don't believe we need another define for flash/torch.
> >
>
> As previous discuss,
> > We use term "Moonlight" as reference says
> > "When you are trying to imitate moonlight you need to use low voltage,
> > softer lighting. You don’t want something that’s too bright"
> > which is focus on brightness instead of color.
>
> If any concern about this change, maybe we use LED_FUNCTION_INDICATOR instead?
> (refs: https://lkml.org/lkml/2020/11/24/1267)

Is there any update?

> > Best regards,
> >                                                                 Pavel
> > --
> > http://www.livejournal.com/~pavelmachek
diff mbox series

Patch

diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index 52b619d..843e65d 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -78,6 +78,7 @@ 
 #define LED_FUNCTION_INDICATOR "indicator"
 #define LED_FUNCTION_LAN "lan"
 #define LED_FUNCTION_MAIL "mail"
+#define LED_FUNCTION_MOONLIGHT "moonlight"
 #define LED_FUNCTION_MTD "mtd"
 #define LED_FUNCTION_PANIC "panic"
 #define LED_FUNCTION_PROGRAMMING "programming"