diff mbox series

[2/4] dt-bindings: display: Add ilitek-9341 binding

Message ID 1588746693-31078-2-git-send-email-dillon.minfei@gmail.com
State Changes Requested, archived
Headers show
Series None | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema fail build log

Commit Message

Dillon Min May 6, 2020, 6:31 a.m. UTC
From: dillon min <dillon.minfei@gmail.com>

add ili9341 for stm32f429-disco board
some hardware resources can be found here
https://www.st.com/zh/evaluation-tools/32f429idiscovery.html

Signed-off-by: dillon min <dillon.minfei@gmail.com>
---
 .../bindings/display/panel/ilitek,ili9341.yaml     | 55 ++++++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml

Comments

Rob Herring May 6, 2020, 7:33 p.m. UTC | #1
On Wed,  6 May 2020 14:31:33 +0800, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
> 
> add ili9341 for stm32f429-disco board
> some hardware resources can be found here
> https://www.st.com/zh/evaluation-tools/32f429idiscovery.html
> 
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
>  .../bindings/display/panel/ilitek,ili9341.yaml     | 55 ++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dts:21.13-23: Warning (reg_format): /example-0/display@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: display@0: 'spi-3wire', 'spi-max-frequency' do not match any of the regexes: 'pinctrl-[0-9]+'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: display@0: compatible: Additional items are not allowed ('ilitek,ili9341' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: display@0: compatible:0: 'ilitek,ili9341' was expected
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.example.dt.yaml: display@0: compatible: ['stm32f429-disco,ltdc-panel', 'ilitek,ili9341'] is too long

See https://patchwork.ozlabs.org/patch/1284139

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
new file mode 100644
index 0000000..5138f56
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
@@ -0,0 +1,55 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/ilitek,ili9341.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ilitek-9341 Display Panel
+
+maintainers:
+  - Dillon Min <dillon.minfei@gmail.com>
+
+description: |
+  Ilitek ILI9341 TFT panel driver with SPI control bus
+  This is a driver for 320x240 TFT panels, accepting a rgb input
+  streams that get adapted and scaled to the panel.
+  VCOMH outputs.
+
+properties:
+  compatible:
+    items:
+      - const: ilitek,ili9341
+
+  reg:
+    maxItems: 1
+
+  data-mapping:
+    const: stm32f429-disco,ltdc-panel
+
+  dc-gpios: true
+
+  port: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - dc-gpios
+
+examples:
+  - |
+    panel: display@0 {
+        compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
+        reg = <0>;
+        spi-3wire;
+        spi-max-frequency = <10000000>;
+        dc-gpios = <&gpiod 13 0>;
+        port {
+              panel_in: endpoint {
+                    remote-endpoint = <&display_out>;
+              };
+        };
+    };
+...
+