| Message ID | 1578488123-26127-4-git-send-email-claudiu.beznea@microchip.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | add device tree for SAM9X60 SoC and SAM9X60-EK board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On 08/01/2020 14:55:10+0200, Claudiu Beznea wrote: > Add microchip,<chip>-tcb to DT bindings documentation. This is for > microchip,sam9x60-tcb. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > Documentation/devicetree/bindings/mfd/atmel-tcb.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt > index c4a83e364cb6..e1713e41f6e0 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt > +++ b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt > @@ -1,6 +1,7 @@ > * Device tree bindings for Atmel Timer Counter Blocks > -- compatible: Should be "atmel,<chip>-tcb", "simple-mfd", "syscon". > - <chip> can be "at91rm9200" or "at91sam9x5" > +- compatible: Should be "atmel,<chip>-tcb", "microchip,<chip>-tcb", > + "simple-mfd", "syscon". > + <chip> can be "at91rm9200", "at91sam9x5" or "sam9x60" atmel,sam9x60-tcb, microchip,at91rm9200-tcb and microchip,at91sam9x5-tcb are not allowed and the documentation should reflect that. It would probably be easier to do that on top of the yaml conversion here: https://lore.kernel.org/lkml/20191009224006.5021-2-alexandre.belloni@bootlin.com/
On 10.01.2020 15:40, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 08/01/2020 14:55:10+0200, Claudiu Beznea wrote: >> Add microchip,<chip>-tcb to DT bindings documentation. This is for >> microchip,sam9x60-tcb. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> >> --- >> Documentation/devicetree/bindings/mfd/atmel-tcb.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt >> index c4a83e364cb6..e1713e41f6e0 100644 >> --- a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt >> +++ b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt >> @@ -1,6 +1,7 @@ >> * Device tree bindings for Atmel Timer Counter Blocks >> -- compatible: Should be "atmel,<chip>-tcb", "simple-mfd", "syscon". >> - <chip> can be "at91rm9200" or "at91sam9x5" >> +- compatible: Should be "atmel,<chip>-tcb", "microchip,<chip>-tcb", >> + "simple-mfd", "syscon". >> + <chip> can be "at91rm9200", "at91sam9x5" or "sam9x60" > > atmel,sam9x60-tcb, microchip,at91rm9200-tcb and microchip,at91sam9x5-tcb > are not allowed and the documentation should reflect that. OK! I'll double check it. > > It would probably be easier to do that on top of the yaml conversion > here: > https://lore.kernel.org/lkml/20191009224006.5021-2-alexandre.belloni@bootlin.com/ I don't see this integrated in next-20200110. Am I looking at the wrong branch? > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
On 10/01/2020 14:29:27+0000, Claudiu.Beznea@microchip.com wrote: > > > On 10.01.2020 15:40, Alexandre Belloni wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On 08/01/2020 14:55:10+0200, Claudiu Beznea wrote: > >> Add microchip,<chip>-tcb to DT bindings documentation. This is for > >> microchip,sam9x60-tcb. > >> > >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > >> --- > >> Documentation/devicetree/bindings/mfd/atmel-tcb.txt | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt > >> index c4a83e364cb6..e1713e41f6e0 100644 > >> --- a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt > >> +++ b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt > >> @@ -1,6 +1,7 @@ > >> * Device tree bindings for Atmel Timer Counter Blocks > >> -- compatible: Should be "atmel,<chip>-tcb", "simple-mfd", "syscon". > >> - <chip> can be "at91rm9200" or "at91sam9x5" > >> +- compatible: Should be "atmel,<chip>-tcb", "microchip,<chip>-tcb", > >> + "simple-mfd", "syscon". > >> + <chip> can be "at91rm9200", "at91sam9x5" or "sam9x60" > > > > atmel,sam9x60-tcb, microchip,at91rm9200-tcb and microchip,at91sam9x5-tcb > > are not allowed and the documentation should reflect that. > > OK! I'll double check it. > > > > > It would probably be easier to do that on top of the yaml conversion > > here: > > https://lore.kernel.org/lkml/20191009224006.5021-2-alexandre.belloni@bootlin.com/ > > I don't see this integrated in next-20200110. Am I looking at the wrong branch? > I had a few comments and I need to resend.
diff --git a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt index c4a83e364cb6..e1713e41f6e0 100644 --- a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt +++ b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt @@ -1,6 +1,7 @@ * Device tree bindings for Atmel Timer Counter Blocks -- compatible: Should be "atmel,<chip>-tcb", "simple-mfd", "syscon". - <chip> can be "at91rm9200" or "at91sam9x5" +- compatible: Should be "atmel,<chip>-tcb", "microchip,<chip>-tcb", + "simple-mfd", "syscon". + <chip> can be "at91rm9200", "at91sam9x5" or "sam9x60" - reg: Should contain registers location and length - #address-cells: has to be 1 - #size-cells: has to be 0
Add microchip,<chip>-tcb to DT bindings documentation. This is for microchip,sam9x60-tcb. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- Documentation/devicetree/bindings/mfd/atmel-tcb.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)