| Message ID | 1577428606-69855-2-git-send-email-hanjie.lin@amlogic.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | arm64: meson: Add support for USB on Amlogic A1 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, Dec 27, 2019 at 02:36:41PM +0800, Hanjie Lin wrote: > Add the Amlogic A1 Family USB2 PHY Bindings > > It supports Host mode only. > > Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> > Signed-off-by: Yue Wang <yue.wang@amlogic.com> > --- > .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > new file mode 100644 > index 00000000..2b2c526 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 Amlogic, Inc > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic A1 USB2 PHY > + > +maintainers: > + - Yue Wang <yue.wang@amlogic.com> > + > +properties: > + compatible: > + enum: > + - amlogic,meson-a1-usb2-phy Use 'const' if there's only 1. > + > + reg: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: phy Don't need *-names when there's a single entry. > + > + "#phy-cells": > + const: 0 > + > + power-domains: > + maxItems: 1 > + description: > + a phandle to respective power domain node as described by generic > + PM domain bindings (see power/power_domain.txt for more information). Drop the generic description. No need to duplicate everywhere. > + > +required: > + - compatible > + - reg > + - resets > + - reset-names > + - "#phy-cells" > + - power-domains > + > +examples: > + - | > + usb2_phy1: phy@40000 { > + status = "okay"; > + compatible = "amlogic,a1-usb2-phy"; > + reg = <0x0 0x40000 0x0 0x2000>; > + resets = <&reset RESET_USBPHY>; > + reset-names = "phy"; > + #phy-cells = <0>; > + power-domains = <&pwrc PWRC_USB_ID>; > + }; > -- > 2.7.4 >
On 2020/1/4 8:28, Rob Herring wrote: > On Fri, Dec 27, 2019 at 02:36:41PM +0800, Hanjie Lin wrote: >> Add the Amlogic A1 Family USB2 PHY Bindings >> >> It supports Host mode only. >> >> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> >> Signed-off-by: Yue Wang <yue.wang@amlogic.com> >> --- >> .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 55 ++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> new file mode 100644 >> index 00000000..2b2c526 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> @@ -0,0 +1,55 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +# Copyright 2019 Amlogic, Inc >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Amlogic A1 USB2 PHY >> + >> +maintainers: >> + - Yue Wang <yue.wang@amlogic.com> >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,meson-a1-usb2-phy > > Use 'const' if there's only 1. > Ok >> + >> + reg: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> + reset-names: >> + items: >> + - const: phy > > Don't need *-names when there's a single entry. > Ok >> + >> + "#phy-cells": >> + const: 0 >> + >> + power-domains: >> + maxItems: 1 >> + description: >> + a phandle to respective power domain node as described by generic >> + PM domain bindings (see power/power_domain.txt for more information). > > Drop the generic description. No need to duplicate everywhere. > Ok, I will modify these issues. Thanks Hanjie >> + >> +required: >> + - compatible >> + - reg >> + - resets >> + - reset-names >> + - "#phy-cells" >> + - power-domains >> + >> +examples: >> + - | >> + usb2_phy1: phy@40000 { >> + status = "okay"; >> + compatible = "amlogic,a1-usb2-phy"; >> + reg = <0x0 0x40000 0x0 0x2000>; >> + resets = <&reset RESET_USBPHY>; >> + reset-names = "phy"; >> + #phy-cells = <0>; >> + power-domains = <&pwrc PWRC_USB_ID>; >> + }; >> -- >> 2.7.4 >> > > . >
diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml new file mode 100644 index 00000000..2b2c526 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Amlogic, Inc +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic A1 USB2 PHY + +maintainers: + - Yue Wang <yue.wang@amlogic.com> + +properties: + compatible: + enum: + - amlogic,meson-a1-usb2-phy + + reg: + maxItems: 1 + + resets: + maxItems: 1 + + reset-names: + items: + - const: phy + + "#phy-cells": + const: 0 + + power-domains: + maxItems: 1 + description: + a phandle to respective power domain node as described by generic + PM domain bindings (see power/power_domain.txt for more information). + +required: + - compatible + - reg + - resets + - reset-names + - "#phy-cells" + - power-domains + +examples: + - | + usb2_phy1: phy@40000 { + status = "okay"; + compatible = "amlogic,a1-usb2-phy"; + reg = <0x0 0x40000 0x0 0x2000>; + resets = <&reset RESET_USBPHY>; + reset-names = "phy"; + #phy-cells = <0>; + power-domains = <&pwrc PWRC_USB_ID>; + };