| Message ID | 1570452435-8505-2-git-send-email-talel@amazon.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Amazon's Annapurna Labs POS Driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, Oct 07, 2019 at 03:47:14PM +0300, Talel Shenhar wrote: > Document Amazon's Annapurna Labs POS SoC binding. > > Signed-off-by: Talel Shenhar <talel@amazon.com> > --- > .../bindings/edac/amazon,al-pos-edac.yaml | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml Please fix errors with 'make dt_binding_check' and resubmit. Error: Documentation/devicetree/bindings/edac/amazon,al-pos-edac.example.dts:21.28-29 syntax error FATAL ERROR: Unable to parse input tree Hint: You need an include. > > diff --git a/Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml b/Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml > new file mode 100644 > index 00000000..048c2e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/edac/amazon,al-pos-edac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amazon's Annapurna Labs POS > + > +maintainers: > + - Talel Shenhar <talel@amazon.com> > + - Talel Shenhar <talelshenhar@gmail.com> > + > +description: | > + POS node is defined to describe the Point Of Serialization (POS) error > + detection capability. > + > +properties: > + > + compatible: > + const: "amazon,al-pos-edac" > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: Interrupt for the error event. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + edac@f0070084 { > + compatible = "amazon,al-pos-edac"; > + reg = <0x0 0xf0070084 0x0 0x00000008>; > + interrupt-parent = <&amazon_system_fabric>; > + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; > + }; > -- > 2.7.4 >
Thanks for the review On 10/10/2019 2:29 AM, Rob Herring wrote: > On Mon, Oct 07, 2019 at 03:47:14PM +0300, Talel Shenhar wrote: >> Document Amazon's Annapurna Labs POS SoC binding. >> >> Signed-off-by: Talel Shenhar <talel@amazon.com> >> --- >> .../bindings/edac/amazon,al-pos-edac.yaml | 40 ++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml > Please fix errors with 'make dt_binding_check' and resubmit. > > Error: Documentation/devicetree/bindings/edac/amazon,al-pos-edac.example.dts:21.28-29 syntax error > FATAL ERROR: Unable to parse input tree > > Hint: You need an include. Shall add to v6. By the way, I was not able to see this error by running 'make dt_binding_check', but looking in to 'make dtbs_check' I was.
diff --git a/Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml b/Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml new file mode 100644 index 00000000..048c2e9 --- /dev/null +++ b/Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/edac/amazon,al-pos-edac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amazon's Annapurna Labs POS + +maintainers: + - Talel Shenhar <talel@amazon.com> + - Talel Shenhar <talelshenhar@gmail.com> + +description: | + POS node is defined to describe the Point Of Serialization (POS) error + detection capability. + +properties: + + compatible: + const: "amazon,al-pos-edac" + + reg: + maxItems: 1 + + interrupts: + description: Interrupt for the error event. + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + edac@f0070084 { + compatible = "amazon,al-pos-edac"; + reg = <0x0 0xf0070084 0x0 0x00000008>; + interrupt-parent = <&amazon_system_fabric>; + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; + };
Document Amazon's Annapurna Labs POS SoC binding. Signed-off-by: Talel Shenhar <talel@amazon.com> --- .../bindings/edac/amazon,al-pos-edac.yaml | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml