| Message ID | 1560155683-29584-2-git-send-email-talel@amazon.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Amazon's Annapurna Labs Fabric Interrupt Controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On 10/06/2019 09:34, Talel Shenhar wrote: > Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding. > > Signed-off-by: Talel Shenhar <talel@amazon.com> > --- > .../interrupt-controller/amazon,al-fic.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > new file mode 100644 > index 0000000..4e82fd5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > @@ -0,0 +1,29 @@ > +Amazon's Annapurna Labs Fabric Interrupt Controller > + > +Required properties: > + > +- compatible: should be "amazon,al-fic" > +- reg: physical base address and size of the registers > +- interrupt-controller: identifies the node as an interrupt controller > +- #interrupt-cells: must be 2. > + First cell defines the index of the interrupt within the controller. > + Second cell is used to specify the trigger type and must be one of the > + following: > + - bits[3:0] trigger type and level flags > + 1 = low-to-high edge triggered > + 4 = active high level-sensitive > +- interrupt-parent: specifies the parent interrupt controller. > +- interrupts: describes which input line in the interrupt parent, this > + fic's output is connected to. This field property depends on the parent's > + binding > + > +Example: > + > +amazon_fic: interrupt-controller@0xfd8a8500 { > + compatible = "amazon,al-fic"; > + interrupt-controller; > + #interrupt-cells = <2>; > + reg = <0x0 0xfd8a8500 0x0 0x1000>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>; > +}; > Rob, are you OK with this DT binding? Thanks, M.
On Mon, Jun 10, 2019 at 11:34:42AM +0300, Talel Shenhar wrote: > Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding. > > Signed-off-by: Talel Shenhar <talel@amazon.com> > --- > .../interrupt-controller/amazon,al-fic.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > new file mode 100644 > index 0000000..4e82fd5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > @@ -0,0 +1,29 @@ > +Amazon's Annapurna Labs Fabric Interrupt Controller > + > +Required properties: > + > +- compatible: should be "amazon,al-fic" > +- reg: physical base address and size of the registers > +- interrupt-controller: identifies the node as an interrupt controller > +- #interrupt-cells: must be 2. > + First cell defines the index of the interrupt within the controller. > + Second cell is used to specify the trigger type and must be one of the > + following: > + - bits[3:0] trigger type and level flags > + 1 = low-to-high edge triggered > + 4 = active high level-sensitive No need to define this here. Reference the standard definition. > +- interrupt-parent: specifies the parent interrupt controller. Drop this. It is implied and could be in the parent. > +- interrupts: describes which input line in the interrupt parent, this > + fic's output is connected to. This field property depends on the parent's > + binding > + > +Example: > + > +amazon_fic: interrupt-controller@0xfd8a8500 { Drop the '0x' > + compatible = "amazon,al-fic"; > + interrupt-controller; > + #interrupt-cells = <2>; > + reg = <0x0 0xfd8a8500 0x0 0x1000>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>; > +}; > -- > 2.7.4 >
Marc, should I publish those fixes as new patch that updates the dt-bindings or new patchset to this list? On 7/9/2019 5:23 AM, Rob Herring wrote: > On Mon, Jun 10, 2019 at 11:34:42AM +0300, Talel Shenhar wrote: >> +- #interrupt-cells: must be 2. >> + First cell defines the index of the interrupt within the controller. >> + Second cell is used to specify the trigger type and must be one of the >> + following: >> + - bits[3:0] trigger type and level flags >> + 1 = low-to-high edge triggered >> + 4 = active high level-sensitive > No need to define this here. Reference the standard definition. This device only support those two modes. This definition tries to capture the supported modes. Should I just state that those two modes are supported and then avoid the actual bits and values? > >> +- interrupt-parent: specifies the parent interrupt controller. > Drop this. It is implied and could be in the parent. ack > >> +- interrupts: describes which input line in the interrupt parent, this >> + fic's output is connected to. This field property depends on the parent's >> + binding >> + >> +Example: >> + >> +amazon_fic: interrupt-controller@0xfd8a8500 { > Drop the '0x' ack
On 09/07/2019 06:59, Shenhar, Talel wrote: > Marc, should I publish those fixes as new patch that updates the > dt-bindings or new patchset to this list? If you are going to update the binding, please submit a patch on top of mainline, as it's been merged already. Thanks, M.
Thanks, will do. On 7/9/2019 11:15 AM, Marc Zyngier wrote: > On 09/07/2019 06:59, Shenhar, Talel wrote: >> Marc, should I publish those fixes as new patch that updates the >> dt-bindings or new patchset to this list? > > If you are going to update the binding, please submit a patch on top of > mainline, as it's been merged already. > > Thanks, > > M.
On Tue, Jul 9, 2019 at 12:00 AM Shenhar, Talel <talel@amazon.com> wrote: > > Marc, should I publish those fixes as new patch that updates the > dt-bindings or new patchset to this list? > > On 7/9/2019 5:23 AM, Rob Herring wrote: > > On Mon, Jun 10, 2019 at 11:34:42AM +0300, Talel Shenhar wrote: > >> +- #interrupt-cells: must be 2. > >> + First cell defines the index of the interrupt within the controller. > >> + Second cell is used to specify the trigger type and must be one of the > >> + following: > >> + - bits[3:0] trigger type and level flags > >> + 1 = low-to-high edge triggered > >> + 4 = active high level-sensitive > > No need to define this here. Reference the standard definition. > > This device only support those two modes. > > This definition tries to capture the supported modes. > > Should I just state that those two modes are supported and then avoid > the actual bits and values? Yes. Rob
diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt new file mode 100644 index 0000000..4e82fd5 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt @@ -0,0 +1,29 @@ +Amazon's Annapurna Labs Fabric Interrupt Controller + +Required properties: + +- compatible: should be "amazon,al-fic" +- reg: physical base address and size of the registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: must be 2. + First cell defines the index of the interrupt within the controller. + Second cell is used to specify the trigger type and must be one of the + following: + - bits[3:0] trigger type and level flags + 1 = low-to-high edge triggered + 4 = active high level-sensitive +- interrupt-parent: specifies the parent interrupt controller. +- interrupts: describes which input line in the interrupt parent, this + fic's output is connected to. This field property depends on the parent's + binding + +Example: + +amazon_fic: interrupt-controller@0xfd8a8500 { + compatible = "amazon,al-fic"; + interrupt-controller; + #interrupt-cells = <2>; + reg = <0x0 0xfd8a8500 0x0 0x1000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>; +};
Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding. Signed-off-by: Talel Shenhar <talel@amazon.com> --- .../interrupt-controller/amazon,al-fic.txt | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt